DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples/ipsec-secgw: fix unchecked return value
@ 2019-08-07 12:30 Bernard Iremonger
  2019-08-07 13:39 ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Bernard Iremonger @ 2019-08-07 12:30 UTC (permalink / raw)
  To: dev, konstantin.ananyev, akhil.goyal; +Cc: Bernard Iremonger, stable

Check the return value of the rte_eth_dev_rss_hash_conf_get function.

Coverity issue: 344970
Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
Cc: stable@dpdk.org

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 examples/ipsec-secgw/ipsec.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index dc85adf..5f9d560 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -248,7 +248,14 @@ create_inline_session(struct socket_ctx *skt_ctx, struct ipsec_sa *sa)
 			/* Try RSS. */
 			sa->action[1].type = RTE_FLOW_ACTION_TYPE_RSS;
 			sa->action[1].conf = &action_rss;
-			rte_eth_dev_rss_hash_conf_get(sa->portid, &rss_conf);
+			ret = rte_eth_dev_rss_hash_conf_get(sa->portid,
+					&rss_conf);
+			if (ret != 0) {
+				RTE_LOG(ERR, IPSEC,
+					"rte_eth_dev_rss_hash_conf_get:ret=%d\n",
+					ret);
+				return -1;
+			}
 			for (i = 0, j = 0; i < dev_info.nb_rx_queues; ++i)
 				queue[j++] = i;
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix unchecked return value
  2019-08-07 12:30 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix unchecked return value Bernard Iremonger
@ 2019-08-07 13:39 ` Akhil Goyal
  2019-08-08  7:22   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2019-08-07 13:39 UTC (permalink / raw)
  To: Bernard Iremonger, dev, konstantin.ananyev, Thomas Monjalon; +Cc: stable



> 
> Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> 
> Coverity issue: 344970
> Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Thomas,
Could you please take this patch directly to master.

Regards,
Akhil 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value
  2019-08-07 13:39 ` Akhil Goyal
@ 2019-08-08  7:22   ` " Thomas Monjalon
  2019-08-09 10:21     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-08-08  7:22 UTC (permalink / raw)
  To: Akhil Goyal; +Cc: stable, Bernard Iremonger, dev, konstantin.ananyev

07/08/2019 15:39, Akhil Goyal:
> 
> > 
> > Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> > 
> > Coverity issue: 344970
> > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Thomas,
> Could you please take this patch directly to master.

It doesn't look critical at all.
Why do you want this in DPDK 19.08 without enough time for proper validation testing?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value
  2019-08-08  7:22   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2019-08-09 10:21     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2019-08-09 10:21 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: stable, Bernard Iremonger, dev, konstantin.ananyev



> 
> 07/08/2019 15:39, Akhil Goyal:
> >
> > >
> > > Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> > >
> > > Coverity issue: 344970
> > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline
> crypto")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > > ---
> > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Thomas,
> > Could you please take this patch directly to master.
> 
> It doesn't look critical at all.
> Why do you want this in DPDK 19.08 without enough time for proper validation
> testing?
Yes this one is not a critical fix. We can defer it to next release.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 12:30 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix unchecked return value Bernard Iremonger
2019-08-07 13:39 ` Akhil Goyal
2019-08-08  7:22   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-08-09 10:21     ` Akhil Goyal

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox