From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C06C31E51 for ; Tue, 18 Jun 2019 12:59:09 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8D20720873 for ; Tue, 18 Jun 2019 12:59:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="MyI7yS/3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D20720873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3938C1C197; Tue, 18 Jun 2019 14:59:07 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60045.outbound.protection.outlook.com [40.107.6.45]) by dpdk.org (Postfix) with ESMTP id 6A87C1BBE7 for ; Tue, 18 Jun 2019 14:59:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXqkik9ZXy53T/m2zU0I1FWQqvqnig7vs9Y0C+OP/4Q=; b=MyI7yS/3E2nupN5+PGR2OgdfSRAsXnJTH9wJnq7WLXIF+eqIGSk+LG12V6RoqhS8KhPJ0XKV2iEiz/7QjgiJZT7Ey8hevxggbexEOG+FmwiOCWwq67J30TzAYLDVZi7QCIKFnmfOd0CiVqCLoMf+th3v4KwAx7cg0UnkVcpZ6Fc= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6736.eurprd04.prod.outlook.com (20.179.235.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Tue, 18 Jun 2019 12:59:04 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.1987.014; Tue, 18 Jun 2019 12:59:04 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "fiona.trahe@intel.com" , "declan.doherty@intel.com" Thread-Topic: [PATCH] crypto/openssl: fix inproper freeing of asymmetric crypto keys in rsa Thread-Index: AQHVF357+efk+FsMF0Wv71GPaoCev6ahe4DQ Date: Tue, 18 Jun 2019 12:59:03 +0000 Message-ID: References: <20190531065928.3420-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190531065928.3420-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.0.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f32c76b-8f21-4bd8-c5c1-08d6f3ecbdbe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6736; x-ms-traffictypediagnostic: VE1PR04MB6736: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 007271867D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(376002)(136003)(366004)(199004)(189003)(76176011)(74316002)(66446008)(6246003)(53936002)(76116006)(305945005)(7736002)(8676002)(5660300002)(33656002)(486006)(476003)(8936002)(81156014)(6116002)(71190400001)(71200400001)(446003)(44832011)(11346002)(99286004)(7696005)(316002)(2906002)(68736007)(229853002)(5024004)(4326008)(186003)(81166006)(26005)(66066001)(256004)(52536014)(25786009)(3846002)(478600001)(110136005)(66476007)(102836004)(64756008)(66556008)(66946007)(55016002)(2501003)(54906003)(86362001)(9686003)(14454004)(6506007)(73956011)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6736; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: TnmmnTPRZXRiovPIlNgOzneGYo5ynrCWXCCWiX+eRsb04DzHijrsdCHROmnSOevtaDV32IXlUzWcyaJW5uKtr3B1/UK7HgqOjwRbsiUSx0Vg4cIOvrCdss6MRjr9PPO51ba78zEp1DH6z5E2ComFTsVQRx10MV+e4Aauca/fkf8TyV0khu/Ue+iD0CEymU5+j51isw1gmebqOuxPqlTYTNBCHpfrzDABYBk0kUH6gbK+2IoUgqGWJcp8YgTjvPkKVxjU5cWBfx1H3hZfbopdrZtoZfh9E5eMjIVjG+CzieJuR4sa6exOORBB3gf3ppf0dLiXomVUByHVuGKO0dhpD9dE3vp3BGTp0rxEFpmY1famjBQZo0yb/HB/oDjdGr5r/Eb3eCZMoSQ7uxQlFjNReu5Smsct6eZ+CzOh02EhXXQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f32c76b-8f21-4bd8-c5c1-08d6f3ecbdbe X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2019 12:59:03.9712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6736 Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix inproper freeing of asymmetric crypto keys in rsa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Arek, > In case big number need to be freed, data it contains should be cleared > before especially if it is critical data like private keys. >=20 > Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations") >=20 > Signed-off-by: Arek Kusztal > --- > config/common_base | 4 ++-- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 16 ++++++++-------- > 2 files changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/config/common_base b/config/common_base > index 6b96e0e..a3d8e17 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -573,7 +573,7 @@ CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO=3Dy > # > CONFIG_RTE_LIBRTE_PMD_QAT=3Dy > CONFIG_RTE_LIBRTE_PMD_QAT_SYM=3Dn > -CONFIG_RTE_LIBRTE_PMD_QAT_ASYM=3Dn > +CONFIG_RTE_LIBRTE_PMD_QAT_ASYM=3Dy > # > # Max. number of QuickAssist devices, which can be detected and attached > # > @@ -597,7 +597,7 @@ CONFIG_RTE_LIBRTE_PMD_AESNI_MB=3Dn > # > # Compile PMD for Software backed device > # > -CONFIG_RTE_LIBRTE_PMD_OPENSSL=3Dn > +CONFIG_RTE_LIBRTE_PMD_OPENSSL=3Dy >=20 I think these config changes were done by mistake in this patch. Openssl cannot be enabled by default as it needs external codebase. Please send fix only for openssl driver as the description says. Thanks, Akhil