From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
"Phil Yang (Arm Technology China)" <Phil.Yang@arm.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>, "gage.eads@intel.com" <gage.eads@intel.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: add 128-bit atomic compare exchange
Date: Mon, 24 Jun 2019 17:41:07 +0000 [thread overview]
Message-ID: <VE1PR08MB514999646C1EBC7C047DED9F98E00@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <22963143.DP9djbVQ2r@xps>
>
> 24/06/2019 18:12, Honnappa Nagarahalli:
> > > > > + } else {
> > > > > + rte_panic("Invalid memory order\n");
> > > >
> > > >
> > > > rte_panic should be removed from library. In this case, I think,
> > > > invalid mo can go for strongest barrier.
> >
> > It is added here to capture programming errors.
> > Memory order can be passed during compilation or during run time.
> > 'rte_panic' supports both of these.
> > Adding code with strongest memory order will mask the programming error.
>
> An error must return a specific code from the function.
> rte_panic is really forbidden in libraries.
> We are in the process of removing all of them.
Thank you for clarifying.
In this particular use case, the API is similar to '__atomic_compare_exchange' built-in. Users would expect similar behavior. If we are differing from the standard behavior, we should document it in the API definition.
>
>
next prev parent reply other threads:[~2019-06-24 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 6:41 [dpdk-dev] [PATCH v2 1/3] eal/arm64: add 128-bit atomic compare exchange Jerin Jacob Kollanukkaran
2019-06-24 15:43 ` Phil Yang (Arm Technology China)
2019-06-24 16:12 ` Honnappa Nagarahalli
2019-06-24 16:25 ` Thomas Monjalon
2019-06-24 17:41 ` Honnappa Nagarahalli [this message]
2019-06-25 6:15 ` Jerin Jacob Kollanukkaran
2019-06-26 10:10 ` Phil Yang (Arm Technology China)
-- strict thread matches above, loose matches on Subject: below --
2019-06-23 2:41 [dpdk-dev] [PATCH v1 " Phil Yang
2019-06-23 3:15 ` [dpdk-dev] [PATCH v2 " Phil Yang
2019-06-24 14:46 ` Eads, Gage
2019-06-24 15:35 ` Phil Yang (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB514999646C1EBC7C047DED9F98E00@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Phil.Yang@arm.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).