From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83EFC3A5A1 for ; Wed, 28 Aug 2019 22:10:13 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id F3A292070B for ; Wed, 28 Aug 2019 22:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="5Wmy9YH4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="5Wmy9YH4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3A292070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 62A931C0B6; Thu, 29 Aug 2019 00:10:11 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130085.outbound.protection.outlook.com [40.107.13.85]) by dpdk.org (Postfix) with ESMTP id 4B41A1BE84; Thu, 29 Aug 2019 00:10:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGfGwEcmgl/R8WjcBxwXrdtBYUNGFoKTZ7IRMOslCE8=; b=5Wmy9YH4YvreyUrA+cWvQfLJa7vR9dvgVMpn0YFBXiyo8npPhewhjUAvsqKYiXhnCjC+AgQSbDLFYMzC7o4Bp0GlGXZGFlTVt8SPo5aA35mT+npVhvXzKEVniuJpq/6dT5a1gCZkI4wd9ujs2CJ1o0XUVzHpsRtSzlhe0SskafU= Received: from AM4PR08CA0078.eurprd08.prod.outlook.com (2603:10a6:205:2::49) by DB8PR08MB4953.eurprd08.prod.outlook.com (2603:10a6:10:ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Wed, 28 Aug 2019 22:10:06 +0000 Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by AM4PR08CA0078.outlook.office365.com (2603:10a6:205:2::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2199.15 via Frontend Transport; Wed, 28 Aug 2019 22:10:06 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.16 via Frontend Transport; Wed, 28 Aug 2019 22:10:04 +0000 Received: ("Tessian outbound a25c4e5fef41:v27"); Wed, 28 Aug 2019 22:10:02 +0000 X-CR-MTA-TID: 64aa7808 Received: from f4c2332765ad.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.8.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25C78201-06CD-424A-BB23-AFF762AC260F.1; Wed, 28 Aug 2019 22:09:57 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4c2332765ad.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Aug 2019 22:09:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CEXL5y7nevXG1eNheRE54tkJAR3Fr5fnf4S3tZAlouHyVO1h1cSyk85RdII03i/QInDCJI/40GO8XhxfR0J32ZSV77p+DeKa8sjo7M2edjhw8NodmXYjeC90cllJ9lIbEHtgqiX05lI6VDvbRdRzLureLNrLww2EXeT+R4H9ME5+qBvfQ/e7AKfZmoM0tfSu+R69uEWbrCyZD0kx41MAzN6PpIgJ1xRaiwi3POIWQpgCWXfcSDP6EfghB4NjYflQvoiC2NGcMm+veruKlgJ7MIse9DXy8hIbcNZn20G/iPTmEn/FzB0GcIAw7lTUO6v95gDKTItGvpo82E6CpNb6SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGfGwEcmgl/R8WjcBxwXrdtBYUNGFoKTZ7IRMOslCE8=; b=YpW9ozPbBxCqqsBdmGeOJa/4im7VE1DBgH842XWdc1OWo42blu9Se6rAdISNXjD9x13McVSLWT7JSwny85p31EJgFfQDMDpJPpWpjVm8F3BZr0uI1oenzOKhEl+G3QI0yQ0xShjF0n5hXpyw5oqVMev3d8FeMthocDeM4baKi3yY4et6r/VVbUTHeKvlJX6wsPhRz4ZfsX8xbB/UKHOv3Nyu2ctBnlsB1gNJtakJXvlMpJfNXdiWJiUzK/E5HSxuI2vuRGtztfBVTMzrN23wcdw63WZCKaUnHA8ONA8Gw9qyAfn38YCyLDrqc/2lLUy5APvQDtDq95aLGMnYg5gYTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGfGwEcmgl/R8WjcBxwXrdtBYUNGFoKTZ7IRMOslCE8=; b=5Wmy9YH4YvreyUrA+cWvQfLJa7vR9dvgVMpn0YFBXiyo8npPhewhjUAvsqKYiXhnCjC+AgQSbDLFYMzC7o4Bp0GlGXZGFlTVt8SPo5aA35mT+npVhvXzKEVniuJpq/6dT5a1gCZkI4wd9ujs2CJ1o0XUVzHpsRtSzlhe0SskafU= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5008.eurprd08.prod.outlook.com (10.255.159.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.19; Wed, 28 Aug 2019 22:09:55 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128%3]) with mapi id 15.20.2178.023; Wed, 28 Aug 2019 22:09:55 +0000 From: Honnappa Nagarahalli To: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "qi.z.zhang@intel.com" , "bruce.richardson@intel.com" , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered for aarch64 Thread-Index: AQHVUcQN1A7fWwavRkiLfgrOdL55X6cRNIDw Date: Wed, 28 Aug 2019 22:09:54 +0000 Message-ID: References: <1565693011-33998-1-git-send-email-gavin.hu@arm.com> <1565693011-33998-2-git-send-email-gavin.hu@arm.com> In-Reply-To: <1565693011-33998-2-git-send-email-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: b96b34f6-b8bc-4c4b-a5b1-de8ad9834853.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5b1c5391-84ac-444d-572f-08d72c047afb X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5008; X-MS-TrafficTypeDiagnostic: VE1PR08MB5008:|DB8PR08MB4953: X-MS-Exchange-PUrlCount: 2 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 014304E855 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(13464003)(199004)(189003)(110136005)(5660300002)(71200400001)(71190400001)(11346002)(2906002)(86362001)(81166006)(6436002)(52536014)(14444005)(316002)(76116006)(256004)(446003)(8676002)(81156014)(26005)(8936002)(305945005)(3846002)(99286004)(76176011)(7736002)(6116002)(66066001)(74316002)(9686003)(2501003)(14454004)(478600001)(4326008)(966005)(186003)(53936002)(25786009)(55016002)(33656002)(476003)(102836004)(7696005)(486006)(66446008)(53546011)(66946007)(6506007)(66556008)(64756008)(229853002)(66476007)(54906003)(6306002)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5008; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 7MzvDnmpFabk5fPlmCKtGMkTW+6+O31wUcp6+LS+HSh5iakbz9KU4nu00m765cypLogGMDKkpXGRdMC2nO9hQifQ4s3w/fNMLU6F5oWSjw0WgNnWVnLlU0IkfZZ4FuBjoot/0Bfz4KMyntpub3uvmp/DGAeqfVCEGUs/rvFl9MRI8kCVNwSi7kMKHjX1pEHfcEBGNMSsBvRKgWmzlJc0WSsXq3bDqqIzZAGY4MO3NM11Y4bXunN4tHmBNd/7baorxHUaDKaIFkk3776lNIgUYetCWUN4NhRjwwgBa7ZTcYmfJDmjKkDIXcsL8H8TsJDu2Ryj/aXDQpjrnw4nD/INK/EcrNHLF65g9o80vGcLalV8fU14uGTIrg57zCgxzEtXI64AOrcq9A/Av2eBLGIpesJGuxDrse8GfYnwN9M+9z0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5008 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(396003)(2980300002)(189003)(13464003)(199004)(63370400001)(63350400001)(229853002)(6506007)(102836004)(53546011)(336012)(6246003)(55016002)(52536014)(8936002)(8746002)(81156014)(126002)(8676002)(81166006)(9686003)(6306002)(26005)(356004)(186003)(97756001)(66066001)(54906003)(74316002)(86362001)(446003)(76176011)(7736002)(11346002)(7696005)(450100002)(316002)(4326008)(14444005)(476003)(486006)(25786009)(47776003)(110136005)(305945005)(36906005)(22756006)(26826003)(966005)(2501003)(478600001)(23726003)(70206006)(76130400001)(70586007)(50466002)(33656002)(2906002)(14454004)(5660300002)(3846002)(6116002)(46406003)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR08MB4953; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 0e75074d-3616-4d9c-934f-08d72c0474f8 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB8PR08MB4953; NoDisclaimer: True X-Forefront-PRVS: 014304E855 X-Microsoft-Antispam-Message-Info: s5K9gjW04eGHHI95cgOMNkGgU/GVy4F5nuWkoAVCIDjmTpH/nTCk1Cz98QzlGzLtNcrSi0mVZBLv29iKqfPqkDsFwl6oYZm9N1fKqhCzSGWxbWqiE7e5piOuJ3DIiI6VNf+UpOhjIm3D/qdxEqJpIyagD0rt7ERSaW2OiVpecAX5R2d9W7RMIMOd+pTStLYzYwtI07UgfLfF1hZDu3tQxY80CAwgrJZnmpn4uDBpnMnKAM2LQ/DFN+ho/KuK38oyOX6p2RA05lqAI8xx6sZdxP80In4SzFifZwq8w6u73ednoeu1SaahQmZeoQBGQIYGTeXsN0TTs8XK1XWpWBelUnccxuJSxAS6BHY3T7lj5fXSXkApgDYNay9Uv5X9h/4bgAKFP7lJ1gXn74XfUyA4uUI3l+evurH0nKnKdVKKOSE= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2019 22:10:04.9727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b1c5391-84ac-444d-572f-08d72c047afb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4953 Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Gavin, few comments are inline > -----Original Message----- > From: Gavin Hu > Sent: Tuesday, August 13, 2019 5:44 AM > To: dev@dpdk.org > Cc: nd ; thomas@monjalon.net; jerinj@marvell.com; > pbhagavatula@marvell.com; Honnappa Nagarahalli > ; qi.z.zhang@intel.com; > bruce.richardson@intel.com; stable@dpdk.org > Subject: [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered for > aarch64 >=20 > For x86, the descriptors needs to be loaded in order, so in between two > descriptors loading, there is a compiler barrier in place. IMO, we can skip the above as this change applies to Arm platforms. Instead= , capture this in the code in comments to explain why the ordering of the l= oads is not required. This will help others reading the code.=20 [1] For aarch64, a > patch [2] is in place to survive with discontinuous DD bits, the barriers= can be > removed to take full advantage of out-of-order execution. >=20 > 50% performance gain in the RFC2544 NDR test was measured on ThunderX2. > 12.50% performan gain in the RFC2544 NDR test was measured on Ampere > eMAG80 platform. >=20 > [1] > http://inbox.dpdk.org/users/039ED4275CED7440929022BC67E7061153D71 > 548@ > SHSMSX105.ccr.corp.intel.com/ > [2] https://mails.dpdk.org/archives/stable/2017-October/003324.html >=20 > Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Steve Capper > --- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > index 83572ef..5555e9b 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > @@ -285,7 +285,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, > struct rte_mbuf **rx_pkts, > /* Read desc statuses backwards to avoid race condition */ > /* A.1 load 4 pkts desc */ > descs[3] =3D vld1q_u64((uint64_t *)(rxdp + 3)); > - rte_rmb(); >=20 > /* B.2 copy 2 mbuf point into rx_pkts */ > vst1q_u64((uint64_t *)&rx_pkts[pos], mbp1); > -- > 2.7.4