From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E51F9ECDE20 for ; Wed, 11 Sep 2019 05:32:51 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 3E39921A4C for ; Wed, 11 Sep 2019 05:32:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="BDg72sW1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="BDg72sW1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E39921A4C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 028C91EA9D; Wed, 11 Sep 2019 07:32:50 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66]) by dpdk.org (Postfix) with ESMTP id 4F5C61EA96 for ; Wed, 11 Sep 2019 07:32:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sE+NdnYiepPZDVipgJ2nwK4Pnf42SkfpgGA5lK1ZA5Y=; b=BDg72sW1sjTrLhYBNfOuYaFDKZbRtGAb3zJCjW1xrnXMigsUDBzs5osBDI/Ln700+STJB7Q/G7QtKOZo1cBKXrLatqValerjjgaRaMLF4bvigtFREx9Z8mWRhiwoctmqI2yG5vv5bMFM0KixbplY6Q9ChkzFraBCedgS2UO7Iuk= Received: from VI1PR0802CA0010.eurprd08.prod.outlook.com (2603:10a6:800:aa::20) by AM6PR08MB3957.eurprd08.prod.outlook.com (2603:10a6:20b:a2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Wed, 11 Sep 2019 05:32:41 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::209) by VI1PR0802CA0010.outlook.office365.com (2603:10a6:800:aa::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Wed, 11 Sep 2019 05:32:41 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Wed, 11 Sep 2019 05:32:40 +0000 Received: ("Tessian outbound 46f6b453ea6b:v29"); Wed, 11 Sep 2019 05:32:38 +0000 X-CR-MTA-TID: 64aa7808 Received: from 7a3249e311be.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.1.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 57BCCB9A-7AE5-4771-AD11-EEE36F4A8502.1; Wed, 11 Sep 2019 05:32:33 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7a3249e311be.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 11 Sep 2019 05:32:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4Oxje6QtBHTn2xrzgpTRsn3igCoEVdYZIwW8KuAlx0vlKZHLCeJTDcLz97RZMr0DiAwpjIT2jf+kmU5IAxkX1OL15SwFRyXFfpjbR8Dn+zuu05lp7UoBc1ezntV/6B+MBxyL+B4Vy0tZOsZXAqYsjlR5mOhuV4sBtm2Ssgt4gSjg86tm2VTmOgAQ6KSJo2v+pyZj6A5VUPHYCqfPjRzwLHbTApzk87JoQBKHjiLp4v2gHXz8O2TvCfigHyB5p87WbBntRp57dQKUH9X/P04b87I7XboLj9vuC6OP1o2XHX6VJljy539XwsYJ6PIHSPWRUGczY8v5SP4OsxXVqpYJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sE+NdnYiepPZDVipgJ2nwK4Pnf42SkfpgGA5lK1ZA5Y=; b=JdYyd3zaxBGhwrLqWDtfyYqqsB1/ejutrjF4uCBr3oevJf8U00MFQssvB2NunLN3yY6c6rNclz9AhIek3nuxGbFlgJDoyO7nLClvs/pEu/Zxiy37GmYazi7A0nNCfcviIvI4Dx1IufGrb/m1r3HHeNpM+cE9QCsMxu4AhifuF11UpFFxTZl8+1eHWSO4NeiTDX0Ov390fkZbs2Tg5+HsyIdZ87VhowrV//kJKIlDOpSp29Ky7lg6QloWVBcCEARQqMHB64AKJAS9/OhgH88lmZZ+t1iCHuiwunKOZY7ROqXDDYSMzPOUL7lkQnLX/LS/wx1za5eBFKEucXgVyzGLHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sE+NdnYiepPZDVipgJ2nwK4Pnf42SkfpgGA5lK1ZA5Y=; b=BDg72sW1sjTrLhYBNfOuYaFDKZbRtGAb3zJCjW1xrnXMigsUDBzs5osBDI/Ln700+STJB7Q/G7QtKOZo1cBKXrLatqValerjjgaRaMLF4bvigtFREx9Z8mWRhiwoctmqI2yG5vv5bMFM0KixbplY6Q9ChkzFraBCedgS2UO7Iuk= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5229.eurprd08.prod.outlook.com (10.255.27.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Wed, 11 Sep 2019 05:32:30 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::5050:1354:f0bd:4b92]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::5050:1354:f0bd:4b92%7]) with mapi id 15.20.2241.018; Wed, 11 Sep 2019 05:32:30 +0000 From: Honnappa Nagarahalli To: "Ruifeng Wang (Arm Technology China)" , "Ananyev, Konstantin" , "Kantecki, Tomasz" CC: "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd Thread-Index: AQHVZJ2Q1XHMMc8yV0CKKz3cRmji26cedEgAgAQfuaCAAWEjcIAAgpIAgAGCFvA= Date: Wed, 11 Sep 2019 05:32:30 +0000 Message-ID: References: <20190906102615.36942-1-ruifeng.wang@arm.com> <2601191342CEEE43887BDE71AB977258019192657B@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: cb60633c-b24c-414e-a30f-fd69111ca4f0.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b45b4c05-ddbe-471e-29a8-08d736797687 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5229; X-MS-TrafficTypeDiagnostic: VE1PR08MB5229:|VE1PR08MB5229:|AM6PR08MB3957: X-MS-Exchange-PUrlCount: 2 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 0157DEB61B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(39860400002)(136003)(346002)(199004)(189003)(6116002)(53936002)(478600001)(110136005)(3846002)(316002)(966005)(14454004)(25786009)(7736002)(26005)(6506007)(102836004)(33656002)(229853002)(76176011)(52536014)(5660300002)(74316002)(2906002)(256004)(14444005)(6436002)(186003)(7696005)(66946007)(486006)(66446008)(446003)(11346002)(64756008)(476003)(76116006)(4326008)(305945005)(6246003)(71190400001)(71200400001)(86362001)(8676002)(8936002)(6306002)(55016002)(9686003)(81156014)(81166006)(99286004)(54906003)(66556008)(66476007)(66066001)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5229; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: KGoBosagMfzQcpJ62dWLaYsn2sresnyD3qsboN338p+OOmCEhv50nTl8E2FvNTxSPUEZug6Y4G3tGcMYZpM6oOs+Wc+zDAG84JI+0k5eP8/GL5o0h75pfpFeIhRFpmVtTf3Lz9DxMdGO3l/RFP7YULzBdRL4IXs10S3f4ReODW8Xe5MdPP8f90jeyLI6wqaDNsrChF8Srq9zlpfN/OnRdfAA8i+nByZtEt7ZOKR3QkNx9BZJpxqYeNn3PAMVcZzhQtkJbZylP2Yz7Ruykq2xKr5h9wak+0XaxHaghHCGU2035x5CH3NbQ8zRQDrmszXQ3BGym5t2UUJazWBiL/qP+bqznTcjDtfHaAwTNnHwFt1RrIR8UkSHvkwHKLlwzLvXaz5Nuof2efFIQCyslBSBDjL9EQUuzAYIMS88iw6XKvM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5229 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(39860400002)(396003)(376002)(199004)(189003)(476003)(99286004)(126002)(6506007)(26826003)(25786009)(486006)(110136005)(63350400001)(63370400001)(70206006)(70586007)(54906003)(97756001)(22756006)(446003)(478600001)(11346002)(14444005)(8936002)(86362001)(14454004)(33656002)(52536014)(81156014)(8746002)(4326008)(81166006)(76130400001)(7696005)(76176011)(50466002)(5660300002)(2906002)(8676002)(966005)(336012)(305945005)(55016002)(26005)(7736002)(6306002)(186003)(9686003)(66066001)(6246003)(23726003)(3846002)(6116002)(356004)(316002)(46406003)(74316002)(47776003)(229853002)(102836004)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3957; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 30b5e4ab-0ce2-4fc9-37fb-08d7367970df X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM6PR08MB3957; NoDisclaimer: True X-Forefront-PRVS: 0157DEB61B X-Microsoft-Antispam-Message-Info: hul9FRDESlqRiIbIdlEIe9fUkrqwNdtf384YppXMLln0wQS9GN+eZ3OLn1UfcCZJXf+pgJmy10ahF+UHgAv+dDDEJYwzhI/pGBlTzvY008eHB5csHS3LFa5Mt5F2maY4dP6jO1Mjs/m0DMlmHJhB4uR5sW/bTa25KHceKQC92N/pGBeWDN9GQLtxMraE5O8/4VVmuxg6vOdFib1jSPMmvqaXjNJ7BksMu3VkDLcw+XWu73XaB1WxnQH3T+uaH5Op7cRZwFvD77axpSnERqULpgc16c2x2B5CpUErrfeVPZ2N+fj2V8jiTjH3m8W+xBUm8l2nYeXeEso31c3x0N7oSewU3NXHsQsyO9koLuYam55K+mvqL0PgD9IrjX3Cj4neSwrIKDA0RlqNNuOwBPt1nEgnBtPzoU6k7LYWFoE8nM4= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2019 05:32:40.2455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b45b4c05-ddbe-471e-29a8-08d736797687 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3957 Subject: Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > Lock-free mode is supported by hash library and LPM library. > > > > > Now we add an option for l3fwd example to enable the lock-free > mode. > > > > > Necessary preparation steps are added to use lock-free LPM mode. > > > > > > > > Can I ask about the purpose of these changes? > > > > Right now in l3fwd both lpm and hash tables are static and hard-co= ded. > > > > we initialize them at startup and then just do read from them. > > > > Do you plan to enhance l3fwd with ability to dynamically update > > > > tables contents? > > > > Though fir that we first have to get rid of hard-coded values > > > > (config file or > > > so). > > > > Konstantin > > > > > > > Thanks for your questions. > > > Currently, we have no plan to enhance l3fwd with ability to > > > dynamically update table contents. > > > Lock-free method is being integrated into Hash library and LPM > > > library. Lock- free algorithms are not only about control plane > > > (adding or deleting routes), they affect the data path performance as= well. > > > Since l3fwd application is showcasing data path performance, we need > > > to show the impact of including the quiescent state reporting on data > path. > > > This change also serves as an example of using the RCU APIs. > > > > > Without the dynamic deletes the quiescent state reporting overhead is > > not captured completely. > > I suggest that we add and delete a small set of unrelated routes (the > > routes that are not used currently) on a regular basis. > > > Add and delete unrelated routes on a regular basis will simulate overhead= on > control path. However, control path performance is not a l3fwd showcase, > and it is covered by LPM performance unit test. > On data path, quiescent state reporting overhead is constant (calling of > rte_rcu_qsbr_quiescent). > It will not be impacted by route addition / deletion. The recent changes to RCU [1] are such that the reader threads avoid a writ= e if there are no deletes. So, without the deletion, the impact on readers = is complete. [1] https://patchwork.dpdk.org/patch/58961/ >=20 > > > > > > > > > > Patch 2/2 has dependency on RCU QSBR integration with LPM library= : > > > > > http://patches.dpdk.org/project/dpdk/list/?series=3D6288 > > > > > > > > > > > > > > > Ruifeng Wang (2): > > > > > examples/l3fwd: add lock-free option for l3fwd > > > > > examples/l3fwd: integrate RCU QSBR for LPM mode > > > > > > > > > > doc/guides/sample_app_ug/l3_forward.rst | 3 ++ > > > > > examples/l3fwd/Makefile | 1 + > > > > > examples/l3fwd/l3fwd.h | 4 +- > > > > > examples/l3fwd/l3fwd_em.c | 10 +++- > > > > > examples/l3fwd/l3fwd_lpm.c | 72 > > +++++++++++++++++++++++-- > > > > > examples/l3fwd/main.c | 27 ++++++++-- > > > > > examples/l3fwd/meson.build | 1 + > > > > > 7 files changed, 108 insertions(+), 10 deletions(-) > > > > > > > > > > -- > > > > > 2.17.1 > > > > > >=20