From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87DD1C31E44 for ; Mon, 17 Jun 2019 07:30:39 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id F3DB921BF2 for ; Mon, 17 Jun 2019 07:30:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="F0fqrTe3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3DB921BF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E2341BC7D; Mon, 17 Jun 2019 09:30:38 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30051.outbound.protection.outlook.com [40.107.3.51]) by dpdk.org (Postfix) with ESMTP id 760961BBE5 for ; Mon, 17 Jun 2019 09:30:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZtgXXF5xEphieJaI35puRmoG9B5LGYEAY3Utqz8qDFY=; b=F0fqrTe3zUEFQLT73+sliKcWZAs5cCCbr8Pg4r7hCNNu2QIxI7exMORYqlKO71dLGFr+fxT9ZfK5nG4L1zSnhnuCV/z1cHui46Jtl6ofMYbgX17M+ZvPbDqLcQTSHpfrAElgqsqSDO+7JXLcFx4vTvccJJPqfZY0U5r430jXUCU= Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.62.139) by VI1PR0401MB2623.eurprd04.prod.outlook.com (10.168.61.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Mon, 17 Jun 2019 07:30:35 +0000 Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::a0fe:54d5:3ce0:5f6a]) by VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::a0fe:54d5:3ce0:5f6a%8]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 07:30:35 +0000 From: Hemant Agrawal To: Neil Horman , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Bruce Richardson , Thomas Monjalon , Shreyansh Jain Thread-Topic: [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal Thread-Index: AQHVIfO1SAD/0vQdcEurvr2RNsm1HKafdgfQ Date: Mon, 17 Jun 2019 07:30:34 +0000 Message-ID: References: <20190525184346.27932-1-nhorman@tuxdriver.com> <20190613142344.9188-1-nhorman@tuxdriver.com> <20190613142344.9188-6-nhorman@tuxdriver.com> In-Reply-To: <20190613142344.9188-6-nhorman@tuxdriver.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [92.120.1.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eae1baf8-abec-480a-3e33-08d6f2f5afd3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR0401MB2623; x-ms-traffictypediagnostic: VI1PR0401MB2623: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(136003)(366004)(376002)(346002)(13464003)(189003)(199004)(33656002)(6246003)(316002)(86362001)(74316002)(26005)(53546011)(7696005)(486006)(446003)(53936002)(25786009)(229853002)(11346002)(476003)(99286004)(186003)(14444005)(52536014)(256004)(102836004)(44832011)(2501003)(5660300002)(6506007)(71190400001)(76176011)(71200400001)(66946007)(73956011)(76116006)(305945005)(110136005)(14454004)(54906003)(6116002)(4744005)(8936002)(81166006)(2906002)(478600001)(66446008)(64756008)(66556008)(66476007)(9686003)(66066001)(4326008)(6436002)(7736002)(68736007)(8676002)(81156014)(55016002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2623; H:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MAdj+PikNIRJNluUrjd5PA/wxTCEsS29GVGeJPjq2gh+OH7fJCn9nG4R05SOHE/7jgw3sPCpRCDIEaEBaigZ5ybwqqd1DU/lcFmyJmX7h5LsOEIi7UWVMpywOF07fvTo4h9F4c4sLLkootlUZNVUNdM+8f0l/GkVOUeaBqA3DnKMmOzLencbV5M2Iv71hh5bvGgdapBkShgpqWKk1gSlyVYxmvIGPTO9RgnhuLNvIeb0kuUfEwNeQIFYNqFMShFVJUVXLM+f6w5G7ur7XekwAIM17KodOj7bqwFyD4uuem62CASoSfuGL09FGNf4RMAISsbsxz0vchUZYdlATmQn456zjuDSwFwjiAY4LDIifmbwOd5wWxyxitvmTPRcgQGv2mjLKf1AvdPNlvcwaMuLeFT/qKy+QJN5p+Zxo8N5g5M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eae1baf8-abec-480a-3e33-08d6f2f5afd3 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 07:30:34.9179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hemant.agrawal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2623 Subject: Re: [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Neil, The same code of low-level HW driver is shared with different OSs (kernel,= uboot etc) and different framework. If we introduce rte_internal in these = low-level hw files, it will be a big maintenance issue for NXP. Everytime t= here is a change or upgrade, it will be a pain.=20 Regards, Hemant > -----Original Message----- > From: Neil Horman > Sent: Thursday, June 13, 2019 7:54 PM > To: dev@dpdk.org > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > ; Bruce Richardson ; > Thomas Monjalon ; Hemant Agrawal > ; Shreyansh Jain > Subject: [PATCH v2 05/10] fslmc: identify internal only functions and tag= them > as __rte_internal > Importance: High >=20 > Identify functions in fslmc bus driver which are internal (based on > their not having an rte_ prefix) and tag them with __rte_internal >=20