From: Hemant Agrawal <hemant.agrawal@nxp.com> To: Neil Horman <nhorman@tuxdriver.com>, "david.marchand@redhat.com" <david.marchand@redhat.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <akhil.goyal@nxp.com> Subject: Re: [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal Date: Thu, 2 Apr 2020 09:49:20 +0000 Message-ID: <VI1PR0401MB2541C41E45F1895704610D1789C60@VI1PR0401MB2541.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20190619104543.GB19712@hmswarspite.think-freely.org> HI Neil, > On Mon, Jun 17, 2019 at 07:30:34AM +0000, Hemant Agrawal wrote: > > HI Neil, > > The same code of low-level HW driver is shared with different OSs > (kernel, uboot etc) and different framework. If we introduce rte_internal in > these low-level hw files, it will be a big maintenance issue for NXP. Everytime > there is a change or upgrade, it will be a pain. > > > Why? If you don't want to support the use of a project specific tag in other > projects, you can add a global cflag to those like this: > -D__rte_experimental > > and the code will be eliminated > > I'm not sure what you see as difficult here [Hemant] Do, we have an alternate for this approach? Also, w.r.t to changes, at present you are adding the "__rte_internal" after the function return type. Is it possible to add it before the function return type and limiting the changes to header file only i.e. something similar to the current approach of "__rte_experimental" => current approach > * Return: '0' on Success; Error code otherwise. > */ > -int dpbp_open(struct fsl_mc_io *mc_io, > +int __rte_internal dpbp_open(struct fsl_mc_io *mc_io, > uint32_t cmd_flags, > int dpbp_id, > uint16_t *token) => approach used in rte_experimental >__rte_experimental >uint16_t >rte_bbdev_count(void); This will help in minimizing the changes. Regards, Hemant > > Neil > > > Regards, > > Hemant > > > > > -----Original Message----- > > > From: Neil Horman <nhorman@tuxdriver.com> > > > Sent: Thursday, June 13, 2019 7:54 PM > > > To: dev@dpdk.org > > > Cc: Neil Horman <nhorman@tuxdriver.com>; Jerin Jacob Kollanukkaran > > > <jerinj@marvell.com>; Bruce Richardson <bruce.richardson@intel.com>; > > > Thomas Monjalon <thomas@monjalon.net>; Hemant Agrawal > > > <hemant.agrawal@nxp.com>; Shreyansh Jain <shreyansh.jain@nxp.com> > > > Subject: [PATCH v2 05/10] fslmc: identify internal only functions > > > and tag them as __rte_internal > > > Importance: High > > > > > > Identify functions in fslmc bus driver which are internal (based on > > > their not having an rte_ prefix) and tag them with __rte_internal > > > > >
next prev parent reply index Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-25 18:43 [dpdk-dev] [RFC PATCH 0/2] introduce __rte_internal tag Neil Horman 2019-05-25 18:43 ` [dpdk-dev] [RFC PATCH 1/2] Add __rte_internal tag for functions and version target Neil Horman 2019-06-05 16:14 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran 2019-05-25 18:43 ` [dpdk-dev] [RFC PATCH 2/2] Convert dpaa driver to tag internal-only symbols appropriately Neil Horman 2019-06-05 16:24 ` [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag Jerin Jacob Kollanukkaran 2019-06-05 16:45 ` Bruce Richardson 2019-06-05 18:11 ` Neil Horman 2019-06-06 9:44 ` Jerin Jacob Kollanukkaran 2019-06-06 11:34 ` Neil Horman 2019-06-06 12:04 ` Jerin Jacob Kollanukkaran 2019-06-06 13:18 ` Wiles, Keith 2019-06-06 13:43 ` Neil Horman 2019-06-06 13:53 ` Wiles, Keith 2019-06-06 14:46 ` Neil Horman 2019-06-06 13:35 ` Neil Horman 2019-06-06 14:02 ` Jerin Jacob Kollanukkaran 2019-06-06 15:03 ` Neil Horman 2019-06-06 15:14 ` Jerin Jacob Kollanukkaran 2019-06-06 15:26 ` Neil Horman 2019-06-06 16:23 ` Jerin Jacob Kollanukkaran 2019-06-06 16:55 ` Neil Horman 2019-06-07 9:41 ` Jerin Jacob Kollanukkaran 2019-06-07 10:35 ` Neil Horman 2019-06-07 15:42 ` Ray Kinsella 2019-06-07 18:21 ` Wiles, Keith 2020-01-09 15:49 ` Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 0/9] dpdk: " Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 1/9] Add __rte_internal tag for functions and version target Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 2/9] Exempt INTERNAL symbols from checking Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 3/9] mark dpaa driver internal-only symbols with __rte_internal Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 4/9] fslmc: identify internal only functions and tag them as __rte_internal Neil Horman 2019-06-12 20:38 ` [dpdk-dev] [PATCH v1 5/9] dpaa2: Adjust dpaa2 driver to mark internal symbols with __rte_internal Neil Horman 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 6/9] dpaax: mark internal functions " Neil Horman 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 7/9] cpt: " Neil Horman 2019-06-17 5:27 ` [dpdk-dev] [EXT] " Anoob Joseph 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 8/9] octeonx: " Neil Horman 2019-06-12 20:39 ` [dpdk-dev] [PATCH v1 9/9] dpaa2: " Neil Horman 2019-06-12 21:14 ` Aaron Conole 2019-06-13 10:24 ` Neil Horman 2019-06-13 7:53 ` [dpdk-dev] [PATCH v1 0/9] dpdk: introduce __rte_internal tag David Marchand 2019-06-13 10:30 ` Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 0/10] " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 01/10] Add __rte_internal tag for functions and version target Neil Horman 2020-04-17 2:04 ` Wang, Haiyue 2020-04-17 2:38 ` Neil Horman 2020-04-17 4:40 ` Wang, Haiyue 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 02/10] meson: add BUILDING_RTE_SDK Neil Horman 2019-06-13 14:44 ` Bruce Richardson 2019-06-19 10:39 ` Neil Horman 2019-06-19 10:46 ` Bruce Richardson 2019-06-19 18:34 ` Neil Horman 2019-06-20 10:20 ` Bruce Richardson 2019-06-20 10:21 ` Bruce Richardson 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 03/10] Exempt INTERNAL symbols from checking Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 04/10] mark dpaa driver internal-only symbols with __rte_internal Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal Neil Horman 2019-06-17 7:30 ` Hemant Agrawal 2019-06-19 10:45 ` Neil Horman 2020-04-02 9:49 ` Hemant Agrawal [this message] 2020-04-02 11:30 ` Neil Horman 2020-04-02 15:44 ` Hemant Agrawal 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 06/10] dpaa2: Adjust dpaa2 driver to mark internal symbols with __rte_internal Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 07/10] dpaax: mark internal functions " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 08/10] cpt: " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 09/10] octeonx: " Neil Horman 2019-06-13 14:23 ` [dpdk-dev] [PATCH v2 10/10] dpaa2: " Neil Horman 2019-08-06 10:03 ` [dpdk-dev] [PATCH v2 0/10] dpdk: introduce __rte_internal tag Thomas Monjalon 2019-08-06 12:21 ` Neil Horman 2020-01-09 9:55 ` David Marchand 2020-01-09 11:46 ` Neil Horman 2020-01-09 11:53 ` David Marchand 2020-04-22 13:52 ` [dpdk-dev] [PATCH v3 0/1] " Haiyue Wang 2020-04-22 13:52 ` [dpdk-dev] [PATCH v3 1/1] eal: add internal ABI mark support Haiyue Wang 2020-04-22 14:13 ` David Marchand 2020-04-22 16:44 ` Wang, Haiyue 2020-04-22 16:37 ` [dpdk-dev] [PATCH v4 0/1] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-22 16:37 ` [dpdk-dev] [PATCH v4 1/1] eal: add internal ABI mark support Haiyue Wang 2020-04-23 3:19 ` [dpdk-dev] [PATCH v5 0/1] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-23 3:19 ` [dpdk-dev] [PATCH v5 1/1] eal: add internal ABI marking support Haiyue Wang 2020-04-24 14:52 ` David Marchand 2020-04-25 6:10 ` Wang, Haiyue 2020-04-25 14:21 ` David Marchand 2020-04-25 14:24 ` Thomas Monjalon 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 0/6] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 1/6] eal: add internal ABI tag definition Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 2/6] build: enable internal API tag Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 3/6] mk: add internal tag check Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 4/6] devtools: ignore internal ABI check Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 5/6] devtools: exempt internal ABI checking Haiyue Wang 2020-04-25 6:04 ` [dpdk-dev] [PATCH v6 6/6] devtools: enforce internal tag at the beginning Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 0/6] dpdk: introduce __rte_internal tag Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 1/6] eal: add internal ABI tag definition Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 2/6] build: enable internal API tag Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 3/6] mk: add internal tag check Haiyue Wang 2020-04-25 14:34 ` David Marchand 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 4/6] devtools: ignore internal ABI check Haiyue Wang 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 5/6] devtools: exempt internal ABI checking Haiyue Wang 2020-04-25 14:34 ` David Marchand 2020-04-25 10:56 ` [dpdk-dev] [PATCH v7 6/6] devtools: enforce internal tag at the beginning Haiyue Wang 2020-04-25 14:39 ` [dpdk-dev] [PATCH v7 0/6] dpdk: introduce __rte_internal tag David Marchand 2020-04-25 16:34 ` Wang, Haiyue 2020-04-25 18:09 ` Wang, Haiyue 2020-04-29 8:22 ` David Marchand 2020-04-29 8:24 ` Wang, Haiyue
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR0401MB2541C41E45F1895704610D1789C60@VI1PR0401MB2541.eurprd04.prod.outlook.com \ --to=hemant.agrawal@nxp.com \ --cc=akhil.goyal@nxp.com \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=nhorman@tuxdriver.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git