From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5877C76188 for ; Tue, 16 Jul 2019 14:03:54 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 75D5220880 for ; Tue, 16 Jul 2019 14:03:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="4qsk6kKj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75D5220880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BEEC1C01; Tue, 16 Jul 2019 16:03:53 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50057.outbound.protection.outlook.com [40.107.5.57]) by dpdk.org (Postfix) with ESMTP id C917214E8; Tue, 16 Jul 2019 16:03:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZExmuzpkxuOgZLpQ+XdiWir5hh/2LJL9/NKLFQDvz0=; b=4qsk6kKjrcpjmSd0cnunq2mr5uioa/DwwyZGND1vWcn94ZIBp+lT9Xti+uNwTG7PrPEn8EPTkWHVm5cu7HOSqSkC/gxVHDPP2m08nuLbdCl2atl20CBJW4B2u8PfTZLyzjQLe5tpYrSGoG8AFUwglwHPMm+upKEMy/iGaZvtFEU= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB3936.eurprd08.prod.outlook.com (20.178.125.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.20; Tue, 16 Jul 2019 14:03:50 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::5c6f:a70a:a1d7:5d65]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::5c6f:a70a:a1d7:5d65%5]) with mapi id 15.20.2073.012; Tue, 16 Jul 2019 14:03:50 +0000 From: "Gavin Hu (Arm Technology China)" To: Olivier Matz , "thomas@monjalon.net" CC: "dev@dpdk.org" , nd , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Nipun.gupta@nxp.com" , Honnappa Nagarahalli , "i.maximets@samsung.com" , "stable@dpdk.org" , "Gavin Hu (Arm Technology China)" Thread-Topic: [PATCH v9 1/2] ring: add reset API to flush the ring when not in use Thread-Index: AQHVOMooKl6tIysb80Oj9J9zlTBwkKbM+H6AgAAqEwCAACenoA== Date: Tue, 16 Jul 2019 14:03:50 +0000 Message-ID: References: <20181212062404.30243-1-gavin.hu@arm.com> <1562946877-50963-2-git-send-email-gavin.hu@arm.com> <20190716090121.6c4aa6u6vp3mhb2q@platinum> <20190716113156.nhnirohjmzdbb4wl@platinum> In-Reply-To: <20190716113156.nhnirohjmzdbb4wl@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a042b2e7-a66e-454e-82e6-d9f2f35d79f4.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7c2aad1-0209-47b7-b805-08d709f66db2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB3936; x-ms-traffictypediagnostic: VI1PR08MB3936: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:1443; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(346002)(39860400002)(396003)(136003)(13464003)(189003)(199004)(7696005)(305945005)(55016002)(99286004)(7736002)(9686003)(229853002)(2906002)(486006)(11346002)(446003)(71190400001)(71200400001)(33656002)(6436002)(74316002)(68736007)(476003)(2501003)(3846002)(76176011)(478600001)(5660300002)(26005)(66066001)(52536014)(6246003)(76116006)(25786009)(66946007)(14454004)(66556008)(64756008)(66446008)(66476007)(54906003)(110136005)(102836004)(53936002)(186003)(316002)(86362001)(81166006)(256004)(6116002)(8676002)(8936002)(53546011)(6506007)(81156014)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3936; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ztp0/6DRg5fTz+ROVh9rkyka4poqNdBkJn8T5Qb9/Y04ogLgG0TPPQtkIbxZS7Z+ixFMHoL2oJ/QgbysVSYT0N2sLTWRZvpX0j/KoyV9GzmiILlhBALK/D2h2zn9rBw1aOvZXfrtLT+NZnwnuKyIUJntMe/nIZSIvnLrJLS/V/t3PRGMShz/6c2hF0NBIf4w0mXj+guQdgbf2okW0Bo8D4csGe5HjdS7fwT3/hZDjf1S+2sPQQFqMu+9wczk+CKVq/IrqzUbv81rxu2YQYpH2u5cwfS+hoj5HpwEYYogVT+/Hzj+U5yiFCNC7AqeW+o4g1EJd16FgMy9igWeXhcdbPJpMdv+m771ZMSnQWOZNMF/bZDZif60wzYTJQMHK/xEthjLaMSeYKzbnA5n8CYQ+qTKUs/cIpt/3ziFEOz9E8U= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7c2aad1-0209-47b7-b805-08d709f66db2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 14:03:50.1119 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gavin.Hu@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3936 Subject: Re: [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, Thomas, > -----Original Message----- > From: Olivier Matz > Sent: Tuesday, July 16, 2019 6:32 AM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; nd ; thomas@monjalon.net; > jerinj@marvell.com; hemant.agrawal@nxp.com; Nipun.gupta@nxp.com; > Honnappa Nagarahalli ; > i.maximets@samsung.com; stable@dpdk.org > Subject: Re: [PATCH v9 1/2] ring: add reset API to flush the ring when no= t in > use >=20 > On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote: > > On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote: > > > Currently, the flush is done by dequeuing the ring in a while loop. I= t is > > > much simpler to flush the queue by resetting the head and tail indice= s. > > > > > > Fixes: af75078fece3 ("first public release") > > > Cc: stable@dpdk.org >=20 > Actually it's not a fix, it adds a new API. >=20 > Is the patch in hash library intended to be backported? If yes, as it > seems to be a performance optimization, you'll need to describe what > scenario you're fixing and what is the performance gain. If no, the Cc > stable can be removed. As this is not in the data plan, I don't intend to backport.=20 Do I need to submit a new version to remove the CC: lines?=20 > > > > > > Signed-off-by: Gavin Hu > > > Reviewed-by: Ruifeng Wang > > > Reviewed-by: Honnappa Nagarahalli > > > > Acked-by: Olivier Matz