From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D59C4332F for ; Mon, 13 Nov 2023 17:13:23 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA9FD402BC; Mon, 13 Nov 2023 18:13:22 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 90868402AE for ; Mon, 13 Nov 2023 18:13:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699895600; x=1731431600; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=pSexHyORNaB8mLX0yLtmLkDfdgAh7TdEUn+APRD37mA=; b=XFzHLNoZHFUuXYqPf1nHuKXL1eQ7XAEZXnY9U8gi5YBSqxi8gIcHRe8e jvcTMKcBClcivnl1uRtYsuFd1mFnfuhneLopq+VMik7jszrksQ2FauUVT 9aINsJ2GxRESkZsa5rd5qQu5pZJdKDUpFC+a1c213Oihj6N3Q1OIfoPiy Hd3Mqzm0vILU1GmWngjcKAwSfHTDYStptLmG4NlqN2J10rX/zdF9H3H9G t4uzO/ODlHiBJVpHholAGkDYiIekjufl1Rxo3a/EKnbt0RZR4U797v9xW shOrPryGtMc8QYzILwckCD6syabrTyW3YaUr0F892aKV4MhZ8rddRRpzP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="387639450" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="387639450" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 09:10:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="855016387" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="855016387" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Nov 2023 09:10:49 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 13 Nov 2023 09:10:49 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 13 Nov 2023 09:10:49 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 13 Nov 2023 09:10:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZKGGjROOVOhFPzRfPp1opRDRg/F35N05dkVs8i2qldX17zelNN+sU+XfimoFJYDlQIPXGohFt1rG3UeM6arqqgosTPl9kjF7rxBfia/NQ0NWBtuvSjuZbhgd6ZSZInxtwujCNbFrpoB5jIjoChn1IDkh+5nvlHRt5e/UKO3nMLUoIzPpJstuTLHiP0/WuvPyV8EbmUH79wZRK4+f0SshS/cvU9AmYOhbqdSf01iTpYrMPv7r4tis1k7Q6xTzv5xVTI01OVDMbl+FXv5+dRJTboY1wDi2/8QBW1jgyOYC4PM4TuLXPAuLfMm1dUKP/vBB0L/LsQza1gBTs/BBNStSYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ISIbA/ySRJvA8SPUgVT91KN6FIVryuIdBKShggWAqPY=; b=c0Z5Q/6Kx4N8BMLrGTkaRYmbPfxmKR0lQjMg/JU1vc+qQ0ZFSwnmlg1a6JTOL47kY+wYJF9bXW+XdZdrM5OQq5yUXYQzJ7288JHt3ca4K2UbsJFkdht71jCp3O9WJg+64BUaTLIvunlhNtQStRT2wqOCqMYzAuuqDOl8RmNO/2fOQJD1yYAgnBGbsJL8yvlUVGq62wb3X9ni7HIfVh7F+vSqF1youCHwl0yRJEWGWanA/DLxnsy4bbYCS8L9pqlznNLIGD2VQM51eqTOEPOQ3hVmXV3N6ENbDcmTQ+Wwb+C71DvXNgwoxU+n0zy+k+0Tvrj04EdWVoQ5uG3SFXSJ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5311.namprd11.prod.outlook.com (2603:10b6:5:392::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 17:10:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::8645:d921:ce8a:12ba]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::8645:d921:ce8a:12ba%5]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 17:10:47 +0000 Date: Mon, 13 Nov 2023 17:10:40 +0000 From: Bruce Richardson To: Stephen Hemminger CC: , Liang Ma , Peter Mccarthy Subject: Re: [PATCH v2 1/3] event/opdl: fix non-constant compile time assertion Message-ID: References: <20231111172153.57461-1-stephen@networkplumber.org> <20231113170605.408281-1-stephen@networkplumber.org> <20231113170605.408281-2-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231113170605.408281-2-stephen@networkplumber.org> X-ClientProxiedBy: DU2PR04CA0269.eurprd04.prod.outlook.com (2603:10a6:10:28e::34) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5311:EE_ X-MS-Office365-Filtering-Correlation-Id: 35883ffd-5d8a-4aac-083c-08dbe46b7a9f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jVrgnw6XC8OEeWA3WFNzMXW0EYQ/VijXgNSEgyuLIVGlnpD4drQnRrmiiGPYHiFVNsRHjp8bB/gVfv86/KdG4m4UA6YLLpn+I1T8yIKJQeTB30Hz5WO+sfETc4Lg3JXv+Jh5uqFXfIs/gX6QBCLFp8n/sSBNiGTwKS6yTonwyhXALdREIf8QS8YeTjcWQBNv1hj8eqmIQwZ76J+4+YNX5wOcQcDv6vi6266oWSh79/jX0uIVVMaC+8J4aqPqIeTQybEp2p/ArccGVYEggLmMHF2vpSUsQ1ewIPjHQUcNLZB5oAMWdJSYBZst3N3j2vcN4Tid05ZUnCyYazeZk2KS9A8mSuXEJ/mYpqRsaZ5dR0MJ1ebl0e/sO/3w+0tNKpNHu9fPQhe2qHzkfskzKkVWhc9qDV9OC9dAmhQQ6NtXogJDcz5+vkpjBInmavktntCqQItjA7i8MKiFBpzgrpHty2gxJi6iw1UmA7LTIcpC+KoYKpMU+jon0lKACHYnryzCpqvxQIb9fyXP99A/izTVvqQ2elRkiD/2MNs4P1P42KbQHfj91kDtcimskNzsr23p X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(366004)(39860400002)(136003)(376002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(316002)(54906003)(66476007)(6916009)(6512007)(66946007)(66556008)(83380400001)(38100700002)(82960400001)(8676002)(8936002)(4326008)(6486002)(478600001)(6506007)(6666004)(44832011)(5660300002)(86362001)(107886003)(4744005)(2906002)(26005)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NhFppCr48LLKFFKZluwe0leu35QCQELb1Eok0OF8Ey1ygs31wchFuSpsJ8Nr?= =?us-ascii?Q?5B5UETKk9FFc/f1sK+ZTfWf1hatGUkvjn9Oku7JLT32uglkDOWP0BX5pGARb?= =?us-ascii?Q?yuKcLnDlcGvIvs9W3BKsRvy9Ao+CyCcyInwMaaoZJUvibfQ/CFUH2AlRNWWr?= =?us-ascii?Q?t2NXnxkrX9PRYRyu9kujJq8H3WW/JhYrNDOooiOkHQ4Bc12Qrm5SiLqmh9Ie?= =?us-ascii?Q?Njocd6l4JV7NwM3FyzCHv9szmdA1/6IuwLx43hDYfocHoXYbl6YeEzibbvuN?= =?us-ascii?Q?9buUE6LxNZFhCPW2SWqI+uEg/6uuIIRbIrTfOb+qQwIzHxqor1BaSqIdwfyl?= =?us-ascii?Q?v1QNAsd4lIkRsGrtX3CDa38SBRdOFcv++uOPRPUxxmuDyrdgHDZQL9osa+lk?= =?us-ascii?Q?gl/ASmC8tocUF8SxxArOoVf1kj36JmgHa4SjqG1wOZD/UiFvJChjVNnemLeP?= =?us-ascii?Q?0OVUevLaPI3l1aIbnezYeMXSYlVfWAqbe2gueg5SrJQJRdRIob5Fx6Put0KO?= =?us-ascii?Q?W3OJCsS4+25LXsOCrYnHJ4iWpQstnDulxWigbI77Jb1Nyp33mVR8LFPPaa/4?= =?us-ascii?Q?i2CjsLvp0nBLSkXNKb7gKiPThDW1GXsg6H6uwnsIBbtWgIdHCzqGiHij8tyw?= =?us-ascii?Q?4WGci2SsvqYT4BR7FxbiUU9CX7NFa5+lLXCNGF8/DyG7Em8axP+3N498pb/a?= =?us-ascii?Q?C4exQLNFnuqJEqEjQU9QAKSc97hwCtixtLF5QruFp47gc8VCVFrCiwX2jps1?= =?us-ascii?Q?euPimWauT2WsdZ7lMjQthSVPHG0ZJKfNMylHjQAvYLnlHg9JQ4Syh2o3m5yu?= =?us-ascii?Q?0EzQKUyFcUWe0LHdm2udWgjb+OadmKY2E4NMUwhgIxqDTl6T/4Ple3TOhlnt?= =?us-ascii?Q?ZhF6BnwnqUaLCazRDUL3KKMrlaecOzP+vihYWEH6Zsvfo5SiTnik4dx2Qhlj?= =?us-ascii?Q?4eq36PKw8tVu3MoaLEN0y7ekf+MXRtkCBh9RXG8eLTbvyIF7bRxCaRsxNoJh?= =?us-ascii?Q?hwyuC7oAHGUy7yjCDnGiM+v6BdiIYtOSDknlvX05u+Jd3apKH3k+dfefdYyT?= =?us-ascii?Q?5yiiBs5Hcg1oEzWbqQndnxU4vWyzN88jyAvf8MjJ/gxsfP51JCg5crn7AYw7?= =?us-ascii?Q?3iWGFIxAtqcjHacw9Qv/PQE/ZOT1htSCp4osJ8/MbSU4U8j/qMz4B2aJTCoU?= =?us-ascii?Q?AwxI7VsTCdArRJAoaSW6bQ+NaMn7/h8xCbZVHmlseeXsjX+PV7yFP0GLBtoZ?= =?us-ascii?Q?x7raQBTDnv30wzeUsgVBFOjZGqGk+KmIjxq2P43b6AeA7dtOwUrsJJKrkc4t?= =?us-ascii?Q?ZyAtTUAXTSegLLck3h1H1gyh5ZJBm10XXH9+J+DeKUs1Gzl91NmZfuaUTKGa?= =?us-ascii?Q?iomJ0kQElu/W84TaK/ulsG08fcsMfblq0hH/JpRpzNKOLrooZ599eCHtWeF4?= =?us-ascii?Q?plgAI8tKiFaLTyFYmJXt+xOy2HcQzVj1NNa+dhWYTQTL/nlUkPodRNLRGz9g?= =?us-ascii?Q?M9kgLY2uK1caPnwd3pmn1GUxNdyOd7VtxAaMKkS4B58eEzs9l6uiP3k4xMpz?= =?us-ascii?Q?AsTM1SFgiapiKymqMJf5PQS1y0NSoVjnj3hKytDq0eFL2fBdhS43u36aIKRw?= =?us-ascii?Q?UA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 35883ffd-5d8a-4aac-083c-08dbe46b7a9f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2023 17:10:47.4711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dzEgFJMHIprzWF9KqGLHLAhHzBapO8XNe/tV7YWGOSchPinZcfEpomxHfJevprYMbxSuGCzYdpdgzV2AEkJxNRoy4CaizGnqJQiePfWlqVo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5311 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 13, 2023 at 09:06:03AM -0800, Stephen Hemminger wrote: > RTE_BUILD_BUG_ON() was being used with a non-constant value. > The inline function rte_is_power_of_2() is not constant since > inline expansion happens later in the compile process. > Replace it with macro which will be constant. > > Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") > Cc: liang.j.ma@intel.com > Signed-off-by: Stephen Hemminger > --- > drivers/event/opdl/opdl_ring.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Acked-by: Bruce Richardson