From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v10 04/27] kvargs: introduce a more flexible parsing function Date: Wed, 11 Jul 2018 17:25:25 +0530 Message-ID: References: <6816f4a37e4f3869422377392689ec9ff3f25e7b.1530791217.git.gaetan.rivet@6wind.com> <1866386.cgS3gS0Edk@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, olivier.matz@6wind.com To: Thomas Monjalon , Gaetan Rivet Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50066.outbound.protection.outlook.com [40.107.5.66]) by dpdk.org (Postfix) with ESMTP id D2A591B060 for ; Wed, 11 Jul 2018 13:55:51 +0200 (CEST) In-Reply-To: <1866386.cgS3gS0Edk@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Friday 06 July 2018 03:30 AM, Thomas Monjalon wrote: > 05/07/2018 13:48, Gaetan Rivet: >> This function permits defining additional terminating characters, >> ending the parsing to arbitrary delimiters. > [...] >> +__rte_experimental >> +struct rte_kvargs *rte_kvargs_parse2(const char *args, >> + const char *const valid_keys[], >> + const char *valid_ends); > > The name is not ideal but I don't have a better idea. > Does 'rte_kvargs_parse_delim()' seem any better? Or, a more obvious one 'rte_kvargs_parse_with_delim()'. [...] As I am already late in commenting on this, I am OK changing this later as well (using the 'experimental' blanket) when a better suggestion comes along. So, from me as well: Acked-by: Shreyansh Jain