dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: dwilder <dwilder@us.ibm.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	pradeep@us.ibm.com, drc@ibm.com
Subject: Re: [dpdk-dev] [PATCH] meson: Update flags and values for ppc_64
Date: Tue, 04 Jun 2019 13:25:52 -0700	[thread overview]
Message-ID: <a81f3693548e25605b2a0f093fb4e40d@linux.vnet.ibm.com> (raw)
In-Reply-To: <1864604.tGcSgmW0Rt@xps>

On 2019-06-03 15:30, Thomas Monjalon wrote:
> 27/05/2019 11:41, Bruce Richardson:
>> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
>> > Setting RTE_MAX_LCORE to reflect the largest available configuration.
>> > Adding defines for missing RTE_MACHINE_CPUFLAGs.
>> >
>> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
>> > ---
>> > --- a/config/ppc_64/meson.build
>> > +++ b/config/ppc_64/meson.build
>> >  # overrides specific to ppc64
>> > -dpdk_conf.set('RTE_MAX_LCORE', 256)
>> > +dpdk_conf.set('RTE_MAX_LCORE', 1536)
>> >  dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
>> >  dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
>> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
>> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
>> 
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> 
> Suggested title:
> 	config: update for ppc build with meson
> 
> Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well
> for RTE_MAX_LCORE?

Hi Thomas
I am taking the opportunity to update RTE_MAX_LCORE for future releases 
of dpdk.  As we are switching to meson builds soon so this is an 
appropriate opportunity to update the value and keep in step with the 
hardware. Older stable release can continue to use the smaller value 
found in deconfig..


  reply	other threads:[~2019-06-04 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 16:04 [dpdk-dev] [PATCH] meson: Update flags and values for ppc_64 David Wilder
2019-05-27  9:41 ` Bruce Richardson
2019-06-03 22:30   ` Thomas Monjalon
2019-06-04 20:25     ` dwilder [this message]
2019-06-04 21:04       ` Thomas Monjalon
2019-06-04 21:13         ` dwilder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a81f3693548e25605b2a0f093fb4e40d@linux.vnet.ibm.com \
    --to=dwilder@us.ibm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=drc@ibm.com \
    --cc=pradeep@us.ibm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).