From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v3] eal: add function to return number of detected sockets Date: Tue, 6 Feb 2018 09:28:51 +0000 Message-ID: References: <3cf7f9aa904a5ba53ba63d7c32539e8b78638939.1513946317.git.anatoly.burakov@intel.com> <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> <4220934.KFJTx7yznj@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 602FA1B692 for ; Tue, 6 Feb 2018 10:28:53 +0100 (CET) In-Reply-To: <4220934.KFJTx7yznj@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05-Feb-18 10:45 PM, Thomas Monjalon wrote: > 05/02/2018 18:39, Burakov, Anatoly: >> On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: >>> During lcore scan, find maximum socket ID and store it. >>> >>> Signed-off-by: Anatoly Burakov >>> --- >>> >>> Notes: >>> v3: >>> - Added ABI backwards compatibility >>> >>> v2: >>> - checkpatch changes >>> - check socket before deciding if the core is not to be used >>> >>> lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- >>> lib/librte_eal/common/include/rte_eal.h | 25 +++++++++++++++++++++ >>> lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ >>> lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++++++- >>> lib/librte_eal/rte_eal_version.map | 9 +++++++- >>> 5 files changed, 92 insertions(+), 14 deletions(-) >>> >> >> This patch does not break ABI, but does it in a very ugly way. Is it >> worth it? > > I think we agreed to not get this patch in 18.02. > Did you change your mind? > Sorry, how do i mark this patch as for 18.05? Is it a patch header? -- Thanks, Anatoly