DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
@ 2019-07-15 10:54 Sean Morrissey
  2019-07-15 11:00 ` Morrissey, Sean
  2019-07-19 10:04 ` Laatz, Kevin
  0 siblings, 2 replies; 4+ messages in thread
From: Sean Morrissey @ 2019-07-15 10:54 UTC (permalink / raw)
  To: dev
  Cc: kevin.laatz, harry.vanhaaren, john.oloughlin, marko.kovacevic,
	Sean Morrissey, ciara.power, stable

Added telemetry to EAL long options so that when
--telemetry is passed as an EAL arg that there is
no unrecognized argument error message printed.

Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.power@intel.com
Cc: stable@dpdk.org

Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
 lib/librte_eal/common/eal_common_options.c | 3 +++
 lib/librte_eal/common/eal_options.h        | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..24e36cf23 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -81,6 +81,9 @@ eal_long_options[] = {
 	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
 	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
 	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
+#endif
 	{0,                     0, NULL, 0                        }
 };
 
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index 9855429e5..e4c8e25c2 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -69,6 +69,10 @@ enum {
 	OPT_IOVA_MODE_NUM,
 #define OPT_MATCH_ALLOCATIONS  "match-allocations"
 	OPT_MATCH_ALLOCATIONS_NUM,
+#ifdef RTE_LIBRTE_TELEMETRY
+	#define OPT_TELEMETRY          "telemetry"
+		OPT_TELEMETRY_NUM,
+#endif
 	OPT_LONG_MAX_NUM
 };
 
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
  2019-07-15 10:54 [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Sean Morrissey
@ 2019-07-15 11:00 ` Morrissey, Sean
  2019-07-19 10:04 ` Laatz, Kevin
  1 sibling, 0 replies; 4+ messages in thread
From: Morrissey, Sean @ 2019-07-15 11:00 UTC (permalink / raw)
  To: dev
  Cc: Laatz, Kevin, OLoughlin, John, Kovacevic, Marko, ciara.power,
	Van Haaren, Harry

+Harry Van Haaren
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
  2019-07-15 10:54 [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Sean Morrissey
  2019-07-15 11:00 ` Morrissey, Sean
@ 2019-07-19 10:04 ` Laatz, Kevin
  2019-07-22 16:40   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Laatz, Kevin @ 2019-07-19 10:04 UTC (permalink / raw)
  To: Sean Morrissey, dev
  Cc: harry.vanhaaren, john.oloughlin, marko.kovacevic, ciara.power, stable

On 15/07/2019 11:54, Sean Morrissey wrote:
> Added telemetry to EAL long options so that when
> --telemetry is passed as an EAL arg that there is
> no unrecognized argument error message printed.
>
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Cc: ciara.power@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
>   lib/librte_eal/common/eal_common_options.c | 3 +++
>   lib/librte_eal/common/eal_options.h        | 4 ++++
>   2 files changed, 7 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 512d5088e..24e36cf23 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -81,6 +81,9 @@ eal_long_options[] = {
>   	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
>   	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
>   	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
> +#ifdef RTE_LIBRTE_TELEMETRY
> +	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
> +#endif
>   	{0,                     0, NULL, 0                        }
>   };
>   
> diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
> index 9855429e5..e4c8e25c2 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -69,6 +69,10 @@ enum {
>   	OPT_IOVA_MODE_NUM,
>   #define OPT_MATCH_ALLOCATIONS  "match-allocations"
>   	OPT_MATCH_ALLOCATIONS_NUM,
> +#ifdef RTE_LIBRTE_TELEMETRY
> +	#define OPT_TELEMETRY          "telemetry"
> +		OPT_TELEMETRY_NUM,
> +#endif
>   	OPT_LONG_MAX_NUM
>   };
>   
LGTM, thanks!

Acked-by: Kevin Laatz <kevin.laatz@intel.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg
  2019-07-19 10:04 ` Laatz, Kevin
@ 2019-07-22 16:40   ` " Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-07-22 16:40 UTC (permalink / raw)
  To: Sean Morrissey
  Cc: stable, Laatz, Kevin, dev, harry.vanhaaren, john.oloughlin,
	marko.kovacevic, ciara.power

19/07/2019 12:04, Laatz, Kevin:
> On 15/07/2019 11:54, Sean Morrissey wrote:
> > Added telemetry to EAL long options so that when
> > --telemetry is passed as an EAL arg that there is
> > no unrecognized argument error message printed.
> >
> > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> > Cc: ciara.power@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> 
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 10:54 [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Sean Morrissey
2019-07-15 11:00 ` Morrissey, Sean
2019-07-19 10:04 ` Laatz, Kevin
2019-07-22 16:40   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox