DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>, <dev@dpdk.org>
Cc: <michel@digirati.com.br>, <olivier.matz@6wind.com>,
	<anatoly.burakov@intel.com>, <vipin.varghese@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] mbuf: move mbuf definition into a separate file
Date: Fri, 27 Sep 2019 17:42:29 +0300
Message-ID: <bdb06b54-b77d-063c-cc2c-8e093585548d@solarflare.com> (raw)
In-Reply-To: <20190927135054.20845-3-konstantin.ananyev@intel.com>

On 9/27/19 4:50 PM, Konstantin Ananyev wrote:
> Right now inclusion of rte_mbuf.h header can cause inclusion of
> some arch/os specific headers.
> That prevents it to be included directly by some
> non-DPDK (but related) entities: KNI, BPF programs, etc.
> To overcome that problem usually a separate definitions of rte_mbuf
> structure is created within these entities.
> That aproach has a lot of drawbacks: code duplication, error prone, etc.
> This patch moves rte_mbuf structure definition (and some related macros)
> into a separate file that can be included by both rte_mbuf.h and
> other non-DPDK entities.
>
> Note that it doesn't introduce any change for current DPDK code.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 12:53 [dpdk-dev] [PATCH 0/3] " Konstantin Ananyev
2019-08-16 12:53 ` [dpdk-dev] [PATCH 1/3] eal: move CACHE and IOVA related definitions Konstantin Ananyev
2019-08-16 18:50   ` Michel Machado
2019-08-16 12:53 ` [dpdk-dev] [PATCH 2/3] mbuf: move mbuf definition into a separate file Konstantin Ananyev
2019-08-16 18:51   ` Michel Machado
2019-08-16 12:53 ` [dpdk-dev] [PATCH 3/3] examples/bpf: remove duplicate mbuf definition Konstantin Ananyev
2019-08-16 18:44   ` Michel Machado
2019-09-27 13:50 ` [dpdk-dev] [PATCH v2 0/3] move mbuf definition into a separate file Konstantin Ananyev
2019-09-27 13:50   ` [dpdk-dev] [PATCH v2 1/3] eal: move CACHE and IOVA related definitions Konstantin Ananyev
2019-09-30 19:34     ` Michel Machado
2019-09-27 13:50   ` [dpdk-dev] [PATCH v2 2/3] mbuf: move mbuf definition into a separate file Konstantin Ananyev
2019-09-27 14:42     ` Andrew Rybchenko [this message]
2019-09-30 19:34     ` Michel Machado
2019-10-16  8:18     ` Olivier Matz
2019-09-27 13:50   ` [dpdk-dev] [PATCH v2 3/3] examples/bpf: remove duplicate mbuf definition Konstantin Ananyev
2019-09-30 19:35     ` Michel Machado
2019-10-25 20:33   ` [dpdk-dev] [PATCH v2 0/3] move mbuf definition into a separate file Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdb06b54-b77d-063c-cc2c-8e093585548d@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=michel@digirati.com.br \
    --cc=olivier.matz@6wind.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git