From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0A6C43603 for ; Wed, 18 Dec 2019 13:43:48 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 162B821582 for ; Wed, 18 Dec 2019 13:43:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 162B821582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA5341C01; Wed, 18 Dec 2019 14:43:46 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7DC0AF90 for ; Wed, 18 Dec 2019 14:43:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 05:43:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,329,1571727600"; d="scan'208";a="212705811" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.89]) ([10.237.221.89]) by fmsmga007.fm.intel.com with ESMTP; 18 Dec 2019 05:43:41 -0800 To: David Marchand , Ruifeng Wang , Bruce Richardson Cc: Aaron Conole , Michael Santana , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , dev , Gavin Hu , Honnappa Nagarahalli , nd References: <20191218053902.193417-1-ruifeng.wang@arm.com> <20191218053902.193417-3-ruifeng.wang@arm.com> From: "Laatz, Kevin" Message-ID: Date: Wed, 18 Dec 2019 13:43:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/2] devtools: add path to additional shared object files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18/12/2019 08:23, David Marchand wrote: > On Wed, Dec 18, 2019 at 6:39 AM Ruifeng Wang wrote: >> librte_mempool_ring.so and librte_pmd_null.so are in 'drivers' folder. >> Add 'drivers' into LD_LIBRARY_PATH so that testpmd can find and make >> use of these shared libraries. >> >> Signed-off-by: Ruifeng Wang >> Reviewed-by: Gavin Hu >> --- >> devtools/test-null.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/devtools/test-null.sh b/devtools/test-null.sh >> index f39af2c06..548de8113 100755 >> --- a/devtools/test-null.sh >> +++ b/devtools/test-null.sh >> @@ -20,7 +20,7 @@ if [ ! -f "$testpmd" ] ; then >> fi >> >> if ldd $testpmd | grep -q librte_ ; then >> - export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH >> + export LD_LIBRARY_PATH=$build/drivers:$build/lib:$LD_LIBRARY_PATH >> libs='-d librte_mempool_ring.so -d librte_pmd_null.so' >> else >> libs= >> -- >> 2.17.1 >> > I'm surprised to see this. > So far, the CI ran fine without it, so something is different in the > environment. > > I can see that the RPATH entry disappeared from the testpmd binary. > Xenial: > # readelf -d build/app/dpdk-testpmd |grep RPATH > 0x000000000000000f (RPATH) Library rpath: > [$ORIGIN/../lib:$ORIGIN/../drivers:XXXXXXXXXXXXX] > > (not sure what XXXX purpose is, but different topic) > > Bionic: > # readelf -d build/app/dpdk-testpmd |grep RPATH It looks like RPATH just changed to be named RUNPATH in Bionic: # readelf -d build/app/dpdk-testpmd | grep R.*PATH  0x000000000000001d (RUNPATH)            Library runpath: [$ORIGIN/../lib:$ORIGIN/../drivers:XXXXXXXXXXXXX] > Adding Bruce and Kevin, as I think this is the same issue than: > http://mails.dpdk.org/archives/dev/2019-December/153627.html > Could it be a change in meson? Yes, looks like the same error to me. I'm not sure this is solely a meson issue, I often need to pass -d librte_mempool_ring.so when using make builds too. Maybe I'm missing something here? --- Kevin