From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5413FC31E51 for ; Tue, 18 Jun 2019 09:20:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E45DE206BA for ; Tue, 18 Jun 2019 09:20:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E45DE206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C65011BCA3; Tue, 18 Jun 2019 11:20:33 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3B5C01B9B0 for ; Tue, 18 Jun 2019 11:20:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2019 02:20:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,388,1557212400"; d="scan'208";a="242933132" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.100]) ([10.237.220.100]) by orsmga001.jf.intel.com with ESMTP; 18 Jun 2019 02:20:29 -0700 To: Jakub Grajciar , dev@dpdk.org References: <20190613064248.4930-1-jgrajcia@cisco.com> <20190618084851.5322-1-jgrajcia@cisco.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 18 Jun 2019 10:20:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190618084851.5322-1-jgrajcia@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/memif: multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18-Jun-19 9:48 AM, Jakub Grajciar wrote: > Multi-process support for memif PMD. > Primary process handles connection establishment. > Secondary process queries for memory regions. > > Signed-off-by: Jakub Grajciar > --- <...> > +/* > + * Request regions > + * Called by secondary process, when ports link status goes up. > + */ > +static int > +memif_mp_request_regions(struct rte_eth_dev *dev) > +{ > + int ret, i; > + struct timespec timeout = {.tv_sec = 5, .tv_nsec = 0}; > + struct rte_mp_msg msg, *reply; > + struct rte_mp_reply replies; > + struct mp_region_msg *msg_param = (struct mp_region_msg *)msg.param; > + struct mp_region_msg *reply_param; > + struct memif_region *r; > + struct pmd_process_private *proc_private = dev->process_private; > + > + MIF_LOG(DEBUG, "Requesting memory regions"); > + > + for (i = 0; i < ETH_MEMIF_MAX_REGION_NUM; i++) { > + /* Prepare the message */ > + memset(&msg, 0, sizeof(msg)); > + strlcpy(msg.name, MEMIF_MP_SEND_REGION, sizeof(msg.name)); > + strlcpy(msg_param->port_name, dev->data->name, > + sizeof(msg_param->port_name)); > + msg_param->idx = i; > + msg.len_param = sizeof(*msg_param); > + > + /* Send message */ > + ret = rte_mp_request_sync(&msg, &replies, &timeout); > + if (ret < 0 || replies.nb_received != 1) { > + MIF_LOG(ERR, "Failed to send mp msg: %d", > + rte_errno); > + return -1; > + } > + > + reply = &replies.msgs[0]; > + reply_param = (struct mp_region_msg *)reply->param; > + > + if (reply_param->size > 0) { > + r = rte_zmalloc("region", sizeof(struct memif_region), 0); > + if (r == NULL) { > + MIF_LOG(ERR, "Failed to alloc memif region."); > + free(reply); > + return -ENOMEM; > + } > + r->region_size = reply_param->size; > + if (reply->num_fds < 1) { > + MIF_LOG(ERR, "Missing file descriptor."); > + free(reply); > + return -1; > + } > + r->fd = reply->fds[0]; > + r->addr = NULL; > + > + proc_private->regions[reply_param->idx] = r; > + proc_private->regions_num++; > + } > + } > + > + free(reply); Indentation here is wrong, but more importantly, you're sending requests in a loop, but you're only freeing the last reply. This should be inside the loop, not outside it. -- Thanks, Anatoly