From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A773C76188 for ; Mon, 22 Jul 2019 12:48:43 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id DC5A1218F0 for ; Mon, 22 Jul 2019 12:48:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC5A1218F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D1181BF68; Mon, 22 Jul 2019 14:48:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EE5CB1BF25 for ; Mon, 22 Jul 2019 14:48:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 05:48:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,295,1559545200"; d="scan'208";a="192709559" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga004.fm.intel.com with ESMTP; 22 Jul 2019 05:48:36 -0700 To: Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko Cc: dev@dpdk.org, Dekel Peled References: <1563786795-14027-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE 0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T YR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q CgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M 1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I z+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr GE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte HQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG gMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7 X07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K /s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1 pBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q MJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp g0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8 YO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7 sgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY xWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84 Qz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa ARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a N3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv 0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv VQ== Message-ID: Date: Mon, 22 Jul 2019 13:48:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1563786795-14027-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 00/28] net/mlx5: support LRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/22/2019 10:12 AM, Matan Azrad wrote: > Introduction: > LRO (Large Receive Offload) is intended to reduce host CPU overhead when processing Rx TCP packets. > LRO works by aggregating multiple incoming packets from a single stream into a larger buffer, before they are passed higher up the networking stack. Thus reducing the number of packets that have to be processed. > > Use: > MLX5 PMD will query the HCA capabilities on initialization to check if LRO is supported and can be used. > LRO in MLX5 PMD is intended for use by applications using a relatively small number of flows. > LRO support can be enabled only per port. > In each LRO session, packets of the same flow will be coalesced until one of the following occur: > * Buffer size limit is exceeded. > * Session timeout is exceeded. > * Packet from a different flow is received on the same queue. > > When LRO session ends the coalesced packet is passed to the PMD, which will update the header fields before passing the packet to the application. > For efficient memory utilization, the MPRQ mechanism is used. > Support of Non-LRO flows will not be impacted. > > Existing API: > Offload capability DEV_RX_OFFLOAD_TCP_LRO will be used to indicate device supports LRO. > testpmd command-line option "-enable-lro" will be used to request LRO feature enable on application start. > testpmd rx_offload "tcp_lro" on or off will be used to request LRO feature enable or disable during application runtime. > Offload flag PKT_RX_LRO will be used. This flag can be set in Rx mbuf to indicate this is a LRO coalesced packet. > > New API: > PMD configuration parameter lro_timeout_usec will be added. > This parameter can be used by application to select LRO session timeout (in microseconds). > If this value is not specified, the minimal value supported by device will be used. > > Known limitations: > mbuf head-room is zero for any packet if LRO is configured in the port. > Keep CRC offload cannot be supported with LRO. > CQE compression is not supported with LRO. > > Dekel Peled (23): > net/mlx5: remove redundant item from union > net/mlx5: add LRO APIs and initial settings > net/mlx5: support LRO caps query using devx API > net/mlx5: glue func for queue query using new API > net/mlx5: glue function for action using new API > net/mlx5: check conditions to enable LRO > net/mlx5: support Tx interface query using new API > net/mlx5: update Tx queue create for LRO > net/mlx5: create advanced RxQ object using new API > net/mlx5: modify advanced RxQ object using new API > net/mlx5: create advanced Rx object using new API > net/mlx5: create advanced RxQ table using new API > net/mlx5: allocate door-bells using new API > net/mlx5: rename RxQ verbs to general RxQ object > net/mlx5: rename verbs indirection table to obj > net/mlx5: rename hash RxQ verbs to general > net/mlx5: update queue state modify function > net/mlx5: store protection domain number on create > net/mlx5: func to create Rx verbs completion queue > net/mlx5: function to create Rx verbs work queue > net/mlx5: create advanced RxQ using new API > net/mlx5: support LRO with single RxQ object > doc: update MLX5 doc and release notes with LRO > > Matan Azrad (5): > net/mlx5: replace the external mbuf shared memory > net/mlx5: update LRO fields in completion entry > net/mlx5: handle LRO packets in Rx queue > net/mlx5: zero the LRO mbuf headroom > net/mlx5: adjust the maximum LRO message size I am getting build error on patch by patch build, didn't dig to figure out which exact patch to fail, please investigate. And this patchset, adding a new feature, is sent on last day of the rc2, and merged in the same day, do you guys really sure it has been reviewed well? There are two group of build errors [1] & [2], both of them are observed with both gcc and clang. [1] .../drivers/net/mlx5/mlx5_rxq.c:2150:7: error: variable 'qp' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]... if (!tir) {... ^~~~... .../drivers/net/mlx5/mlx5_rxq.c:2191:6: note: uninitialized use occurs here... if (qp)... ^~... .../drivers/net/mlx5/mlx5_rxq.c:2150:3: note: remove the 'if' if its condition is always false... if (!tir) {... ^~~~~~~~~~~... .../drivers/net/mlx5/mlx5_rxq.c:2046:19: note: initialize the variable 'qp' to silence this warning... struct ibv_qp *qp;... ^... = NULL... 1 error generated.... [2] .../drivers/net/mlx5/mlx5.c:1450:17: error: incomplete definition of type 'struct mlx5dv_devx_umem' if (page->umem->umem_id == umem_id) ~~~~~~~~~~^ .../drivers/net/mlx5/mlx5_glue.h:64:8: note: forward declaration of 'struct mlx5dv_devx_umem' struct mlx5dv_devx_umem; ^ 1 error generated.