From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03DFBC10F1A for ; Thu, 9 May 2024 09:59:21 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40101402D7; Thu, 9 May 2024 11:59:21 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id B4212402B7 for ; Thu, 9 May 2024 11:59:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B0F03106F; Thu, 9 May 2024 02:59:44 -0700 (PDT) Received: from [10.1.194.74] (unknown [10.1.194.74]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18F483F6A8; Thu, 9 May 2024 02:59:17 -0700 (PDT) Message-ID: Date: Thu, 9 May 2024 10:59:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Improve interactive shell output gathering and logging Content-Language: en-GB To: jspewock@iol.unh.edu, wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, probb@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com Cc: dev@dpdk.org References: <20240312172558.11844-1-jspewock@iol.unh.edu> <20240501161623.26672-1-jspewock@iol.unh.edu> From: Luca Vizzarro In-Reply-To: <20240501161623.26672-1-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 01/05/2024 17:16, jspewock@iol.unh.edu wrote: > This version addresses comments from the last and adds an additional > improvement to the logging output that comes from interactive shells. > The new way of handling logging allows for not only specification of the > host that the command is being sent to like before, but also the type of > shell that you are addressing. This is beneficial for 2 reasons: > > 1. Less ambiguity on if a command is being sent to the host directly or > into an interactive shell > 2. Ability to name shells so that there is distinction in the logs > between two different interactive shells of the same type that serve a > different purpose (e.g. a python shell and a python shell that is > serving and XML-RPC server for scapy interactions) Hi Jeremy, Thank you for your patches! Everything looks good to me. Best, Luca