From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F257C433FE for ; Wed, 5 Oct 2022 16:52:26 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B4FF40694; Wed, 5 Oct 2022 18:52:25 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87]) by mails.dpdk.org (Postfix) with ESMTP id 5B4D940694 for ; Wed, 5 Oct 2022 18:52:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDDvtQFexO3UiK00nYUWpVIU6KVkWyyFukz0M9vn/vP8lacsY7+gdyxarOIElL+vaPr3W9NnC3Gcb6HUrOU4C2OmwuQmRFioS6619R5BwF/Rv3pmNMk4w8favqrMcBcW1GwbLDI4f25C+cMqgcRCb8A0crp1OU3rgasogGNYuWAM3n/11XI6F4EygF3e1dXINav6v/kN8cMUffoKZDJ57DhcQuFGZhUw9332y3ndh50aF/yxEHwgWMqV7WzgR5Nf01O8FEOcK+fn9yZPg2mdN874WX7dCGoNITzzDLlrl4Fj1ZGd2sHbkn2Go0QhLkE5ZBl/x0hJA3oi4ry3aKpyCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9TqJifi7nYmZaFtsdY1YvZycehLoLC5ox0sENvXhTOI=; b=HxLjc7DxztXrwgp/bbFbvBywcwdaZaPPIIJcXNm0WtiC7Vq0d2qtXxrnA6iYH9ZGp8a+ezKqzCAm1yn/Pq8t0npnRi164PzkG3dkr71PJdI83sS+vTFFlbVhNwFHGTBT6+FAFGwgagnrza1MumKG8eu+ZjmVOiIbwLtkljdfTo8oB7x2z/MWkBpQK+sil6FZvvdTCUulKSNwzW43Xpk7Vyp8JKhd0GYumaXb/Befq9eRLUA0o5CwJ4umC2avHNowU4DDa96H+F67iuOzmJRMHytc8qur6Gf668f9iW3E9MTLonObNaIN/p+T05lxV9qpm0eu3F8XdvyGdCt0OA9Nug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9TqJifi7nYmZaFtsdY1YvZycehLoLC5ox0sENvXhTOI=; b=NyEHkD/9RifUg8ee8BvXbZGaSX4PbNZyDGR59cnmX3M5CAl5R6l+F73zXyEeQEpUwQiyDgoHo7O7aXPiPpg9H8MzR/B2a4KukWJjwgYzwq2iHupWZT03nD2WLcM1tU5fgsNzbxi11Sjfrj3yhxMg+cPR8BmpPfs6IuCQvS9/PE8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5364.namprd12.prod.outlook.com (2603:10b6:208:314::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct 2022 16:52:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 16:52:19 +0000 Message-ID: Date: Wed, 5 Oct 2022 17:52:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v10 00/13] preparation for the rte_flow offload of nfp PMD Content-Language: en-US From: Ferruh Yigit To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1664175597-37248-1-git-send-email-chaoyong.he@corigine.com> <24f3c7ae-17b7-9086-69cd-c785d8d620b5@amd.com> In-Reply-To: <24f3c7ae-17b7-9086-69cd-c785d8d620b5@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0120.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5364:EE_ X-MS-Office365-Filtering-Correlation-Id: 54fa79ae-a14a-4c3e-98e3-08daa6f1f77f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kmsbbyb/7TGgMyvsqCTznDKyjsLwl0DfwVT2yJs6YFrpVuKRCjIRy3kAT1dj5OZsHd7hsrrNTa2aqr8nkOa9Anq4fmBnWWEKUG7qO0aSSbhy6OVD1uL4eC9MvBKkMNhrkst0hWjeHs/DV1szOIiapv8UEnUsHzYHQ2ni2dKEmPDcy7ITQXc6kbqn8skx+6/547Wo8+P2HdHtfJVFhN9eJabOi+xCzIm5OYQ+sj94YzsPEIgOnbb+dll5ebhQY0aena1KQJpo3KcZmsMm0hvKFtaFFNE1gDLznwpBZiMPbnAEwJAeaIPwJJgHtSQ6Vin2hUr/USkejozM4q2y+FAXKQY+uE4OHJiEhy/c68geT8/MmcLXd/Nt1vSP5U9/NDiApJL9Tqze+GMCS6pvRBgaeD1HfP06AsyR9bmSJW8z+i3R4yfi8C0m1tXgSM5njq9fnILHixrtw+NfzgGC63YrTNo1n9buWUHgTUiCpR+f7Ic0+LXEd6SJ6T63xlZjDArWxLDLvHbJ3BIGR/n25zKzoYdZBKxsfFOtiGltjEx6ZQvbLefSa/o6lICvdeD97XmZqx6hcWRhbBgLLOw30Q5ZmgFlzrQF9FHJ0tInrl9OtMuYVVBUpw2wTPIsId4zzalktrNyfm89UwRkVMIeZIW3wIC/yV7qh0ON2fo8UhPtYOnOIExAn4Sg3CIn09CINI+4PC+mKCx0XnFsmWQ7OScjAr6eoJcmPHF7+cfyTgqPGY0ykzNHGUF4+a/wS1rAI967tIRxbb5zEyM1DjNXaIpP+pNxvG+EHwXG7AYbqbq1LdzKaEDsFPK2xCN49DSYW9E2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199015)(966005)(31686004)(83380400001)(478600001)(6486002)(53546011)(41300700001)(36756003)(6666004)(6506007)(26005)(8936002)(66556008)(6512007)(4326008)(8676002)(5660300002)(66476007)(44832011)(66946007)(316002)(31696002)(86362001)(2906002)(186003)(2616005)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0w1NlF3WXJBQU00Qmg3dkNSQ0NXcDJkSnEwakpFTWRoSjdiQjBubWcxSGl4?= =?utf-8?B?eHhSRWJPVUZKWWw0cnRKdVBaSnVYSnVVekJzNFFxbmRyREEvN3hPYXRUNWFX?= =?utf-8?B?TkxSVVVldjN1V2t0KzJMQlByVFlkT3N3TFJ2a3dlbWJWckpJbVE0Wm1GTVNi?= =?utf-8?B?QWNldFg5NktDTzl0YktTMXVpclA0OTlUOVdOeUtOZ0xGeU5uamh3V0ZROWJ3?= =?utf-8?B?WmJlMExxS0Zha3Q1WDY0clhBMjRmMUZIV3MrZWVLQUxwZVV4bFVaNVAyUUM5?= =?utf-8?B?TW5ZTXpqbkFXSjcvQWhVSTBIb2JON015SmVqMHREU2N0dWtPRktrMktlSVFk?= =?utf-8?B?MUFWUXpzU0N5TDRmTEtoZC9xM2liN0s1Q0tGWVoxQWlVTGU5L1pmMVlxbWo3?= =?utf-8?B?d0FqeUtiNldoK2JQMDNiUGwwaVR4U0NXN0QxL0FaenhmdDVVb1FnRDFsbHR1?= =?utf-8?B?VUYrT2V5SWJMb2hGUGFYUEF3Qzk5OVkxZ1BsSmkvV2hSKy9HQnRjQ1ExbjNj?= =?utf-8?B?aFNTTGNDcVpCWFZ2OTRtU0xFemlvZXBVRnlmMlZVTjMrZFZ5WTJBYmFINnZm?= =?utf-8?B?c0VSSVVsbDI0bUN3NDNJL0x0TENSc1RqQ2l5WW9zUVlWMm9YUXRDVUtjc05i?= =?utf-8?B?bDB3NHR5R1BVa2xSZEZSb2JVNGxaZFJTNkZHYnNoay9SMC9pM2dPVnVLbXN6?= =?utf-8?B?SFZ4VkJMelV6UWt0ZVA3eHF1N2k4dWZNa0RESzlnMWVmcUxIWS93VXo1Zmlz?= =?utf-8?B?TFlyd2RQQ3JhZi8rWkhpOHQ4SDh2TUdUcWE4OVlmV3lSdzdpRGpxNW1HNTBv?= =?utf-8?B?SWhSZUlSM0w3T1laeCtvbTluQ1BOOXRqZUxyYkRueW8yTTRrL0p3MlkxOVU0?= =?utf-8?B?VGozc3VvTnpOVTJtZ29SVFhMRnlVQllPZ0wxSkFtUXVkWFUvaUhMUGJpNm1s?= =?utf-8?B?bndJVThEckhtSHNkc3R5YUVpQk5wTlFKc2VQMXV5c3FyaHcycVRWc2REbkFi?= =?utf-8?B?NkF2SElCOTBWZ1VXZXFIb2gzUkd0Y2ErUGZPM2VxZk9idi9KTGxyamJ5cnpH?= =?utf-8?B?b2R1M0I1VE40V3NObjVTZWVQY25lUXhkSVkreStIeHVxa3VlQUQ4a1BuRm1x?= =?utf-8?B?OS9mdjNpK3ZLczJhbkFmTmNweEZzdDJoVllwQ1JidDhUMEZ3WnEvZ3FyOXV6?= =?utf-8?B?ei82bEYrUm56eXBwTW9lSXFhRndnTnExNlhmOThoQVcweFljMmlaaHVBT0Z5?= =?utf-8?B?UjBvZVZ4NGl4bkIrcGFWeEUrUFZGK0szbHJnRy9kckhLNzBGS0dTaDZ3MU45?= =?utf-8?B?bU5pNVVnTjRWd0M2TXBKWHlJcko1elNXanF1NHhUOGt6RmJvYldJbWdURVNl?= =?utf-8?B?WFVUYUpxbXNjdlZldDNmdjJXVWJXbnh0c21tc2g0eVpqOHIyMERBM2JlMG43?= =?utf-8?B?eGRFOGc3QXRVZXd5VmI2V0F2NEJzREVWd1JMZnBXU0dEQ0pacTc2T3pIVTZ1?= =?utf-8?B?K1g3WENTcTBvVjk4d0VRVkZudEtqNVhyS0lWZkJIRjZneXhadEV1NytkNEVa?= =?utf-8?B?dXMwOTEwOG5DTmwwVjl2dm1SMXlFQVdLMTg5M3JKb0ttaHphaGZVV2NvMUsx?= =?utf-8?B?cHcxS1RaV09uT2ZnVmVNelFCUjU0Q0Y0MGFOLzNaV0tlS3VQdmlsbktUMEZp?= =?utf-8?B?NHR6QTFDMDd2L05CSVlNWjNSaFhxWlZmZ1ZrZEJGNDBGZnY4YXRyZ2Mwckk1?= =?utf-8?B?aE5DL0lwQXprTVE1aFZEZnpzZnkvNDBPSU1qRHpmbGo2eDd1dUQzRTJVaURP?= =?utf-8?B?Ly9ER0puZy9wRU5ROFNFK0RTSU8yZU0rcTZhU0M3VkgwOHUvamV4MTBLb005?= =?utf-8?B?V1ZsYlRKeWZEbFhHNm5Demg4eVBIdGVCU08ydWZ6aDFDSVA0QWVSQVBRQmpY?= =?utf-8?B?T0xrRnhiU1ptQlNiZzBGMUdJV1RucXBvR0FkWVVUbks5SXpvMEhBbDE4dWJD?= =?utf-8?B?UzgwcTRXaDUxQzFJa1h0NnF6V3R0MEg0Z1lsc1ZwRDZ2YVVyZDl4aElkc0F3?= =?utf-8?B?d3dWVi9sTmN5c2JScW1FVkdnRE1La3BrTHdWSkhoT0RDK2ljQ3Y5VUVXWlho?= =?utf-8?Q?Czgr2k/v24/4/s9E/BfrVpI6X?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54fa79ae-a14a-4c3e-98e3-08daa6f1f77f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 16:52:19.8197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /MScs3Wwd6QDi/dccXy8t/t87MG1CpdygRXmMgZWuEFM8hta9YRIB7iwJwdcqGLw X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5364 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/5/2022 12:34 PM, Ferruh Yigit wrote: > On 9/26/2022 7:59 AM, Chaoyong He wrote: >> This is the first patch series to add the support of rte_flow offload for >> nfp PMD, includes: >> Add the support of flower firmware application >> Add the support of representor port >> Add the flower service infrastructure >> Add the cmsg interactive channels between pmd and fw >> >> * Changes since v9 >> - Remove the use of rte_eth_tx_burst() >> - Remove the logics rely on OvS >> >> * Changes since v8 >> - Update the nfp.rst >> - Fix the 'app_hw' to 'app_fw' >> - Remove the ovs compatible header file >> - Remove the use of >> rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API >> >> * Changes since v7 >> - Adjust the logics to make sure not break the pci probe process >> - Change 'app' to 'app_fw' in all logics to avoid confuse >> - Fix problem about log level >> >> * Changes since v6 >> - Fix the compile error >> >> * Changes since v5 >> - Compare integer with 0 explicitly >> - Change helper macro to function >> - Implement the dummy functions >> - Remove some unnecessary logics >> >> * Changes since v4 >> - Remove the unneeded '__rte_unused' attribute >> - Fixup a potential memory leak problem >> >> * Changes since v3 >> - Add the 'Depends-on' tag >> >> * Changes since v2 >> - Remove the use of rte_panic() >> >> * Changes since v1 >> - Fix the compile error >> >> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware >> with NFDk") >> >> Chaoyong He (13): >>    net/nfp: move app specific attributes to own struct >>    net/nfp: simplify initialization and remove dead code >>    net/nfp: move app specific init logic to own function >>    net/nfp: add initial flower firmware support >>    net/nfp: add flower PF setup logic >>    net/nfp: add flower ctrl VNIC related logics >>    net/nfp: move common rxtx function for flower use >>    net/nfp: add flower ctrl VNIC rxtx logic >>    net/nfp: add flower representor framework >>    net/nfp: add flower PF related routines >>    net/nfp: move rxtx function to header file >>    net/nfp: add flower PF rxtx logic >>    net/nfp: add the representor port rxtx logic >> > > Series applied to dpdk-next-net/main, thanks. > Ahh, this has a small conflict with other set [1], and other one is fix. To keep fix patch backportable to stable trees, I will get that series first and apply this set on top of it, by force push to next-net. Please highlight these kind of dependencies in advance, in commit log etc. And can you please double check final code in next-net head? [1] https://patches.dpdk.org/project/dpdk/patch/20220922130314.694790-2-niklas.soderlund@corigine.com/ [1/2] net/nfp: fix return value of nfp card init function