From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Guo, Jia" Subject: Re: [PATCH V10 1/2] eal: add uevent monitor api and callback func Date: Mon, 15 Jan 2018 23:29:52 +0800 Message-ID: References: <1515575544-2141-3-git-send-email-jia.guo@intel.com> <6774704.u5U2Uf1Nb3@xps> <3468196.BpI31Qveuv@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com To: Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AECB7A48F for ; Mon, 15 Jan 2018 16:29:55 +0100 (CET) In-Reply-To: <3468196.BpI31Qveuv@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/15/2018 7:32 PM, Thomas Monjalon wrote: > 15/01/2018 11:55, Guo, Jia: >> On 1/15/2018 7:16 AM, Thomas Monjalon wrote: >>> Hi, >>> >>> 11/01/2018 15:05, Jeff Guo: >>>> +/* A genaral callback for all registerd devices */ >>> Typos: genaral, registerd >>> >>> So the callback is only for registered devices? >>> What about hotplugged devices? >> the hotplugged devices is managed by the application, if it prior >> registered and in the app's hotplug device list, will always be monitor >> whenever it plug in and out. the eal only care about the registered >> devices. > I disagree. The application needs the EAL service to get notified > of a new device plugged in. > We should find a way to register the callback for all devices, > including new ones. i think the current mechanism would let eal service detect all new device in , but would not notify all to the application. if the application need to monitor specific device , it will prior know the device name. but if notify all in eal service and let application choose it in user side ,that is other story, that is what you want ? but do you think about , if it is need to let user know all device plugin , or just let eal know all info would be better or safer?