From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E360C4740A for ; Mon, 9 Sep 2019 11:00:58 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4407F20678 for ; Mon, 9 Sep 2019 11:00:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4407F20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 789151EB9D; Mon, 9 Sep 2019 13:00:57 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5CAF91EB97 for ; Mon, 9 Sep 2019 13:00:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 04:00:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="196161900" Received: from rnicolau-mobl1.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga002.jf.intel.com with ESMTP; 09 Sep 2019 04:00:52 -0700 To: "Ananyev, Konstantin" , "dev@dpdk.org" Cc: "Lu, Wenzhuo" , "Doherty, Declan" References: <1567788116-16952-1-git-send-email-radu.nicolau@intel.com> <2601191342CEEE43887BDE71AB977258019195D348@irsmsx105.ger.corp.intel.com> From: "Nicolau, Radu" Message-ID: Date: Mon, 9 Sep 2019 12:00:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB977258019195D348@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add security statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 9/8/2019 12:45 PM, Ananyev, Konstantin wrote: > Hi Radu, > >> Update IXGBE PMD with support for IPsec statistics. > The proposed approach - have a new hash table per device, > plus parse each packet on RX and TX and do hash lookup > seems way too heavy to put it into PMD. It is indeed heavy, but it's disabled by default and it only uses the heavy section when the app is enabling per-session statistics > Wonder why we need to do that? > If HW doesn't provide such statistic info, why not to leave it > to the upper layer to collect/maintain? > In many cases SW will already have that infrastructure > and I don't see to put all these heavy-weight operations > into ixgbe rx/tx path. The reason is to use the rte_security API consistently and take advantage of the hardware backed statistics when they are available. > > Konstantin