DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: David Christensen <drc@linux.vnet.ibm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Tiwei Bie <tiwei.bie@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting
Date: Thu, 15 Aug 2019 09:16:23 -0700
Message-ID: <f56fc826-c2f2-b54e-8555-574b138b6a4e@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJFAV8yX_DwCkRT+pfgmEP2HUm24=ypN_Smba=PjsxHNjUToaw@mail.gmail.com>

>> Use of %llx print formatting causes meson build error on Power systems with
>> RHEL 7.6 and gcc 4.8.5.  Replace with PRIx64 macro.
>>
>> +                               (uint64_t)reg_struct.range.start,
>> +                               (uint64_t)reg_struct.range.start +
>> +                               (uint64_t)reg_struct.range.len - 1);

I didn't need them when compiling on Power but it's the only way I could 
get x86 to build without any warning:

cc -Ilib/lib@@rte_vhost@sta -Ilib -I../lib -Ilib/librte_vhost 
-I../lib/librte_vhost -I. -I../ -Iconfig -I../config 
-Ilib/librte_eal/common/include -I../lib/librte_eal/common/include 
-I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common 
-I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 
-I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal 
-I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs 
-Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_net 
-I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf 
-Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring 
-I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter 
-Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_hash 
-I../lib/librte_hash -Ilib/librte_pci -I../lib/librte_pci -pipe 
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h 
-Wunused-parameter -Wsign-compare -Wcast-qual -D_GNU_SOURCE -fPIC 
-march=native -fno-strict-aliasing -DALLOW_EXPERIMENTAL_API  -MD -MQ 
'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -MF 
'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o.d' -o 
'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -c 
../lib/librte_vhost/vhost_user.c
../lib/librte_vhost/vhost_user.c: In function ‘vhost_user_set_mem_table’:
../lib/librte_vhost/vhost_user.c:1088:4: warning: format ‘%lx’ expects 
argument of type ‘long unsigned int’, but argument 4 has type ‘__u64’ 
[-Wformat=]
     RTE_LOG(INFO, VHOST_CONFIG,
     ^
../lib/librte_vhost/vhost_user.c:1088:4: warning: format ‘%lx’ expects 
argument of type ‘long unsigned int’, but argument 5 has type ‘__u64’ 
[-Wformat=]

This system was also RHEL 7.6 with gcc 4.8.5-36
Dave

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 18:36 [dpdk-dev] [PATCH 0/2] fixes to resolve meson build issues on Power systems David Christensen
2019-08-14 18:36 ` [dpdk-dev] [PATCH 1/2] config: fix RHEL7.6 build errors on Power 9 systems David Christensen
2019-08-14 18:36 ` [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting David Christensen
2019-08-15  6:53   ` David Marchand
2019-08-15 16:16     ` David Christensen [this message]
2019-08-19  8:40       ` David Marchand
2019-08-19 11:41         ` Maxime Coquelin

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f56fc826-c2f2-b54e-8555-574b138b6a4e@linux.vnet.ibm.com \
    --to=drc@linux.vnet.ibm.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox