Re: [dpdk-dev] [PATCH v4 07/11] net/hinic/base: add various headers

From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ziyang Xuan <xuanziyang2@huawei.com>, dev@dpdk.org
Cc: cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com,
	shahar.belkar@huawei.com, stephen@networkplumber.org,
	luoxianjun@huawei.com
Subject: Re: [dpdk-dev] [PATCH v4 07/11] net/hinic/base: add various headers
Date: Tue, 11 Jun 2019 17:04:10 +0100	[thread overview]
Message-ID: <f5d29df7-4b01-de52-74c3-e41d00de23f7@intel.com> (raw)
In-Reply-To: <729eff13dd2b38369c2e4f7361d780d2ba624635.1559818024.git.xuanziyang2@huawei.com>

On 6/6/2019 12:06 PM, Ziyang Xuan wrote:
> Add various headers that define mgmt commands, cmdq commands,
> rx data structures, tx data structures and basic defines for
> use in the code.
> 
> Signed-off-by: Ziyang Xuan <xuanziyang2@huawei.com>

<...>

> +#define PMD_DRV_LOG(level, fmt, args...) \
> +	rte_log(RTE_LOG_ ## level, hinic_logtype, \
> +		HINIC_DRIVER_NAME": " fmt "\n", ##args)
> +
> +#define HINIC_ASSERT_EN
> +
> +#ifdef HINIC_ASSERT_EN
> +#define HINIC_ASSERT(exp)	\
> +	do {			\
> +		if (!(exp)) {	\
> +			rte_panic("line%d\tassert \"" #exp "\" failed\n", \
> +				  __LINE__);	\
> +		}		\
> +	} while (0)
> +#else
> +#define HINIC_ASSERT(exp)	do {} while (0)
> +#endif

So you are enabling asserting by default? Which can cause "rte_panic()" ?

Please make sure asserting is disabled by default, and please tie this to the
"CONFIG_RTE_ENABLE_ASSERT" config option. So it that option is disabled hinic
also should disable the assertions.