From: Aaron Conole <aconole@redhat.com>
To: <agupta3@marvell.com>
Cc: Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>, <dev@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
Date: Fri, 13 Sep 2019 10:40:49 -0400 [thread overview]
Message-ID: <f7td0g4l0ni.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1568362357-18061-1-git-send-email-agupta3@marvell.com> (agupta3@marvell.com's message of "Fri, 13 Sep 2019 13:42:36 +0530")
<agupta3@marvell.com> writes:
> From: Amit Gupta <agupta3@marvell.com>
>
> hash_readwrite_lf test always getting TIMEOUT as required
> time to finish this test was much longer compare to time
> required for fast tests(10s). Hence, the test is being renamed
> moved to perf test category for its execution to complete.
>
> Signed-off-by: Amit Gupta <agupta3@marvell.com>
> ---
Okay. I'll note that we pass the '-t 3' flag, so it is actually timing
out with 30s instead of the default 10. We do this because occasionally
the lpm6 and table tests would also exceed the 10s timeout in the travis
environment. I agree, it's better to pull the perf part of tests out.
I think there isn't any additional functional test in this readwrite -
is that so? If it is, then we need to also prioritize adding back in
some of the functional testing. Maybe I misread the lf_autotest,
though.
> app/test/meson.build | 2 +-
> app/test/test_hash_readwrite_lf.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 94fd9f8..57d5316 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -220,7 +220,6 @@ fast_test_names = [
> 'eventdev_common_autotest',
> 'fbarray_autotest',
> 'hash_readwrite_func_autotest',
> - 'hash_readwrite_lf_autotest',
> 'ipsec_autotest',
> 'kni_autotest',
> 'kvargs_autotest',
> @@ -263,6 +262,7 @@ perf_test_names = [
> 'stack_lf_perf_autotest',
> 'rand_perf_autotest',
> 'hash_readwrite_perf_autotest',
> + 'hash_readwrite_lf_perf_autotest',
> ]
>
> driver_test_names = [
> diff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c
> index 1f2fba4..33d63fa 100644
> --- a/app/test/test_hash_readwrite_lf.c
> +++ b/app/test/test_hash_readwrite_lf.c
> @@ -1431,4 +1431,5 @@ struct {
> return 0;
> }
>
> -REGISTER_TEST_COMMAND(hash_readwrite_lf_autotest, test_hash_readwrite_lf_main);
> +REGISTER_TEST_COMMAND(hash_readwrite_lf_perf_autotest,
> + test_hash_readwrite_lf_main);
next prev parent reply other threads:[~2019-09-13 14:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
2019-09-06 5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
2019-09-11 17:05 ` Wang, Yipeng1
2019-10-17 5:02 ` Amit Gupta
2019-11-01 4:54 ` Amit Gupta
2019-11-01 17:04 ` Wang, Yipeng1
2019-11-05 16:37 ` Ferruh Yigit
2019-11-07 3:32 ` [dpdk-dev] [EXT] " Amit Gupta
2019-12-31 4:56 ` Amit Gupta
2019-09-06 5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
2019-09-11 17:13 ` Wang, Yipeng1
2019-09-12 15:00 ` Honnappa Nagarahalli
2019-09-13 8:24 ` Amit Gupta
2019-09-13 8:12 ` [dpdk-dev] [PATCH v2 1/1] " agupta3
2019-09-13 14:40 ` Aaron Conole [this message]
2019-09-13 15:09 ` Wang, Yipeng1
2019-09-13 15:46 ` Honnappa Nagarahalli
2019-09-16 4:39 ` Amit Gupta
2019-10-17 4:57 ` Amit Gupta
2019-10-17 13:16 ` Aaron Conole
2019-10-24 7:22 ` David Marchand
2019-09-13 8:15 ` agupta3
2019-09-11 5:55 ` [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure Amit Gupta
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 0/5] " Honnappa Nagarahalli
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 1/5] test/meson: hash test split into shorter subtests Honnappa Nagarahalli
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code Honnappa Nagarahalli
2020-02-05 8:48 ` David Marchand
2020-02-05 16:42 ` David Marchand
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests Honnappa Nagarahalli
2020-02-05 9:07 ` David Marchand
2020-02-05 16:22 ` Honnappa Nagarahalli
2020-02-05 16:41 ` David Marchand
2020-02-05 19:34 ` Wang, Yipeng1
2020-02-05 19:52 ` Honnappa Nagarahalli
2020-02-05 19:57 ` Wang, Yipeng1
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 4/5] test/hash: move reader writer lock free tests to perf tests Honnappa Nagarahalli
2020-02-03 19:49 ` [dpdk-dev] [PATCH v2 5/5] hash: correct lock free extendable table support Honnappa Nagarahalli
2020-02-05 18:41 ` [dpdk-dev] [PATCH v2 0/5] test/meson: fix hash readwrite timeout failure David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7td0g4l0ni.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=agupta3@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).