From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8192EC3A59E for ; Wed, 21 Aug 2019 13:04:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 438A422D6D for ; Wed, 21 Aug 2019 13:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 438A422D6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FFD11BEFB; Wed, 21 Aug 2019 15:04:03 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 884511BEF4 for ; Wed, 21 Aug 2019 15:04:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC8553082129; Wed, 21 Aug 2019 13:04:01 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AE472B0E7; Wed, 21 Aug 2019 13:04:01 +0000 (UTC) From: Aaron Conole To: Stephen Hemminger Cc: dev@dpdk.org References: <20190820233330.27474-1-stephen@networkplumber.org> Date: Wed, 21 Aug 2019 09:04:00 -0400 In-Reply-To: <20190820233330.27474-1-stephen@networkplumber.org> (Stephen Hemminger's message of "Tue, 20 Aug 2019 16:33:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 21 Aug 2019 13:04:02 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] eal: remove redundant error output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Stephen Hemminger writes: > The function rte_eal_init_alert ends up printing the same message > twice. Once via RTE_LOG and once to stderr. Remove the fprintf > to stderr since it is redundant. > > Signed-off-by: Stephen Hemminger > --- This was originally added at your suggestion: http://mails.dpdk.org/archives/dev/2017-January/056431.html Because sometimes we have these alerts before logging is up (so the RTE_LOG(...) won't show up, I gather). Is it possible to have an either/or? > lib/librte_eal/linux/eal/eal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c > index 946222ccdb7a..076fb3cbde5f 100644 > --- a/lib/librte_eal/linux/eal/eal.c > +++ b/lib/librte_eal/linux/eal/eal.c > @@ -949,7 +949,6 @@ static int rte_eal_vfio_setup(void) > > static void rte_eal_init_alert(const char *msg) > { > - fprintf(stderr, "EAL: FATAL: %s\n", msg); > RTE_LOG(ERR, EAL, "%s\n", msg); > }