From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CE4C43331 for ; Fri, 6 Sep 2019 08:23:28 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 349552082C for ; Fri, 6 Sep 2019 08:23:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 349552082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51FAB1F275; Fri, 6 Sep 2019 10:23:27 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id DF0FC1F26E for ; Fri, 6 Sep 2019 10:23:25 +0200 (CEST) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 997EB22DBA9261E5EDC1; Fri, 6 Sep 2019 16:23:24 +0800 (CST) Received: from [127.0.0.1] (10.57.115.182) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Fri, 6 Sep 2019 16:23:18 +0800 To: Ferruh Yigit , References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com> <1566568031-45991-10-git-send-email-xavier.huwei@huawei.com> <97ec0b71-cfd5-06eb-4518-b44b64ef8ae5@intel.com> CC: , , , From: "Wei Hu (Xavier)" Message-ID: Date: Fri, 6 Sep 2019 16:23:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <97ec0b71-cfd5-06eb-4518-b44b64ef8ae5@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 09/22] net/hns3: add support for flow directory of hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh Yigit On 2019/8/30 23:06, Ferruh Yigit wrote: > On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: >> This patch adds support for flow directory of hns3 PMD driver. >> Flow directory feature is only supported in hns3 PF driver. >> It supports the network L2\L3\L4 and tunnel packet creation, >> deletion, flushing, and querying hit statistics. > This patch also adds rte_flow support, can you please add this into commit log? OK, I will update it and send patch V2. Thanks. >> Signed-off-by: Chunsong Feng >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Hao Chen >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Huisong Li > <...> > >> @@ -2726,6 +2744,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { >> .mac_addr_set = hns3_set_default_mac_addr, >> .set_mc_addr_list = hns3_set_mc_mac_addr_list, >> .link_update = hns3_dev_link_update, >> + .filter_ctrl = hns3_dev_filter_ctrl, > 'hns3_dev_filter_ctrl()' is not exists up until this patch. > > This is the problem of not enabling the driver yet, it is very hard to see these > kind of issues. When Makefile/meson patch moved to the begging of the patches > and start to build the driver, these issues will be visible. I will fix it in patch V2. >> }; >> >> static int >> @@ -2739,6 +2758,16 @@ hns3_dev_init(struct rte_eth_dev *eth_dev) >> int ret; >> >> PMD_INIT_FUNC_TRACE(); >> + eth_dev->process_private = (struct hns3_process_private *) >> + rte_zmalloc_socket("hns3_filter_list", >> + sizeof(struct hns3_process_private), >> + RTE_CACHE_LINE_SIZE, eth_dev->device->numa_node); >> + if (eth_dev->process_private == NULL) { >> + PMD_INIT_LOG(ERR, "Failed to alloc memory for process private"); >> + return -ENOMEM; >> + } >> + /* initialize flow filter lists */ >> + hns3_filterlist_init(eth_dev); > Can you please free 'process_private' in, close dev_ops? We will update it and send patch V2. Regards Xavier