dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ting Xu <ting.xu@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
	bernard.iremonger@intel.com,  stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] app/testpmd: fix CRC strip config error
Date: Mon, 14 Oct 2019 13:28:57 +0100	[thread overview]
Message-ID: <feb14da2-c3f5-7d59-b488-189be54188f1@intel.com> (raw)
In-Reply-To: <22fa727a2ce09834133530c40cb02666e0be10ba.1570882485.git.ting.xu@intel.com>

On 10/12/2019 1:18 PM, Ting Xu wrote:
> This patch fixed the bug that an error appears when config rx_offload
> crc_strip using command "port config all crc-strip on|off". The reason
> is that this command was removed previously. However, the current command
> does not enable "crc_strip" option properly, so that testpmd returns
> error when config crc_strip.

"port config all crc-strip ..." is already removed,
Commit e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")

And 'crc_strip' seems left over for the "port config <id> rx_offload ..."
command, instead of fixing it should be removed, and 'keep_crc' should be used,
"port config <id> rx_offload keep_crc on|off"

Did you observe any problem on 'keep_crc' ?

> 
> In this patch, an additional operation is added to recognize "crc_strip"
> option, since "crc_strip" and "keep_crc" are using the same flag
> "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config
> <port_id> rx_offload crc_strip on|off".
> 
> Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ting Xu <ting.xu@intel.com>

<...>



  parent reply	other threads:[~2019-10-14 12:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12 12:18 [dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error Ting Xu
2019-10-14 11:25 ` Iremonger, Bernard
2019-10-14 11:41   ` Iremonger, Bernard
2019-10-15  1:03     ` Xu, Ting
2019-10-14 12:28 ` Ferruh Yigit [this message]
2019-10-15  0:49   ` [dpdk-dev] [dpdk-stable] " Xu, Ting
2019-10-15  9:14 ` [dpdk-dev] [PATCH v2] app/testpmd: fix CRC strip command failure Ting Xu
2019-10-15  9:40   ` Iremonger, Bernard
2019-10-15 13:13     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feb14da2-c3f5-7d59-b488-189be54188f1@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=stable@dpdk.org \
    --cc=ting.xu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).