From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A00B2C10DCE for ; Fri, 13 Mar 2020 16:10:48 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2B85E206EB for ; Fri, 13 Mar 2020 16:10:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=accelercomm-com.20150623.gappssmtp.com header.i=@accelercomm-com.20150623.gappssmtp.com header.b="xrg6lPJx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B85E206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=accelercomm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4A4E1BF97; Fri, 13 Mar 2020 17:10:46 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 5C2E12BE3 for ; Fri, 13 Mar 2020 17:10:45 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id d5so12476491wrc.2 for ; Fri, 13 Mar 2020 09:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=accelercomm-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=nf6lprwlFxm4Z+Zdt1r9lhTZFEOMBXGwqW62ggEu7aM=; b=xrg6lPJx4MEM43Jhf+8NADZOf+fXFtUP3t3aVtYE4iMAU0tMJERe/s4Zzg5Z95iSd7 T2Ye8ILnJF9xBVJY/0wEgNNn9ur19CiOMKKgp7kZqaAzjD7rye+FMoIDuN4zYdDNeKMu P/RWTC10Xxat7OmXYNqF/kwdRoqWVVXcm/621ADcfIVI44B1nDwABWbmsJm1llDXWI8s VnQLMnRgiDWAPbOCVJMsz79Rcsj6g06OHw2itH7eQefpxzipY/M9jS5Xm/632J3Lg4tf CvQUnT8Qc3rswkXR/nrF6C/BG8CHbV4QaVCS8UtA0lOA14Dv14h4IdsaCCeJ7X59rTM9 s+ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=nf6lprwlFxm4Z+Zdt1r9lhTZFEOMBXGwqW62ggEu7aM=; b=lV2DHbo5xPljcaAzcwtenuy6HzoTBREGTvmjNWc8Z03Vll3nQC7eIOa5Xyr/gL5WWV jZwBezlObFQ3K4mX7xb5nnsbOQvkfvWR39w+AcnrACuDzT9iaehRl5OV7RDnVf8i/gSr ioEzNTP4iek0BW3InfHGh3yP8xNjASUYJJ4UcW4bCdRNIRSJ9hPTOCB4c3Wt1SOgWdqC Zu4DnRF8NEUIF2skBFj9/bd7HYg5rT9EMRoCurzTenSPMIb8RjWwT+TipGPbfLfUeQ5N RK6RUhFQSfW/YTPCcMUYQ96YaghCi805UbzcK5y6v7VSqByH57nvw28vS7ZbnAn8+QpN gdmg== X-Gm-Message-State: ANhLgQ2NGZmH+Z1ndKYOVORWyCTaOmd4La5QrXHHp/QLI8SnZVqZf18U zgJoBhwRkAljm/OckSLduqK0TVOnZuE= X-Google-Smtp-Source: ADFU+vvDePgGHJAiH/QxOtBPvCNipNusIKSXtZU8oo2/2Rqkl5zjrMqaF7e/KT699oghspZoOJS9Ug== X-Received: by 2002:a5d:6a8d:: with SMTP id s13mr18564171wru.260.1584115844700; Fri, 13 Mar 2020 09:10:44 -0700 (PDT) Received: from [192.168.1.189] ([89.21.231.54]) by smtp.gmail.com with ESMTPSA id f15sm17397760wmj.25.2020.03.13.09.10.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 09:10:44 -0700 (PDT) To: dev@dpdk.org References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-5-git-send-email-nicolas.chautru@intel.com> From: Dave Burley Message-ID: Date: Fri, 13 Mar 2020 16:10:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1583348102-13253-5-git-send-email-nicolas.chautru@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Dave Burley On 04/03/2020 18:54, Nicolas Chautru wrote: > From: Nic Chautru > > This is to support cases when the input data for > decoding a code block is larger than 64kB and would > not fit as a contiguous block of data into one > mbuf. In that case the length from the opearation > supersedes the mbug default structure. > > Signed-off-by: Nic Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 40 +++++++++++++++++++----- > doc/guides/rel_notes/release_20_05.rst | 6 ++++ > drivers/baseband/turbo_sw/bbdev_turbo_software.c | 11 ++++--- > 3 files changed, 45 insertions(+), 12 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index d8db58e..d46966d 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -764,6 +764,7 @@ typedef int (test_case_function)(struct active_device *ad, > { > int ret; > unsigned int i, j; > + bool large_input = false; > > for (i = 0; i < n; ++i) { > char *data; > @@ -774,24 +775,47 @@ typedef int (test_case_function)(struct active_device *ad, > op_type, n * ref_entries->nb_segments, > mbuf_pool->size); > > - TEST_ASSERT_SUCCESS(((seg->length + RTE_PKTMBUF_HEADROOM) > > - (uint32_t)UINT16_MAX), > - "Given data is bigger than allowed mbuf segment size"); > - > + if (seg->length > 64000) { > + /* > + * Special case when DPDK mbuf cannot handle > + * the required input size > + */ > + printf("Warning: Larger input size than DPDK mbuf %d\n", > + seg->length); > + large_input = true; > + } else { > + TEST_ASSERT_SUCCESS( > + ((seg->length + RTE_PKTMBUF_HEADROOM) > + > (uint32_t)UINT16_MAX), > + "Given data is bigger than allowed mbuf segment size" > + ); > + } > bufs[i].data = m_head; > bufs[i].offset = 0; > bufs[i].length = 0; > > if ((op_type == DATA_INPUT) || (op_type == DATA_HARQ_INPUT)) { > - data = rte_pktmbuf_append(m_head, seg->length); > - TEST_ASSERT_NOT_NULL(data, > + if ((op_type == DATA_INPUT) && large_input) { > + /* Allocate a fake overused mbuf */ > + data = rte_malloc(NULL, 128 * 1024, 0); > + memcpy(data, seg->addr, seg->length); > + m_head->buf_addr = data; > + m_head->buf_iova = rte_mem_virt2phy(data); > + m_head->data_off = 0; > + m_head->data_len = seg->length; > + } else { > + data = rte_pktmbuf_append(m_head, seg->length); > + TEST_ASSERT_NOT_NULL(data, > "Couldn't append %u bytes to mbuf from %d data type mbuf pool", > seg->length, op_type); > > - TEST_ASSERT(data == RTE_PTR_ALIGN(data, min_alignment), > + TEST_ASSERT(data == RTE_PTR_ALIGN( > + data, min_alignment), > "Data addr in mbuf (%p) is not aligned to device min alignment (%u)", > data, min_alignment); > - rte_memcpy(data, seg->addr, seg->length); > + rte_memcpy(data, seg->addr, seg->length); > + } > + > bufs[i].length += seg->length; > > for (j = 1; j < ref_entries->nb_segments; ++j) { > diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst > index 2190eaf..d6c3dfb 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -56,6 +56,12 @@ New Features > Also, make sure to start the actual text at the margin. > ========================================================= > > +* **Updated the TURBO_SW bbdev PMD.** > + > + Updated the ``turbo_sw`` bbdev driver with changes including: > + > + * Support for large size code block not fitting in one mbuf segment. > + * Exposes the accurate LLR decimal assumption. > > Removed Items > ------------- > diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > index 5ca8ca1..ea3fecb 100644 > --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c > +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > @@ -1335,7 +1335,7 @@ struct turbo_sw_queue { > > static inline void > process_ldpc_dec_cb(struct turbo_sw_queue *q, struct rte_bbdev_dec_op *op, > - uint8_t c, uint16_t out_length, uint16_t e, > + uint8_t c, uint16_t out_length, uint32_t e, > struct rte_mbuf *m_in, > struct rte_mbuf *m_out_head, struct rte_mbuf *m_out, > struct rte_mbuf *m_harq_in, > @@ -1617,8 +1617,8 @@ struct turbo_sw_queue { > struct rte_bbdev_stats *queue_stats) > { > uint8_t c, r = 0; > - uint16_t e, out_length; > - uint16_t crc24_overlap = 0; > + uint32_t e; > + uint16_t out_length, crc24_overlap = 0; > struct rte_bbdev_op_ldpc_dec *dec = &op->ldpc_dec; > struct rte_mbuf *m_in = dec->input.data; > struct rte_mbuf *m_harq_in = dec->harq_combined_input.data; > @@ -1661,7 +1661,10 @@ struct turbo_sw_queue { > e = (r < dec->tb_params.cab) ? > dec->tb_params.ea : dec->tb_params.eb; > > - seg_total_left = rte_pktmbuf_data_len(m_in) - in_offset; > + if (e < 64000) /* Special case handling when overusing mbuf */ > + seg_total_left = rte_pktmbuf_data_len(m_in) - in_offset; > + else > + seg_total_left = e; > > process_ldpc_dec_cb(q, op, c, out_length, e, > m_in, m_out_head, m_out,