From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D6D1EB64DB for ; Thu, 15 Jun 2023 14:47:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27C7710E50B; Thu, 15 Jun 2023 14:47:53 +0000 (UTC) Received: from mail-4018.proton.ch (mail-4018.proton.ch [185.70.40.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5EEF10E503 for ; Thu, 15 Jun 2023 14:47:50 +0000 (UTC) Date: Thu, 15 Jun 2023 14:47:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1686840466; x=1687099666; bh=FKAUli3o4hy8Ej3BV4NaF7G+I501rWlHmYecmIQngXI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Ne9VCqfTgLOqKLU81j5rT0Xqk8XPEWCRUhpqAQCdKmg+zMnbq9BWS2Z4Ll4VMeild ncqJYPKMHgvKDqYhhNInMLdW2mgf4I18yN+L8lDkzAfLf2E2CoCDlT/txtR5CCeCRf Yx+8kcQeXph8qTd4Em4eKaZo4+rcTm/FS6nddH/kVTfs9kr3lOrVyX3pHtwzYFjuCp 2q3Lz4yzcbKAgtZggB3/a3YIk6sM950e0JtRCek9bDiyDIthszXnMJeojmaJkDORgR U/jTrirw+RQfUowOmBWGdHHNqHnptgDsqVqpD9/07NQVDBYg4NrMgY9oQuxUPV/CUM Xy2VZPzbq9AWg== To: Thomas Zimmermann From: Simon Ser Subject: Re: [PATCH 1/3] drm: Enable PRIME import/export for all drivers Message-ID: <-Zu2xcAP6KgnhQVsOLkYcnIH7KhL5Tancp7W66ZA-tToQbsE_4bbcB8oIGO1RIHhIDcGTXyAHX-aPuANlbN1FH50uAxXL1VlNFHwSXO2s_M=@emersion.fr> In-Reply-To: <20230615094206.4424-2-tzimmermann@suse.de> References: <20230615094206.4424-1-tzimmermann@suse.de> <20230615094206.4424-2-tzimmermann@suse.de> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mripard@kernel.org, linux-graphics-maintainer@vmware.com, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thursday, June 15th, 2023 at 11:31, Thomas Zimmermann wrote: > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 89e2706cac561..10af1899236a0 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -309,6 +309,9 @@ struct drm_driver { > =09 * > =09 * For an in-depth discussion see :ref:`PRIME buffer sharing > =09 * documentation `. > +=09 * > +=09 * TODO: Convert remaining drivers to drm_gem_prime_handle_to_fd() > +=09 * and remove this callback. > =09 */ The docs right above still state: "Should be implemented with drm_gem_prime_handle_to_fd() for GEM based drivers". Maybe we can replace t= hat and state that leaving this NULL will use a default implementation? > =09int (*prime_handle_to_fd)(struct drm_device *dev, struct drm_file *fi= le_priv, > =09=09=09=09uint32_t handle, uint32_t flags, int *prime_fd); > @@ -320,6 +323,9 @@ struct drm_driver { > =09 * > =09 * For an in-depth discussion see :ref:`PRIME buffer sharing > =09 * documentation `. > +=09 * > +=09 * TODO: Convert remaining drivers to drm_gem_prime_fd_to_handle() > +=09 * and remove this callback. > =09 */ Ditto. > =09int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *fi= le_priv, > =09=09=09=09int prime_fd, uint32_t *handle); > -- > 2.41.0