Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org, kernel@collabora.com,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Steven Price" <steven.price@arm.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.com>,
	"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Sean Paul" <sean@poorly.run>,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	linux-kernel@vger.kernel.org, "Qiang Yu" <yuq825@gmail.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers
Date: Mon, 30 Jan 2023 15:02:10 +0300	[thread overview]
Message-ID: <0081b2c3-56c9-3ed8-b419-5ce8a151999e@collabora.com> (raw)
In-Reply-To: <20230127081339.yovxofpboc4gfdgo@sirius.home.kraxel.org>

On 1/27/23 11:13, Gerd Hoffmann wrote:
> On Thu, Jan 26, 2023 at 01:55:09AM +0300, Dmitry Osipenko wrote:
>> Hello Thomas and Gerd,
>>
>> On 1/9/23 00:04, Dmitry Osipenko wrote:
>>> This series:
>>>
>>>   1. Makes minor fixes for drm_gem_lru and Panfrost
>>>   2. Brings refactoring for older code
>>>   3. Adds common drm-shmem memory shrinker
>>>   4. Enables shrinker for VirtIO-GPU driver
>>>   5. Switches Panfrost driver to the common shrinker
>>>
>>> Changelog:
>>>
>>> v10:- Rebased on a recent linux-next.
>>>
>>>     - Added Rob's ack to MSM "Prevent blocking within shrinker loop" patch.
>>>
>>>     - Added Steven's ack/r-b/t-b for the Panfrost patches.
>>>
>>>     - Fixed missing export of the new drm_gem_object_evict() function.
>>>
>>>     - Added fixes tags to the first two patches that are making minor fixes,
>>>       for consistency.
>>
>> Do you have comments on this version? Otherwise ack will be appreciated.
>> Thanks in advance!
> 
> Don't feel like signing off on the locking changes, I'm not that
> familiar with the drm locking rules.  So someone else looking at them
> would be good.  Otherwise the series and specifically the virtio changes
> look good to me.
> 
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>

Thomas was looking at the the DRM core changes. I expect he'll ack them.

Thank you for reviewing the virtio patches!

-- 
Best regards,
Dmitry