From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B473AC4338F for ; Fri, 30 Jul 2021 12:31:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 436C2604D7 for ; Fri, 30 Jul 2021 12:31:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 436C2604D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFAFD6E214; Fri, 30 Jul 2021 12:31:58 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id C06716E214 for ; Fri, 30 Jul 2021 12:31:57 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9RgA-0001JJ-Uj; Fri, 30 Jul 2021 14:31:54 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1m9Rg9-0007mm-Hz; Fri, 30 Jul 2021 14:31:53 +0200 Message-ID: <048851b26d012069ecaf52286ec48d2b4e38571d.camel@pengutronix.de> Subject: Re: [PATCH 3/7] drm/imx/dcss: Enable COMPILE_TEST on all ARM64 platforms From: Philipp Zabel To: Geert Uytterhoeven , Laurent Pinchart Date: Fri, 30 Jul 2021 14:31:53 +0200 In-Reply-To: References: <20210728153736.15240-1-laurent.pinchart+renesas@ideasonboard.com> <20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Sascha Hauer , Jyri Sarha , DRI Development , Jonathan Hunter , Linux-Renesas , Thierry Reding , NXP Linux Team , Laurentiu Palcu , linux-tegra , Shawn Guo Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 2021-07-30 at 14:10 +0200, Geert Uytterhoeven wrote: > Hi Laurent, >=20 > On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart > wrote: > > To extend test coverage, relax the dependency on ARCH_MXC to also enabl= e > > compilation when COMPILE_TEST is selected. > >=20 > > Signed-off-by: Laurent Pinchart >=20 > Thanks for your patch! >=20 > > --- a/drivers/gpu/drm/imx/dcss/Kconfig > > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > > @@ -3,7 +3,8 @@ config DRM_IMX_DCSS > > select IMX_IRQSTEER > > select DRM_KMS_CMA_HELPER > > select VIDEOMODE_HELPERS > > - depends on DRM && ARCH_MXC && ARM64 > > + depends on DRM > > + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) >=20 > As you now have two depends statements, I think this would be easier > to read by maintaining a strict separation between "hard" and "soft" > dependencies: >=20 > depends on DRM && ARM64 > depends on ARCH_MXC || COMPILE_TEST I would let (ARCH_MXC && ARM64) stay together, and as Tomi suggested, lift the ARM64 limitation if COMPILE_TEST is enabled: depends on DRM depends on (ARCH_MXC && ARM64) || COMPILE_TEST regards Philipp