From: Luben Tuikov <luben.tuikov@amd.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Intel Graphics" <intel-gfx@lists.freedesktop.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/sched: Add missing structure comment
Date: Wed, 9 Dec 2020 17:28:43 -0500 [thread overview]
Message-ID: <05188f00-9dc9-74d8-ca10-dd2219c83ed0@amd.com> (raw)
In-Reply-To: <20201210092435.253b12aa@canb.auug.org.au>
On 2020-12-09 5:24 p.m., Stephen Rothwell wrote:
> Hi Luben,
>
> On Wed, 9 Dec 2020 16:58:07 -0500 Luben Tuikov <luben.tuikov@amd.com> wrote:
>>
>> Add a missing structure comment for the recently
>> added @list member.
>>
>> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
>>
>> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Christian König <christian.koenig@amd.com>
>
> The commit message tags should all be together at the end of the commit
> message (probably with your SoB last). Also:
>
> Fixes: 8935ff00e3b1 ("drm/scheduler: "node" --> "list"")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Right! I was just looking into this as the empty
line up there didn't look good.
I'll resubmit.
Regards,
Luben
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-09 22:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 10:02 linux-next: build warning after merge of the drm-misc tree Stephen Rothwell
2020-12-09 16:10 ` Luben Tuikov
2020-12-09 21:58 ` [PATCH] drm/sched: Add missing structure comment Luben Tuikov
2020-12-09 22:24 ` Stephen Rothwell
2020-12-09 22:28 ` Luben Tuikov [this message]
2020-12-09 22:31 ` Luben Tuikov
2020-12-10 12:24 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05188f00-9dc9-74d8-ca10-dd2219c83ed0@amd.com \
--to=luben.tuikov@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).