From: Thorsten Leemhuis <firstname.lastname@example.org> To: "Christian König" <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Cc: email@example.com, firstname.lastname@example.org Subject: Re: [Nouveau] [PATCH] drm/nouveau: wait for the exclusive fence after the shared ones v2 Date: Fri, 10 Dec 2021 10:06:15 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Hi, this is your Linux kernel regression tracker speaking. On 09.12.21 11:23, Christian König wrote: > Always waiting for the exclusive fence resulted on some performance > regressions. So try to wait for the shared fences first, then the > exclusive fence should always be signaled already. > > v2: fix incorrectly placed "(", add some comment why we do this. > > Signed-off-by: Christian König <email@example.com> FWIW: In case you need to send an improved patch, could you please add this (see (¹) below for the reasoning): Link: https://firstname.lastname@example.org/ And if the patch is already good to go: could the subsystem maintainer please add it when applying? See (¹) for the reasoning. BTW, these two lines afaics are missing as well: Fixes: 3e1ad79bf661 ("drm/nouveau: always wait for the exclusive fence") Reported-by: Stefan Fritsch <email@example.com> Ciao, Thorsten (¹) Long story: The commit message would benefit from a link to the regression report, for reasons explained in Documentation/process/submitting-patches.rst. To quote: ``` If related discussions or any other background information behind the change can be found on the web, add 'Link:' tags pointing to it. In case your patch fixes a bug, for example, add a tag with a URL referencing the report in the mailing list archives or a bug tracker; ``` This concept is old, but the text was reworked recently to make this use case for the Link: tag clearer. For details see: https://git.kernel.org/linus/1f57bd42b77c Yes, that "Link:" is not really crucial; but it's good to have if someone needs to look into the backstory of this change sometime in the future. But I care for a different reason. I'm tracking this regression (and others) with regzbot, my Linux kernel regression tracking bot. This bot will notice if a patch with a Link: tag to a tracked regression gets posted and record that, which allowed anyone looking into the regression to quickly gasp the current status from regzbot's webui (https://linux-regtracking.leemhuis.info/regzbot ) or its reports. The bot will also notice if a commit with a Link: tag to a regression report is applied by Linus and then automatically mark the regression as resolved then. IOW: this tag makes my life a regression tracker a lot easier, as I otherwise have to tell regzbot manually when the fix lands. :-/ #regzbot ^backmonitor: https://firstname.lastname@example.org/
next prev parent reply other threads:[~2021-12-10 9:06 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-09 10:23 Christian König 2021-12-10 9:06 ` Thorsten Leemhuis [this message] 2021-12-11 9:59 ` Stefan Fritsch 2021-12-14 9:19 ` Christian König 2021-12-15 22:32 ` [Nouveau] " Ben Skeggs 2021-12-21 10:11 ` Thorsten Leemhuis 2021-12-21 10:20 ` Christian König 2021-12-20 19:17 ` Dan Moulding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [Nouveau] [PATCH] drm/nouveau: wait for the exclusive fence after the shared ones v2' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).