From: Tom Rix <trix@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-hyperv@vger.kernel.org, kvm@vger.kernel.org,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net, keyrings@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org,
clang-built-linux@googlegroups.com,
amd-gfx@lists.freedesktop.org, cluster-devel@redhat.com,
linux-acpi@vger.kernel.org, tboot-devel@lists.sourceforge.net,
coreteam@netfilter.org, xen-devel@lists.xenproject.org,
MPT-FusionLinux.pdl@broadcom.com, linux-media@vger.kernel.org,
alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-omap@vger.kernel.org, devel@acpica.org,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org,
patches@opensource.cirrus.com, joe@perches.com,
bpf@vger.kernel.org
Subject: Re: [RFC] MAINTAINERS tag for cleanup robot
Date: Sun, 22 Nov 2020 08:10:53 -0800 [thread overview]
Message-ID: <0819ce06-c462-d4df-d3d9-14931dc5aefc@redhat.com> (raw)
In-Reply-To: <20201122145635.GG4327@casper.infradead.org>
On 11/22/20 6:56 AM, Matthew Wilcox wrote:
> On Sun, Nov 22, 2020 at 06:46:46AM -0800, Tom Rix wrote:
>> On 11/21/20 7:23 PM, Matthew Wilcox wrote:
>>> On Sat, Nov 21, 2020 at 08:50:58AM -0800, trix@redhat.com wrote:
>>>> The fixer review is
>>>> https://reviews.llvm.org/D91789
>>>>
>>>> A run over allyesconfig for x86_64 finds 62 issues, 5 are false positives.
>>>> The false positives are caused by macros passed to other macros and by
>>>> some macro expansions that did not have an extra semicolon.
>>>>
>>>> This cleans up about 1,000 of the current 10,000 -Wextra-semi-stmt
>>>> warnings in linux-next.
>>> Are any of them not false-positives? It's all very well to enable
>>> stricter warnings, but if they don't fix any bugs, they're just churn.
>>>
>> While enabling additional warnings may be a side effect of this effort
>>
>> the primary goal is to set up a cleaning robot. After that a refactoring robot.
> Why do we need such a thing? Again, it sounds like more churn.
> It's really annoying when I'm working on something important that gets
> derailed by pointless churn. Churn also makes it harder to backport
> patches to earlier kernels.
>
A refactoring example on moving to treewide, consistent use of a new api may help.
Consider
2efc459d06f1630001e3984854848a5647086232
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
A new api for printing in the sysfs. How do we use it treewide ?
Done manually, it would be a heroic effort requiring high level maintainers pushing and likely only get partially done.
If a refactoring programatic fixit is done and validated on a one subsystem, it can run on all the subsystems.
The effort is a couple of weeks to write and validate the fixer, hours to run over the tree.
It won't be perfect but will be better than doing it manually.
Tom
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-22 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 16:50 [RFC] MAINTAINERS tag for cleanup robot trix
2020-11-21 17:10 ` Joe Perches
2020-11-22 16:33 ` Tom Rix
2020-11-22 18:22 ` Joe Perches
2020-11-23 17:06 ` Tom Rix
2020-11-21 17:18 ` James Bottomley
2020-11-21 18:02 ` Joe Perches
2020-11-23 15:52 ` Jani Nikula
2020-11-23 16:17 ` Lukas Bulwahn
[not found] ` <20201122032304.GE4327@casper.infradead.org>
2020-11-22 14:46 ` Tom Rix
[not found] ` <20201122145635.GG4327@casper.infradead.org>
2020-11-22 16:10 ` Tom Rix [this message]
2020-11-22 16:49 ` James Bottomley
2020-11-22 18:23 ` Joe Perches
[not found] ` <alpine.LNX.2.23.453.2011230810210.7@nippy.intranet>
2020-11-23 0:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0819ce06-c462-d4df-d3d9-14931dc5aefc@redhat.com \
--to=trix@redhat.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=cluster-devel@redhat.com \
--cc=coreteam@netfilter.org \
--cc=devel@acpica.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecryptfs@vger.kernel.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=keyrings@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tboot-devel@lists.sourceforge.net \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).