From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: yu kuai <yukuai3@huawei.com>
Cc: zhengbin13@huawei.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
yi.zhang@huawei.com
Subject: Re: [PATCH] video: remove set but not used variable 'ulScaleRight'
Date: Mon, 2 Mar 2020 16:42:34 +0100 [thread overview]
Message-ID: <0b16ece5-a95c-5420-b5d4-7c576171780f@samsung.com> (raw)
In-Reply-To: <20200119121945.12517-1-yukuai3@huawei.com>
On 1/19/20 1:19 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/kyro/STG4000OverlayDevice.c: In function
> ‘SetOverlayViewPort’:
> drivers/video/fbdev/kyro/STG4000OverlayDevice.c:334:19: warning:
> variable ‘ulScaleRight’ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
> index 0aeeaa10708b..9fde0e3b69ec 100644
> --- a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
> +++ b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
> @@ -331,7 +331,7 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg,
> u32 ulScale;
> u32 ulLeft, ulRight;
> u32 ulSrcLeft, ulSrcRight;
> - u32 ulScaleLeft, ulScaleRight;
> + u32 ulScaleLeft;
> u32 ulhDecim;
> u32 ulsVal;
> u32 ulVertDecFactor;
> @@ -470,7 +470,6 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg,
> * round down the pixel pos to the nearest 8 pixels.
> */
> ulScaleLeft = ulSrcLeft;
> - ulScaleRight = ulSrcRight;
>
> /* shift fxscale until it is in the range of the scaler */
> ulhDecim = 0;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-03-02 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200119122043eucas1p2b450cd177ca0d86d268323a074c82b05@eucas1p2.samsung.com>
2020-01-19 12:19 ` [PATCH] video: remove set but not used variable 'ulScaleRight' yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b16ece5-a95c-5420-b5d4-7c576171780f@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).