From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Torsten Duwe <duwe@lst.de>,
Maxime Ripard <maxime@cerno.tech>,
Icenowy Zheng <icenowy@aosc.io>, Sam Ravnborg <sam@ravnborg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Samuel Holland <samuel@sholland.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>
Subject: Re: [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector
Date: Mon, 30 Mar 2020 01:29:42 +0200 [thread overview]
Message-ID: <11490050.O9o76ZdvQC@jernej-laptop> (raw)
In-Reply-To: <20200329222253.2941405-1-anarsoul@gmail.com>
Hi!
Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick
napisal(a):
> Some drivers (e.g. sun4i-drm) need this info to decide whether they
> need to enable dithering. Currently driver reports what panel supports
> and if panel supports 8 we don't get dithering enabled.
>
> Hardcode BPC to 6 for now since that's the only BPC
> that driver supports.
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index
> d7cb10c599a3..ea5de9395662 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector
> *connector)
>
> num_modes += drm_add_edid_modes(connector, anx6345->edid);
>
> + /* Driver currently supports only 6bpc */
> + connector->display_info.bpc = 6;
> +
> unlock:
> if (power_off)
> anx6345_poweroff(anx6345);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-30 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 22:22 [PATCH] drm/bridge: anx6345: set correct BPC for display_info of connector Vasily Khoruzhick
2020-03-29 23:29 ` Jernej Škrabec [this message]
2020-04-14 17:53 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11490050.O9o76ZdvQC@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=duwe@lst.de \
--cc=icenowy@aosc.io \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).