From: Harry Wentland <hwentlan@amd.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
intel-gfx@lists.freedesktop.org, Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio
Date: Thu, 14 Nov 2019 16:23:41 -0500 [thread overview]
Message-ID: <129b52ff-6931-bd27-c2e0-6e17767d8fdd@amd.com> (raw)
In-Reply-To: <20191114204413.457504-1-chris@chris-wilson.co.uk>
On 2019-11-14 3:44 p.m., Chris Wilson wrote:
> An old display with no audio may not have an EDID with a CEA block, or
> it may simply be too old to support audio. This is not a driver error,
> so don't flag it as such.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112140
> References: ae2a3495973e ("drm/amd: be quiet when no SAD block is found")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 11e5784aa62a..04808dbecab3 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -97,8 +97,6 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
> (struct edid *) edid->raw_edid);
>
> sad_count = drm_edid_to_sad((struct edid *) edid->raw_edid, &sads);
> - if (sad_count < 0)
> - DRM_ERROR("Couldn't read SADs: %d\n", sad_count);
> if (sad_count <= 0)
> return result;
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-14 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 20:44 [PATCH] drm/amdgpu/dm: Do not throw an error for a display with no audio Chris Wilson
2019-11-14 20:44 ` Chris Wilson
2019-11-14 21:23 ` Harry Wentland [this message]
2019-11-14 21:47 ` Alex Deucher
2019-11-14 21:47 ` Alex Deucher
2019-11-15 9:04 ` Jean Delvare
2019-11-15 9:04 ` Jean Delvare
2019-11-15 9:18 ` Daniel Vetter
2019-11-15 9:18 ` [Intel-gfx] " Daniel Vetter
2019-11-15 19:27 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129b52ff-6931-bd27-c2e0-6e17767d8fdd@amd.com \
--to=hwentlan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jdelvare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).