From: Felix Kuehling <felix.kuehling@amd.com>
To: Joe Perches <joe@perches.com>
Cc: "David Airlie" <airlied@linux.ie>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH -next 023/491] AMD KFD: Use fallthrough;
Date: Wed, 11 Mar 2020 17:50:01 -0400 [thread overview]
Message-ID: <12c75b17-1d0e-6cc4-4ed1-a6f5003772ae@amd.com> (raw)
In-Reply-To: <3cfc40c8f750abc672d6a60418fe220cb663a0f5.1583896349.git.joe@perches.com>
On 2020-03-11 12:51 a.m., Joe Perches wrote:
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
The link seems to be broken. This one works:
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> index d6549e..6529ca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> @@ -79,7 +79,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
> dev_warn(adev->dev,
> "Invalid sdma engine id (%d), using engine id 0\n",
> engine_id);
> - /* fall through */
> + fallthrough;
> case 0:
> sdma_engine_reg_base = SOC15_REG_OFFSET(SDMA0, 0,
> mmSDMA0_RLC0_RB_CNTL) - mmSDMA0_RLC0_RB_CNTL;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-11 21:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 4:51 [PATCH -next 000/491] treewide: use fallthrough; Joe Perches
2020-03-11 4:51 ` [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; Joe Perches
2020-03-11 7:40 ` Miquel Raynal
2020-03-11 14:20 ` Ulf Hansson
2020-03-11 14:29 ` Miquel Raynal
2020-03-12 6:26 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: " Joe Perches
2020-03-11 11:00 ` Wei Liu
2020-03-11 4:51 ` [PATCH -next 023/491] AMD KFD: " Joe Perches
2020-03-11 21:50 ` Felix Kuehling [this message]
2020-03-11 22:09 ` Joe Perches
2020-03-12 14:12 ` Alex Deucher
2020-03-11 4:51 ` [PATCH -next 024/491] AMD DISPLAY CORE: " Joe Perches
2020-03-12 14:10 ` Alex Deucher
2020-03-11 4:51 ` [PATCH -next 025/491] AMD POWERPLAY: " Joe Perches
2020-03-12 14:10 ` Alex Deucher
2020-03-11 4:51 ` [PATCH -next 026/491] INTEL GVT-g DRIVERS (Intel GPU Virtualization): " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c75b17-1d0e-6cc4-4ed1-a6f5003772ae@amd.com \
--to=felix.kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).