From: John Hunter <zhjwpku@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 3/8] drm/bochs: stop looking at legacy state
Date: Thu, 16 Jul 2015 20:20:36 +0800 [thread overview]
Message-ID: <1437049241-11972-4-git-send-email-zhjwpku@gmail.com> (raw)
In-Reply-To: <1437049241-11972-1-git-send-email-zhjwpku@gmail.com>
From: Zhao Junwang <zhjwpku@gmail.com>
with transitional helpers we've used the new callbacks, but control
flow was still old, but with atomic first step is to call atomic_check,
then prepare_fb, and so on, by this time, we can not look at any legacy
state like plane->fb or crtc->enabled, because they are updated at the
very end.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
---
drivers/gpu/drm/bochs/bochs_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
index a14bac4..e5fa125 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -123,10 +123,10 @@ static int bochs_plane_prepare_fb(struct drm_plane *plane,
struct bochs_bo *bo;
int ret;
- if (WARN_ON(plane->fb == NULL))
+ if (WARN_ON(fb == NULL))
return -EINVAL;
- bochs_fb = to_bochs_framebuffer(plane->fb);
+ bochs_fb = to_bochs_framebuffer(fb);
bo = gem_to_bochs_bo(bochs_fb->obj);
ttm_bo_reserve(&bo->bo, true, false, false, NULL);
--
1.7.10.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-16 12:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:20 [PATCH 0/8] drm/bochs: convert bochs to atomic mode-setting John Hunter
2015-07-16 12:20 ` [PATCH 1/8] drm/bochs: phase 1 - use the transitional helpers John Hunter
2015-07-16 15:49 ` Gerd Hoffmann
2015-07-16 18:22 ` Daniel Vetter
2015-07-16 12:20 ` [PATCH 2/8] drm/bochs: phase 2: wire up state reset(), duplicate() and destroy John Hunter
2015-07-16 12:20 ` John Hunter [this message]
2015-07-16 12:20 ` [PATCH 4/8] drm/bochs: phase 3: for plane updates: switch to atomic helper internally John Hunter
2015-07-16 12:20 ` [PATCH 5/8] drm/bochs: phase 3: use atomic .set_config helper John Hunter
2015-07-16 12:20 ` [PATCH 6/8] drm/bochs: phase 3: provide a custom ->atomic_commit implementation John Hunter
2015-07-17 6:08 ` Pekka Paalanen
2015-07-19 23:56 ` John Hunter
2015-07-20 0:20 ` Stéphane Marchesin
2015-07-20 7:46 ` Pekka Paalanen
2015-07-20 8:58 ` Stéphane Marchesin
2015-07-20 9:35 ` KMS timings (Re: [PATCH 6/8] drm/bochs: phase 3: provide a custom ->atomic_commit implementation) Pekka Paalanen
2015-07-20 14:21 ` Daniel Vetter
2015-07-20 17:32 ` Stéphane Marchesin
2015-07-21 7:06 ` Pekka Paalanen
2015-07-21 9:02 ` Daniel Vetter
2015-07-21 11:22 ` Pekka Paalanen
2015-07-21 13:47 ` Daniel Vetter
2015-07-16 12:20 ` [PATCH 7/8] drm/bochs: phase 3: switch to drm_atomic_helper_page_flip John Hunter
2015-07-16 12:20 ` [PATCH 8/8] drm/bochs: atomic dpms support John Hunter
2016-03-02 10:13 ` [PATCH 0/8] drm/bochs: convert bochs to atomic mode-setting Emil Velikov
2016-03-02 15:38 ` Gerd Hoffmann
2016-03-02 18:02 ` Emil Velikov
2016-03-03 9:28 ` Gerd Hoffmann
2016-03-04 8:31 ` John Hunter
2016-03-04 14:05 ` Emil Velikov
2016-03-07 9:34 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437049241-11972-4-git-send-email-zhjwpku@gmail.com \
--to=zhjwpku@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).