From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Mikko Perttunen <cyndis@kapsi.fi>,
dri-devel@lists.freedesktop.org,
Nicolas Chauvet <kwizart@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Peter Geis <pgwipeout@gmail.com>,
linux-tegra@vger.kernel.org,
Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH v9 07/17] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree
Date: Fri, 20 Nov 2020 00:04:11 +0300 [thread overview]
Message-ID: <150be162-cb1a-4e30-8937-e99cd1c4255b@gmail.com> (raw)
In-Reply-To: <20201118042117.q6nkwm7exakgfvu3@vireshk-i7>
18.11.2020 07:21, Viresh Kumar пишет:
...
>>>> + /* legacy device-trees don't have OPP table and must be updated */
>>>> + if (!device_property_present(&pdev->dev, "operating-points-v2")) {
>>>> + dev_err(&pdev->dev,
>>>> + "OPP table not found, please update your device tree\n");
>>>> + return -ENODEV;
>>>> + }
>>>> +
>>>
>>> You forgot to remove this ?
>>
>> Yes, good catch. I'm planning to replace this code with a common helper
>> sometime soon, so if there won't be another reasons to make a new
>> revision, then I'd prefer to keep it as-is for now.
>
> You should just replace this patch only with a version of V9.1 and you
> aren't really required to resend the whole series. And you should fix
> it before it gets merged. This isn't a formatting issue which we just
> let through. I trust you when you say that you will fix it, but this
> must be fixed now.
>
Should be easier to resend it all. I'll update it over the weekend, thanks.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-20 8:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 21:29 [PATCH v9 00/17] Introduce memory interconnect for NVIDIA Tegra SoCs Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 01/17] memory: tegra30: Support interconnect framework Dmitry Osipenko
2020-11-17 20:24 ` Georgi Djakov
2020-11-17 22:02 ` Dmitry Osipenko
2020-11-18 15:30 ` Georgi Djakov
2020-11-19 12:07 ` Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 02/17] memory: tegra124-emc: Make driver modular Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 03/17] memory: tegra124-emc: Continue probing if timings are missing in device-tree Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 04/17] memory: tegra124: Support interconnect framework Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 05/17] drm/tegra: dc: Support memory bandwidth management Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 06/17] drm/tegra: dc: Extend debug stats with total number of events Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 07/17] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree Dmitry Osipenko
2020-11-17 10:07 ` Viresh Kumar
2020-11-17 14:17 ` Dmitry Osipenko
2020-11-18 4:21 ` Viresh Kumar
2020-11-19 21:04 ` Dmitry Osipenko [this message]
2020-11-15 21:29 ` [PATCH v9 08/17] PM / devfreq: tegra30: Separate configurations per-SoC generation Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 09/17] PM / devfreq: tegra20: Deprecate in a favor of emc-stat based driver Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 10/17] ARM: tegra: Correct EMC registers size in Tegra20 device-tree Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 11/17] ARM: tegra: Add interconnect properties to " Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 12/17] ARM: tegra: Add interconnect properties to Tegra30 device-tree Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 13/17] ARM: tegra: Add interconnect properties to Tegra124 device-tree Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 14/17] ARM: tegra: Add nvidia, memory-controller phandle to Tegra20 EMC device-tree Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 15/17] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 16/17] ARM: tegra: Add EMC OPP and ICC properties to Tegra30 EMC and ACTMON device-tree nodes Dmitry Osipenko
2020-11-15 21:29 ` [PATCH v9 17/17] ARM: tegra: Add EMC OPP and ICC properties to Tegra124 " Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150be162-cb1a-4e30-8937-e99cd1c4255b@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=cyndis@kapsi.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=kwizart@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).