From: Lucas Stach <l.stach@pengutronix.de>
To: Laurentiu Palcu <laurentiu.palcu@nxp.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org, agx@sigxcpu.org,
lukas@mntmn.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ
Date: Mon, 24 Feb 2020 18:27:25 +0100 [thread overview]
Message-ID: <1515559adebe3a6206e9b8e84692b7818709890b.camel@pengutronix.de> (raw)
In-Reply-To: <1575625964-27102-3-git-send-email-laurentiu.palcu@nxp.com>
Hi Laurentiu,
just a first drive-by comment, more in-depth review tomorrow.
On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote:
> This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS).
> Some of its capabilities include:
> * 4K@60fps;
> * HDR10;
> * one graphics and 2 video pipelines;
> * on-the-fly decompression of compressed video and graphics;
>
> The reference manual can be found here:
> https://www.nxp.com/webapp/Download?colCode=IMX8MDQLQRM
>
> The current patch adds only basic functionality: one primary plane for
> graphics, linear, tiled and super-tiled buffers support (no graphics
> decompression yet), no HDR10 and no video planes.
>
> Video planes support and HDR10 will be added in subsequent patches once
> per-plane de-gamma/CSC/gamma support is in.
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
> ---
[...]
> diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
> new file mode 100644
> index 00000000..a189dac
> --- /dev/null
> +++ b/drivers/gpu/drm/imx/dcss/Kconfig
> @@ -0,0 +1,8 @@
> +config DRM_IMX_DCSS
> + tristate "i.MX8MQ DCSS"
> + select RESET_CONTROLLER
> + select IMX_IRQSTEER
This driver has no build time dependency on the IRQSTEER driver. It
needs it at runtime, but those dependencies are normally not described
in Kconfig.
On the other hand this is missing a "select DRM_KMS_CMA_HELPER".
Regards,
Lucas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-24 17:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 9:52 [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Laurentiu Palcu
2019-12-06 9:52 ` [PATCH v3 1/4] drm/imx: compile imx directory by default Laurentiu Palcu
2019-12-06 9:52 ` [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ Laurentiu Palcu
2020-02-24 17:27 ` Lucas Stach [this message]
2020-02-26 7:52 ` Laurentiu Palcu
2020-02-26 13:19 ` Lucas Stach
2020-03-06 9:58 ` Laurentiu Palcu
2020-03-06 10:20 ` Philipp Zabel
2020-03-06 11:12 ` Laurentiu Palcu
2019-12-06 9:52 ` [PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS Laurentiu Palcu
2020-02-24 17:21 ` Lucas Stach
2020-02-26 7:58 ` Laurentiu Palcu
2020-02-27 11:52 ` Philipp Zabel
2019-12-11 20:16 ` [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Lukas Hartmann
2020-02-21 12:15 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515559adebe3a6206e9b8e84692b7818709890b.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=agx@sigxcpu.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=laurentiu.palcu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@mntmn.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).