From: YT Shen <yt.shen@mediatek.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>,
chunhui dai <chunhui.dai@mediatek.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 4/4] drm/mediatek: fix possible_crtcs
Date: Mon, 22 Apr 2019 16:59:19 +0800 [thread overview]
Message-ID: <1555923559.2854.14.camel@mtksdaap41> (raw)
In-Reply-To: <20190416145848.11932-5-frank-w@public-files.de>
Hi Frank,
On Tue, 2019-04-16 at 16:58 +0200, Frank Wunderlich wrote:
> From: Ryder Lee <ryder.lee@mediatek.com>
>
> without this patch there is purple stretched font on fbconsole
>
> source: http://forum.banana-pi.org/t/kernel-4-19-rc1-for-testers/6618/52
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 5d333138f913..c171b01f77e0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -610,7 +610,7 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data)
> drm_encoder_helper_add(&dpi->encoder, &mtk_dpi_encoder_helper_funcs);
>
> /* Currently DPI0 is fixed to be driven by OVL1 */
> - dpi->encoder.possible_crtcs = BIT(1);
> + dpi->encoder.possible_crtcs = BIT(0)|BIT(1);
This patch is not a good solution.
The solution should find the components in the arrays to determine the
correct crtcs, not just set all available bits. You see the problem
because the hardware connections(BIT0) is not the same as driver
reports(BIT1 changed to BIT0|BIT1, but BIT1 is not supported).
Regards,
yt.shen
>
> ret = drm_bridge_attach(&dpi->encoder, dpi->bridge, NULL);
> if (ret) {
> --
> 2.17.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-22 8:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 14:58 [PATCH v1 0/4] make hdmi work on bananapi-r2 Frank Wunderlich
2019-04-16 14:58 ` [PATCH v1 1/4] drm/mediatek: config component output by device node port Frank Wunderlich
2019-04-16 14:58 ` [PATCH v1 2/4] arm: dts: mt7623: add display subsystem related device nodes Frank Wunderlich
2020-05-21 14:09 ` Matthias Brugger
2019-04-16 14:58 ` [PATCH v1 3/4] drm/mediatek: fix boot up for 720 and 480 but 1080 Frank Wunderlich
2019-04-17 5:47 ` CK Hu
2019-04-16 14:58 ` [PATCH v1 4/4] drm/mediatek: fix possible_crtcs Frank Wunderlich
2019-04-22 8:59 ` YT Shen [this message]
2019-04-17 3:10 ` [PATCH v1 0/4] make hdmi work on bananapi-r2 CK Hu
2019-04-17 5:30 ` Aw: " Frank Wunderlich
2019-04-17 5:40 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555923559.2854.14.camel@mtksdaap41 \
--to=yt.shen@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunhui.dai@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank-w@public-files.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).