From: Lucas Stach <l.stach@pengutronix.de>
To: "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"patchwork-lst@pengutronix.de" <patchwork-lst@pengutronix.de>
Subject: Re: [PATCH] drm/scheduler: put killed job cleanup to worker
Date: Wed, 03 Jul 2019 16:53:59 +0200 [thread overview]
Message-ID: <1562165639.2321.16.camel@pengutronix.de> (raw)
In-Reply-To: <186e567c-81e7-e874-2dae-4c4495bce224@amd.com>
Am Mittwoch, den 03.07.2019, 14:41 +0000 schrieb Grodzovsky, Andrey:
> On 7/3/19 10:32 AM, Lucas Stach wrote:
> > Am Mittwoch, den 03.07.2019, 14:23 +0000 schrieb Grodzovsky, Andrey:
> > > On 7/3/19 6:28 AM, Lucas Stach wrote:
> > > > drm_sched_entity_kill_jobs_cb() is called right from the last scheduled
> > > > job finished fence signaling. As this might happen from IRQ context we
> > > > now end up calling the GPU driver free_job callback in IRQ context, while
> > > > all other paths call it from normal process context.
> > > >
> > > > Etnaviv in particular calls core kernel functions that are only valid to
> > > > be called from process context when freeing the job. Other drivers might
> > > > have similar issues, but I did not validate this. Fix this by punting
> > > > the cleanup work into a work item, so the driver expectations are met.
> > > >
> > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > >
> > > > ---
[...]
> > > I rechecked the latest code and finish_work was removed in ffae3e5
> > > 'drm/scheduler: rework job destruction'
> >
> > Aw, thanks. Seems this patch was stuck for a bit too long in my
> > outgoing queue. I've just checked the commit you pointed out, it should
> > also fix the issue that this patch was trying to fix.
>
>
> Not sure about this as you patch only concerns use case when cleaning
> unfinished job's for entity being destroyed.
AFAICS after ffae3e5 all the free_job invocations are done from process
context, so things should work for etnaviv.
Regards,
Lucas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-03 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 10:28 [PATCH] drm/scheduler: put killed job cleanup to worker Lucas Stach
2019-07-03 14:23 ` Grodzovsky, Andrey
2019-07-03 14:32 ` Lucas Stach
2019-07-03 14:41 ` Grodzovsky, Andrey
2019-07-03 14:53 ` Lucas Stach [this message]
2019-07-03 15:00 ` Grodzovsky, Andrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562165639.2321.16.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=Andrey.Grodzovsky@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).