From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH 3/8] drm/mediatek: don't open-code drm_gem_fb_create Date: Fri, 22 Nov 2019 15:42:39 +0800 Message-ID: <1574408559.21408.2.camel@mtksdaap41> References: <20191115092120.4445-1-daniel.vetter@ffwll.ch> <20191115092120.4445-4-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id 052976F4D8 for ; Fri, 22 Nov 2019 07:42:48 +0000 (UTC) In-Reply-To: <20191115092120.4445-4-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Intel Graphics Development , DRI Development , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGksIERhbmllbDoNCg0KT24gRnJpLCAyMDE5LTExLTE1IGF0IDEwOjIxICswMTAwLCBEYW5pZWwg VmV0dGVyIHdyb3RlOg0KPiBBc2lkZTogVGhlcmUncyBhIGZldyBvdGhlciBmYl9jcmVhdGUgaW1w bGVtZW50YXRpb25zIHdoaWNoDQo+IHNpbXBseSBjaGVjayBmb3IgdmFsaWQgYnVmZmVyIGZvcm1h dCAob3IgYW4gYXBwcm94aW1hdGlvbiB0aGVyZW9mKSwNCj4gYW5kIHRoZW4gY2FsbCBkcm1fZ2Vt X2ZiX2NyZWF0ZS4gRm9yIGF0b21pYyBkcml2ZXJzIGF0IGxlYXN0IHdlIGNvdWxkDQo+IHdhbGsg YWxsIHBsYW5lcyBhbmQgbWFrZSBzdXJlIHRoZSBmb3JtYXQvbW9kaWZpZXIgY29tYm8gaXMgdmFs aWQsDQo+IGFuZCByZW1vdmUgZXZlbiBtb3JlIGNvZGUuDQo+IA0KPiBGb3Igbm9uLWF0b21pYyBk cml2ZXJzIHRoYXQncyBub3QgcG9zc2libGUsIHNpbmNlIHRoZSBmb3JtYXQgbGlzdCBmb3INCj4g dGhlIHByaW1hcnkgYnVmZmVyIG1pZ2h0IGJlIGdhcmJhZ2UgKGFuZCBtb3N0IGxpa2VseSBpdCBp cykuDQo+IA0KPiBBbHNvIGRlbGV0ZSBtdGtfZHJtX2ZiLltoY10gc2luY2UgaXQgd291bGQgbm93 IG9ubHkgY29udGFpbiBvbmUNCj4gZnVuY3Rpb24uDQoNCkFja2VkLWJ5OiBDSyBIdSA8Y2suaHVA bWVkaWF0ZWsuY29tPg0KDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGZmd2xsLmNoPg0KPiBDYzogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4NCj4g Q2M6IFBoaWxpcHAgWmFiZWwgPHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+DQo+IENjOiBNYXR0aGlh cyBCcnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPg0KPiBDYzogbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IENjOiBsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRl YWQub3JnDQo+IC0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMg ICB8IDE2ICsrKystDQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9mYi5jICAg IHwgOTIgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2RybV9mYi5oICAgIHwgMTMgLS0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fcGxhbmUuYyB8ICAxIC0NCj4gIDQgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9u cygrKSwgMTA3IGRlbGV0aW9ucygtKQ0KPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1 L2RybS9tZWRpYXRlay9tdGtfZHJtX2ZiLmMNCj4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBkcml2ZXJz L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9mYi5oDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2RybV9kcnYuYw0KPiBpbmRleCA4NGQxNDIxM2Q5OTIuLjJiMWMxMjIwNjZlYSAxMDA2 NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMNCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMNCj4gQEAgLTE2LDggKzE2 LDEwIEBADQo+ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+DQo+ICAjaW5jbHVk ZSA8ZHJtL2RybV9kcnYuaD4NCj4gICNpbmNsdWRlIDxkcm0vZHJtX2ZiX2hlbHBlci5oPg0KPiAr I2luY2x1ZGUgPGRybS9kcm1fZm91cmNjLmg+DQo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW0uaD4N Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2dlbV9jbWFfaGVscGVyLmg+DQo+ICsjaW5jbHVkZSA8ZHJt L2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmg+DQo+ICAjaW5jbHVkZSA8ZHJtL2RybV9vZi5o Pg0KPiAgI2luY2x1ZGUgPGRybS9kcm1fcHJvYmVfaGVscGVyLmg+DQo+ICAjaW5jbHVkZSA8ZHJt L2RybV92YmxhbmsuaD4NCj4gQEAgLTI3LDcgKzI5LDYgQEANCj4gICNpbmNsdWRlICJtdGtfZHJt X2RkcC5oIg0KPiAgI2luY2x1ZGUgIm10a19kcm1fZGRwX2NvbXAuaCINCj4gICNpbmNsdWRlICJt dGtfZHJtX2Rydi5oIg0KPiAtI2luY2x1ZGUgIm10a19kcm1fZmIuaCINCj4gICNpbmNsdWRlICJt dGtfZHJtX2dlbS5oIg0KPiAgDQo+ICAjZGVmaW5lIERSSVZFUl9OQU1FICJtZWRpYXRlayINCj4g QEAgLTExNSw2ICsxMTYsMTkgQEAgc3RhdGljIGludCBtdGtfYXRvbWljX2NvbW1pdChzdHJ1Y3Qg ZHJtX2RldmljZSAqZHJtLA0KPiAgCXJldHVybiAwOw0KPiAgfQ0KPiAgDQo+ICtzdGF0aWMgc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqDQo+ICttdGtfZHJtX21vZGVfZmJfY3JlYXRlKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsDQo+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsDQo+ICsJ CSAgICAgICBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqY21kKQ0KPiArew0KPiArCWNv bnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8gPSBkcm1fZ2V0X2Zvcm1hdF9pbmZvKGRl diwgY21kKTsNCj4gKw0KPiArCWlmIChpbmZvLT5udW1fcGxhbmVzICE9IDEpDQo+ICsJCXJldHVy biBFUlJfUFRSKC1FSU5WQUwpOw0KPiArDQo+ICsJcmV0dXJuIGRybV9nZW1fZmJfY3JlYXRlKGRl diwgZmlsZSwgY21kKTsNCj4gK30NCj4gKw0KPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fbW9k ZV9jb25maWdfZnVuY3MgbXRrX2RybV9tb2RlX2NvbmZpZ19mdW5jcyA9IHsNCj4gIAkuZmJfY3Jl YXRlID0gbXRrX2RybV9tb2RlX2ZiX2NyZWF0ZSwNCj4gIAkuYXRvbWljX2NoZWNrID0gZHJtX2F0 b21pY19oZWxwZXJfY2hlY2ssDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2RybV9mYi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZmIuYw0K PiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQNCj4gaW5kZXggM2YyMzBhMjhhMmRjLi4wMDAwMDAw MDAwMDANCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZmIuYw0KPiAr KysgL2Rldi9udWxsDQo+IEBAIC0xLDkyICswLDAgQEANCj4gLS8vIFNQRFgtTGljZW5zZS1JZGVu dGlmaWVyOiBHUEwtMi4wLW9ubHkNCj4gLS8qDQo+IC0gKiBDb3B5cmlnaHQgKGMpIDIwMTUgTWVk aWFUZWsgSW5jLg0KPiAtICovDQo+IC0NCj4gLSNpbmNsdWRlIDxsaW51eC9kbWEtYnVmLmg+DQo+ IC0jaW5jbHVkZSA8bGludXgvZG1hLXJlc3YuaD4NCj4gLQ0KPiAtI2luY2x1ZGUgPGRybS9kcm1f bW9kZXNldF9oZWxwZXIuaD4NCj4gLSNpbmNsdWRlIDxkcm0vZHJtX2ZiX2hlbHBlci5oPg0KPiAt I2luY2x1ZGUgPGRybS9kcm1fZm91cmNjLmg+DQo+IC0jaW5jbHVkZSA8ZHJtL2RybV9nZW0uaD4N Cj4gLSNpbmNsdWRlIDxkcm0vZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuaD4NCj4gLQ0KPiAt I2luY2x1ZGUgIm10a19kcm1fZHJ2LmgiDQo+IC0jaW5jbHVkZSAibXRrX2RybV9mYi5oIg0KPiAt I2luY2x1ZGUgIm10a19kcm1fZ2VtLmgiDQo+IC0NCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJt X2ZyYW1lYnVmZmVyX2Z1bmNzIG10a19kcm1fZmJfZnVuY3MgPSB7DQo+IC0JLmNyZWF0ZV9oYW5k bGUgPSBkcm1fZ2VtX2ZiX2NyZWF0ZV9oYW5kbGUsDQo+IC0JLmRlc3Ryb3kgPSBkcm1fZ2VtX2Zi X2Rlc3Ryb3ksDQo+IC19Ow0KPiAtDQo+IC1zdGF0aWMgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAq bXRrX2RybV9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsDQo+IC0JCQkJ CWNvbnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICptb2RlLA0KPiAtCQkJCQlzdHJ1Y3QgZHJt X2dlbV9vYmplY3QgKm9iaikNCj4gLXsNCj4gLQljb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9pbmZv ICppbmZvID0gZHJtX2dldF9mb3JtYXRfaW5mbyhkZXYsIG1vZGUpOw0KPiAtCXN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiOw0KPiAtCWludCByZXQ7DQo+IC0NCj4gLQlpZiAoaW5mby0+bnVtX3Bs YW5lcyAhPSAxKQ0KPiAtCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsNCj4gLQ0KPiAtCWZiID0g a3phbGxvYyhzaXplb2YoKmZiKSwgR0ZQX0tFUk5FTCk7DQo+IC0JaWYgKCFmYikNCj4gLQkJcmV0 dXJuIEVSUl9QVFIoLUVOT01FTSk7DQo+IC0NCj4gLQlkcm1faGVscGVyX21vZGVfZmlsbF9mYl9z dHJ1Y3QoZGV2LCBmYiwgbW9kZSk7DQo+IC0NCj4gLQlmYi0+b2JqWzBdID0gb2JqOw0KPiAtDQo+ IC0JcmV0ID0gZHJtX2ZyYW1lYnVmZmVyX2luaXQoZGV2LCBmYiwgJm10a19kcm1fZmJfZnVuY3Mp Ow0KPiAtCWlmIChyZXQpIHsNCj4gLQkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gaW5pdGlhbGl6ZSBm cmFtZWJ1ZmZlclxuIik7DQo+IC0JCWtmcmVlKGZiKTsNCj4gLQkJcmV0dXJuIEVSUl9QVFIocmV0 KTsNCj4gLQl9DQo+IC0NCj4gLQlyZXR1cm4gZmI7DQo+IC19DQo+IC0NCj4gLXN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKm10a19kcm1fbW9kZV9mYl9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRl diwNCj4gLQkJCQkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwNCj4gLQkJCQkJICAgICAg IGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICpjbWQpDQo+IC17DQo+IC0JY29uc3Qgc3Ry dWN0IGRybV9mb3JtYXRfaW5mbyAqaW5mbyA9IGRybV9nZXRfZm9ybWF0X2luZm8oZGV2LCBjbWQp Ow0KPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOw0KPiAtCXN0cnVjdCBkcm1fZ2VtX29i amVjdCAqZ2VtOw0KPiAtCXVuc2lnbmVkIGludCB3aWR0aCA9IGNtZC0+d2lkdGg7DQo+IC0JdW5z aWduZWQgaW50IGhlaWdodCA9IGNtZC0+aGVpZ2h0Ow0KPiAtCXVuc2lnbmVkIGludCBzaXplLCBi cHA7DQo+IC0JaW50IHJldDsNCj4gLQ0KPiAtCWlmIChpbmZvLT5udW1fcGxhbmVzICE9IDEpDQo+ IC0JCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOw0KPiAtDQo+IC0JZ2VtID0gZHJtX2dlbV9vYmpl Y3RfbG9va3VwKGZpbGUsIGNtZC0+aGFuZGxlc1swXSk7DQo+IC0JaWYgKCFnZW0pDQo+IC0JCXJl dHVybiBFUlJfUFRSKC1FTk9FTlQpOw0KPiAtDQo+IC0JYnBwID0gaW5mby0+Y3BwWzBdOw0KPiAt CXNpemUgPSAoaGVpZ2h0IC0gMSkgKiBjbWQtPnBpdGNoZXNbMF0gKyB3aWR0aCAqIGJwcDsNCj4g LQlzaXplICs9IGNtZC0+b2Zmc2V0c1swXTsNCj4gLQ0KPiAtCWlmIChnZW0tPnNpemUgPCBzaXpl KSB7DQo+IC0JCXJldCA9IC1FSU5WQUw7DQo+IC0JCWdvdG8gdW5yZWZlcmVuY2U7DQo+IC0JfQ0K PiAtDQo+IC0JZmIgPSBtdGtfZHJtX2ZyYW1lYnVmZmVyX2luaXQoZGV2LCBjbWQsIGdlbSk7DQo+ IC0JaWYgKElTX0VSUihmYikpIHsNCj4gLQkJcmV0ID0gUFRSX0VSUihmYik7DQo+IC0JCWdvdG8g dW5yZWZlcmVuY2U7DQo+IC0JfQ0KPiAtDQo+IC0JcmV0dXJuIGZiOw0KPiAtDQo+IC11bnJlZmVy ZW5jZToNCj4gLQlkcm1fZ2VtX29iamVjdF9wdXRfdW5sb2NrZWQoZ2VtKTsNCj4gLQlyZXR1cm4g RVJSX1BUUihyZXQpOw0KPiAtfQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kcm1fZmIuaCBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2ZiLmgN Cj4gZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0DQo+IGluZGV4IGViNjRkMjYwMDFjNi4uMDAwMDAw MDAwMDAwDQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2ZiLmgNCj4g KysrIC9kZXYvbnVsbA0KPiBAQCAtMSwxMyArMCwwIEBADQo+IC0vKiBTUERYLUxpY2Vuc2UtSWRl bnRpZmllcjogR1BMLTIuMC1vbmx5ICovDQo+IC0vKg0KPiAtICogQ29weXJpZ2h0IChjKSAyMDE1 IE1lZGlhVGVrIEluYy4NCj4gLSAqLw0KPiAtDQo+IC0jaWZuZGVmIE1US19EUk1fRkJfSA0KPiAt I2RlZmluZSBNVEtfRFJNX0ZCX0gNCj4gLQ0KPiAtc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqbXRr X2RybV9tb2RlX2ZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LA0KPiAtCQkJCQkgICAg ICAgc3RydWN0IGRybV9maWxlICpmaWxlLA0KPiAtCQkJCQkgICAgICAgY29uc3Qgc3RydWN0IGRy bV9tb2RlX2ZiX2NtZDIgKmNtZCk7DQo+IC0NCj4gLSNlbmRpZiAvKiBNVEtfRFJNX0ZCX0ggKi8N Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX3BsYW5lLmMg Yi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9wbGFuZS5jDQo+IGluZGV4IDNiMGNj OTFjNzAyMy4uNTQwZWYyZmFhNDBhIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVk aWF0ZWsvbXRrX2RybV9wbGFuZS5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX3BsYW5lLmMNCj4gQEAgLTEzLDcgKzEzLDYgQEANCj4gICNpbmNsdWRlICJtdGtfZHJt X2NydGMuaCINCj4gICNpbmNsdWRlICJtdGtfZHJtX2RkcF9jb21wLmgiDQo+ICAjaW5jbHVkZSAi bXRrX2RybV9kcnYuaCINCj4gLSNpbmNsdWRlICJtdGtfZHJtX2ZiLmgiDQo+ICAjaW5jbHVkZSAi bXRrX2RybV9nZW0uaCINCj4gICNpbmNsdWRlICJtdGtfZHJtX3BsYW5lLmgiDQo+ICANCg0KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs