From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEF26C282DD for ; Wed, 8 Jan 2020 14:53:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DA5B206F0 for ; Wed, 8 Jan 2020 14:53:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DA5B206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B630A6E31E; Wed, 8 Jan 2020 14:53:16 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id E653789FC9; Wed, 8 Jan 2020 14:53:14 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19810076-1500050 for multiple; Wed, 08 Jan 2020 14:53:11 +0000 MIME-Version: 1.0 To: Jani Nikula , Joonas Lahtinen , Wambui Karuga , airlied@linux.ie, daniel@ffwll.ch, rodrigo.vivi@intel.com From: Chris Wilson In-Reply-To: <87v9pmovmx.fsf@intel.com> References: <157847199686.4725.87481257304852182@jlahtine-desk.ger.corp.intel.com> <8736cqs2uf.fsf@intel.com> <157848029770.2273.9590955422248556735@skylake-alporthouse-com> <87v9pmovmx.fsf@intel.com> Message-ID: <157849519000.2273.18061101721039254369@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915: convert to using the drm_dbg_kms() macro. Date: Wed, 08 Jan 2020 14:53:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, seanpaul@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Jani Nikula (2020-01-08 14:44:38) > On Wed, 08 Jan 2020, Chris Wilson wrote: > > Quoting Jani Nikula (2020-01-08 09:40:40) > >> On Wed, 08 Jan 2020, Joonas Lahtinen wrote: > >> > Quoting Wambui Karuga (2020-01-07 17:13:29) > >> >> Convert the use of the DRM_DEBUG_KMS() logging macro to the new struct > >> >> drm_device based drm_dbg_kms() logging macro in i915/intel_pch.c. > >> >> > >> >> Signed-off-by: Wambui Karuga > >> >> --- > >> >> drivers/gpu/drm/i915/intel_pch.c | 46 +++++++++++++++++--------------- > >> >> 1 file changed, 24 insertions(+), 22 deletions(-) > >> >> > >> >> diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c > >> >> index 43b68b5fc562..4ed60e1f01db 100644 > >> >> --- a/drivers/gpu/drm/i915/intel_pch.c > >> >> +++ b/drivers/gpu/drm/i915/intel_pch.c > >> >> @@ -12,90 +12,91 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id) > >> >> { > >> >> switch (id) { > >> >> case INTEL_PCH_IBX_DEVICE_ID_TYPE: > >> >> - DRM_DEBUG_KMS("Found Ibex Peak PCH\n"); > >> >> + drm_dbg_kms(&dev_priv->drm, "Found Ibex Peak PCH\n"); > >> > > >> > Did we at some point consider i915_dbg_kms alias? That would just take > >> > dev_priv (or i915, as it's called in newer code). It would shorten many > >> > of the statements. > >> > > >> > i915_dbg_kms(dev_priv, ...) or i915_dbg_kms(i915, ...) > >> > >> I'd rather use the common drm logging macros. I thought about adding > >> i915 specific ones only if the drm device specific logging macros > >> weren't going to be merged. > > > > Why do they even exist? Why isn't it enough to do > > #define drm_info(drm, fmt, ...) dev_info(&(drm)->dev, fmt, ##__VA_ARGS) ? > > It *is* enough to do that, and that's essentially what the new macros > do, just with an extra helper macro in between. /o\ Mistook __drm_printk() for the older drm_dev_printk() -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel