From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5AFC33CA1 for ; Mon, 20 Jan 2020 10:11:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADD7F2073A for ; Mon, 20 Jan 2020 10:11:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADD7F2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 530E26E89D; Mon, 20 Jan 2020 10:11:55 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 896EC6E899; Mon, 20 Jan 2020 10:11:53 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19943394-1500050 for multiple; Mon, 20 Jan 2020 09:54:34 +0000 MIME-Version: 1.0 From: Chris Wilson User-Agent: alot/0.6 To: akeem.g.abodunrin@intel.com, d.scott.phillips@intel.com, daniel.vetter@intel.com, david.c.stewart@intel.com, dri-devel@lists.freedesktop.org, francesco.balestrieri@intel.com, intel-gfx@lists.freedesktop.org, jani.nikula@intel.com, jon.bloomfield@intel.com, joonas.lahtinen@linux.intel.com, mika.kuoppala@intel.com, omer.aran@intel.com, pragyansri.pathi@intel.com, prathap.kumar.valsan@intel.com, sudeep.dutt@intel.com, tony.luck@intel.com References: <20200116174655.85926-1-akeem.g.abodunrin@intel.com> <20200116174655.85926-3-akeem.g.abodunrin@intel.com> In-Reply-To: <20200116174655.85926-3-akeem.g.abodunrin@intel.com> Message-ID: <157951407310.10361.13824742770612575826@skylake-alporthouse-com> Subject: Re: [RFC PATCH v3 2/2] drm/i915/gen7: Clear all EU/L3 residual contexts Date: Mon, 20 Jan 2020 09:54:33 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Akeem G Abodunrin (2020-01-16 17:46:55) > +static u32 > +gen7_fill_interface_descriptor(struct batch_chunk *state, > + const struct batch_vals *bv, > + const struct cb_kernel *kernel, > + unsigned int count) > +{ > + u32 *cs = batch_alloc_items(state, 32, 8 * count); > + u32 offset = batch_offset(state, cs); > + > + *cs++ = gen7_fill_kernel_data(state, kernel->data, kernel->size); > + *cs++ = (1 << 7) | (1 << 13); > + *cs++ = 0; > + *cs++ = (gen7_fill_binding_table(state, bv) - state->offset) | 1; > + *cs++ = 0; > + *cs++ = 0; > + *cs++ = 0; > + *cs++ = 0; > + /* 1 - 63dummy idds */ > + memset32(cs, 0x00, (count - 1) * 8); > + batch_advance(state, cs); cs is not at the end of the pack here. [cs + (count - 1) * 8] > + > + return offset; > +} All others look ok. -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel