From: CK Hu <ck.hu@mediatek.com>
To: <matthias.bgg@kernel.org>
Cc: mark.rutland@arm.com, airlied@linux.ie, mturquette@baylibre.com,
dri-devel@lists.freedesktop.org,
laurent.pinchart@ideasonboard.com,
ulrich.hecht+renesas@gmail.com, linux-clk@vger.kernel.org,
drinkcat@chromium.org, Weiyi Lu <weiyi.lu@mediatek.com>,
wens@csie.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, frank-w@public-files.de,
sean.wang@mediatek.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, hsinyi@chromium.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <mbrugger@suse.com>,
sboyd@kernel.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, enric.balletbo@collabora.com
Subject: Re: [PATCH v7 11/13] clk: mediatek: mt8183: switch mmsys to platform device probing
Date: Fri, 14 Feb 2020 09:52:41 +0800 [thread overview]
Message-ID: <1581645161.22833.6.camel@mtksdaap41> (raw)
In-Reply-To: <20200213201953.15268-12-matthias.bgg@kernel.org>
Hi, Matthias:
On Thu, 2020-02-13 at 21:19 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Switch probing for the MMSYS to support invocation to a
> plain paltform device. The driver will be probed by the DRM subsystem.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
> Changes in v7:
> - free clk_data->clks as well
> - get rid of private data structure
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/clk/mediatek/clk-mt8183-mm.c | 30 ++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt8183-mm.c b/drivers/clk/mediatek/clk-mt8183-mm.c
> index 720c696b506d..7576cd231be3 100644
> --- a/drivers/clk/mediatek/clk-mt8183-mm.c
> +++ b/drivers/clk/mediatek/clk-mt8183-mm.c
> @@ -3,8 +3,10 @@
> // Copyright (c) 2018 MediaTek Inc.
> // Author: Weiyi Lu <weiyi.lu@mediatek.com>
>
> +#include <linux/module.h>
> #include <linux/clk-provider.h>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> #include "clk-mtk.h"
> #include "clk-gate.h"
> @@ -85,27 +87,35 @@ static const struct mtk_gate mm_clks[] = {
> static int clk_mt8183_mm_probe(struct platform_device *pdev)
> {
> struct clk_onecell_data *clk_data;
> - struct device_node *node = pdev->dev.of_node;
> + struct device_node *node = pdev->dev.parent->of_node;
> +
> + clk_data = devm_kzalloc(&pdev->dev, sizeof(*clk_data), GFP_KERNEL);
I think this is redundant.
> + if (!clk_data)
> + return -ENOMEM;
>
> clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK);
> + platform_set_drvdata(pdev, clk_data);
>
> - mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks),
> - clk_data);
> + mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks), clk_data);
>
> return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> }
>
> -static const struct of_device_id of_match_clk_mt8183_mm[] = {
> - { .compatible = "mediatek,mt8183-mmsys", },
> - {}
> -};
> +static int clk_mt8183_mm_remove(struct platform_device *pdev)
> +{
> + struct clk_onecell_data *clk_data = platform_get_drvdata(pdev);
> +
> + kfree(clk_data->clks);
> + kfree(clk_data);
These two statement looks like a reverse of mtk_alloc_clk_data() and
exist in many files. It is worth to have a function (maybe
mtk_free_clk_data()) to do this.
In addition, should we undo what is done in clk_mt8183_mm_probe() such
as mtk_clk_register_gates() and of_clk_add_provider()?
Regards,
CK
> +
> + return 0;
> +}
>
> static struct platform_driver clk_mt8183_mm_drv = {
> .probe = clk_mt8183_mm_probe,
> + .remove = clk_mt8183_mm_remove,
> .driver = {
> .name = "clk-mt8183-mm",
> - .of_match_table = of_match_clk_mt8183_mm,
> },
> };
> -
> -builtin_platform_driver(clk_mt8183_mm_drv);
> +module_platform_driver(clk_mt8183_mm_drv);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-14 2:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:19 [PATCH v7 00/13] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg
2020-02-13 20:19 ` [PATCH v7 01/13] dt-bindings: arm: move mmsys description to display matthias.bgg
2020-02-14 6:42 ` CK Hu
2020-02-14 10:01 ` Matthias Brugger
2020-02-14 12:19 ` Enric Balletbo i Serra
2020-02-14 16:22 ` CK Hu
2020-02-13 20:19 ` [PATCH v7 02/13] dt-bindings: display: mediatek: Add mmsys binding description matthias.bgg
2020-02-18 20:31 ` Rob Herring
2020-02-13 20:19 ` [PATCH v7 03/13] dt-bindings: mediatek: Add compatible for mt7623 matthias.bgg
2020-02-13 20:19 ` [PATCH v7 04/13] drm/mediatek: Use regmap for register access matthias.bgg
2020-02-13 20:19 ` [PATCH v7 05/13] drm: mediatek: Omit warning on probe defers matthias.bgg
2020-02-13 20:19 ` [PATCH v7 06/13] media: mtk-mdp: Check return value of of_clk_get matthias.bgg
2020-02-24 17:36 ` Hans Verkuil
2020-02-24 21:47 ` Matthias Brugger
2020-02-13 20:19 ` [PATCH v7 07/13] clk: mediatek: mt2701: switch mmsys to platform device probing matthias.bgg
2020-02-13 20:19 ` [PATCH v7 08/13] clk: mediatek: mt2712e: switch " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 09/13] clk: mediatek: mt6779: switch mmsys " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 10/13] clk: mediatek: mt6797: switch " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 11/13] clk: mediatek: mt8183: switch mmsys " matthias.bgg
2020-02-14 1:52 ` CK Hu [this message]
2020-02-13 20:19 ` [PATCH v7 12/13] clk: mediatek: mt8173: " matthias.bgg
2020-02-13 20:19 ` [PATCH v7 13/13] drm/mediatek: Add support for mmsys through a pdev matthias.bgg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581645161.22833.6.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=frank-w@public-files.de \
--cc=hsinyi@chromium.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mturquette@baylibre.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=weiyi.lu@mediatek.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).