From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C624AC3F2CD for ; Tue, 3 Mar 2020 08:25:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1BFE208C3 for ; Tue, 3 Mar 2020 08:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="htEffhcN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1BFE208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DAF56EA2F; Tue, 3 Mar 2020 08:24:18 +0000 (UTC) Received: from crapouillou.net (outils.crapouillou.net [89.234.176.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED15E6E81F for ; Mon, 2 Mar 2020 20:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1583179977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8mcvwXysboc6lUOt6zTKT2nv7+SBichgLaPRTC6LfW8=; b=htEffhcNlkFPzgSf0sWu1yxp7HbzfJo3+3witOMCzD/FBIUbMaU55HTwnkwVHvfe6eBUCI 0zCnsCm5h+HJ7GLyrgY86QF2GPcCIdbsTO6fYevwQWgDfxf0ZK6GH/QQndGA9hEFiGghNI 79i05C2EwId3bTXB0BxWf2VqOwYZo8A= Date: Mon, 02 Mar 2020 17:12:40 -0300 From: Paul Cercueil Subject: Re: [PATCH 16/51] drm/inigenic: Use drmm_add_final_kfree To: Daniel Vetter Message-Id: <1583179960.3.7@crapouillou.net> In-Reply-To: <20200227181522.2711142-17-daniel.vetter@ffwll.ch> References: <20200227181522.2711142-1-daniel.vetter@ffwll.ch> <20200227181522.2711142-17-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 03 Mar 2020 08:24:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , m.felsch@pengutronix.de, DRI Development Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, Le jeu., f=E9vr. 27, 2020 at 19:14, Daniel Vetter = a =E9crit : > With this we can drop the final kfree from the release function. > = > Signed-off-by: Daniel Vetter > Cc: Paul Cercueil Reviewed-by: Paul Cercueil Cheers, -Paul > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c = > b/drivers/gpu/drm/ingenic/ingenic-drm.c > index 9dfe7cb530e1..e2c832eb4e9a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -490,11 +491,8 @@ static irqreturn_t ingenic_drm_irq_handler(int = > irq, void *arg) > = > static void ingenic_drm_release(struct drm_device *drm) > { > - struct ingenic_drm *priv =3D drm_device_get_priv(drm); > - > drm_mode_config_cleanup(drm); > drm_dev_fini(drm); > - kfree(priv); > } > = > static int ingenic_drm_enable_vblank(struct drm_crtc *crtc) > @@ -639,6 +637,7 @@ static int ingenic_drm_probe(struct = > platform_device *pdev) > kfree(priv); > return ret; > } > + drmm_add_final_kfree(drm, priv); > = > drm_mode_config_init(drm); > drm->mode_config.min_width =3D 0; > -- > 2.24.1 > = _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel