From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA05C43331 for ; Fri, 27 Mar 2020 06:15:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63FDF2071B for ; Fri, 27 Mar 2020 06:15:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cq0Vufjh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63FDF2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96BA56E989; Fri, 27 Mar 2020 06:15:40 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id A684A6E989 for ; Fri, 27 Mar 2020 06:15:39 +0000 (UTC) Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6CA71206E6; Fri, 27 Mar 2020 06:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585289739; bh=58KuB2EdmdqAA/if2WjPCh2gfILqrjtvKlUR+JH3qxc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cq0Vufjh+D/dECAV8urvcwHeWZa4S6cF2/G4FE0/lylDORUFLMJXs7SuFz/U7yd1u 9JP+02dqyjSaN1y61iVgQfqNlw9AVNxfZzHXVWeiUFLXfZy9l1gt8K1IhWwqntJqYq BrzzB5oGp+k4BKuN5nUIRgMDDe0sUXPhfWJdQg3k= MIME-Version: 1.0 In-Reply-To: <20200325220542.19189-5-robh@kernel.org> References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-5-robh@kernel.org> Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' From: Stephen Boyd To: Rob Herring , devicetree@vger.kernel.org Date: Thu, 26 Mar 2020 23:15:38 -0700 Message-ID: <158528973872.125146.8143173056879958106@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Guillaume La Roque , Peter Meerwald-Stadler , Lee Jones , linux-clk@vger.kernel.org, Kevin Hilman , Daniel Lezcano , Bartosz Golaszewski , Zhang Rui , Brian Masney , Michael Hennerich , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Mauro Carvalho Chehab , linux-gpio@vger.kernel.org, Mark Brown , linux-amlogic@lists.infradead.org, Thomas Gleixner , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Liam Girdwood , Hartmut Knaack , linux-media@vger.kernel.org, "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Rob Herring (2020-03-25 15:05:41) > Setting 'additionalProperties: false' is frequently omitted, but is > important in order to check that there aren't extra undocumented > properties in a binding. > > Ideally, we'd just add this automatically and make this the default, but > there's some cases where it doesn't work. For example, if a common > schema is referenced, then properties in the common schema aren't part > of what's considered for 'additionalProperties'. Also, sometimes there > are bus specific properties such as 'spi-max-frequency' that go into > bus child nodes, but aren't defined in the child node's schema. > > So let's stick with the json-schema defined default and add > 'additionalProperties: false' where needed. This will be a continual > review comment and game of wack-a-mole. > > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/clock/fsl,plldig.yaml | 2 ++ > Documentation/devicetree/bindings/clock/imx8mn-clock.yaml | 2 ++ > Documentation/devicetree/bindings/clock/imx8mp-clock.yaml | 2 ++ > Documentation/devicetree/bindings/clock/milbeaut-clock.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-msm8996.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-msm8998.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-qcs404.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-sc7180.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc-sm8150.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,mmcc.yaml | 2 ++ > .../devicetree/bindings/clock/qcom,msm8998-gpucc.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 2 ++ > .../devicetree/bindings/clock/qcom,sc7180-dispcc.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml | 2 ++ > .../devicetree/bindings/clock/qcom,sc7180-videocc.yaml | 2 ++ > .../devicetree/bindings/clock/qcom,sdm845-dispcc.yaml | 2 ++ > Documentation/devicetree/bindings/clock/qcom,sdm845-gpucc.yaml | 2 ++ > .../devicetree/bindings/clock/qcom,sdm845-videocc.yaml | 2 ++ > Acked-by: Stephen Boyd # clock _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel