From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A288C63798 for ; Fri, 27 Nov 2020 13:53:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CD3422240 for ; Fri, 27 Nov 2020 13:53:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CD3422240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 542E86EDCA; Fri, 27 Nov 2020 13:53:01 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BBD06EDC6; Fri, 27 Nov 2020 13:52:58 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23133764-1500050 for multiple; Fri, 27 Nov 2020 13:52:54 +0000 MIME-Version: 1.0 In-Reply-To: <20201127120718.454037-119-matthew.auld@intel.com> References: <20201127120718.454037-1-matthew.auld@intel.com> <20201127120718.454037-119-matthew.auld@intel.com> Subject: Re: [Intel-gfx] [RFC PATCH 118/162] drm/i915/dg1: Reserve first 1MB of local memory From: Chris Wilson To: Matthew Auld , intel-gfx@lists.freedesktop.org Date: Fri, 27 Nov 2020 13:52:54 +0000 Message-ID: <160648517402.2925.2248861493310859776@build.alporthouse.com> User-Agent: alot/0.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Matthew Auld (2020-11-27 12:06:34) > From: Imre Deak > > On DG1 A0/B0 steppings the first 1MB of local memory must be reserved. > One reason for this is that the 0xA0000-0xB0000 range is not accessible > by the display, probably since this region is redirected to another > memory location for legacy VGA compatibility. > > BSpec: 50586 > Testcase: igt/kms_big_fb/linear-64bpp-rotate-0 > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_region_lmem.c | 52 ++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c b/drivers/gpu/drm/i915/intel_region_lmem.c > index 939cf0d195a5..eafef7034680 100644 > --- a/drivers/gpu/drm/i915/intel_region_lmem.c > +++ b/drivers/gpu/drm/i915/intel_region_lmem.c > @@ -137,6 +137,48 @@ intel_setup_fake_lmem(struct drm_i915_private *i915) > return mem; > } > > +static void get_legacy_lowmem_region(struct intel_uncore *uncore, > + u64 *start, u32 *size) > +{ > + *start = 0; > + *size = 0; > + > + if (!IS_DG1_REVID(uncore->i915, DG1_REVID_A0, DG1_REVID_B0)) > + return; > + > + *size = SZ_1M; > + > + DRM_DEBUG_DRIVER("LMEM: reserved legacy low-memory [0x%llx-0x%llx]\n", > + *start, *start + *size); > +} > + > +static int reserve_lowmem_region(struct intel_uncore *uncore, > + struct intel_memory_region *mem) > +{ > + u64 reserve_start; > + u64 reserve_end; > + u64 region_start; > + u32 region_size; > + int ret; > + > + get_legacy_lowmem_region(uncore, ®ion_start, ®ion_size); > + reserve_start = region_start; > + reserve_end = region_start + region_size; > + > + if (!reserve_end) > + return 0; > + > + DRM_INFO("LMEM: reserving low-memory region [0x%llx-0x%llx]\n", > + reserve_start, reserve_end); > + ret = i915_buddy_alloc_range(&mem->mm, &mem->reserved, > + reserve_start, > + reserve_end - reserve_start); Isn't this now relative to the stolen offset? Should this be reserved, or excluded like stolen? -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel